Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Robin Murphy <robin.murphy@arm.com>, khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2
Date: Wed, 22 May 2019 09:59:50 +0200
Message-ID: <5c95de8f-b611-8286-db5f-bbb3ae97c24f@baylibre.com> (raw)
In-Reply-To: <4eb6aa5c-14e2-944e-9f15-692063ef072b@arm.com>

On 21/05/2019 18:11, Robin Murphy wrote:
> On 21/05/2019 16:19, Neil Armstrong wrote:
> [...]
>> +        cpu100: cpu@100 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
> 
> Nit: we've recently tried to eradicate "arm,armv8" as a fallback compatible for real CPUs (although I see there are still a couple of instances that have slipped through).

Thanks for pointing this, I'll remove it.

Neil

> 
> Robin.
> 
>> +            reg = <0x0 0x100>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu101: cpu@101 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x101>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu102: cpu@102 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x102>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +
>> +        cpu103: cpu@103 {
>> +            device_type = "cpu";
>> +            compatible = "arm,cortex-a73", "arm,armv8";
>> +            reg = <0x0 0x103>;
>> +            enable-method = "psci";
>> +            next-level-cache = <&l2>;
>> +        };
>> +    };
>> +};
>> +
>> +&clkc {
>> +    compatible = "amlogic,g12b-clkc";
>> +};
>>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 15:19 [PATCH v3 0/3] arm64: Add initial " Neil Armstrong
2019-05-21 15:19 ` [PATCH v3 1/3] dt-bindings: arm: amlogic: add G12B bindings Neil Armstrong
2019-05-21 17:27   ` Martin Blumenstingl
2019-05-21 15:19 ` [PATCH v3 2/3] dt-bindings: arm: amlogic: add Odroid-N2 binding Neil Armstrong
2019-05-21 15:26   ` Rob Herring
2019-05-21 17:26   ` Martin Blumenstingl
2019-05-21 15:19 ` [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2 Neil Armstrong
2019-05-21 16:11   ` Robin Murphy
2019-05-22  7:59     ` Neil Armstrong [this message]
2019-05-21 18:01   ` Martin Blumenstingl
2019-05-22  8:19     ` Neil Armstrong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c95de8f-b611-8286-db5f-bbb3ae97c24f@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox