From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 349F2C433E0 for ; Tue, 9 Mar 2021 06:16:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6D0D650EC for ; Tue, 9 Mar 2021 06:16:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6D0D650EC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BvP3casvGbnaW7eZbZ5S97UyTma7SYVEhbA/RI40S9k=; b=XH2SXt9KwbsPdH/xGy4UMfLDB CjNpZeqSnQsv2MKfywRdihJuDXHP9GW5Qv0r/EUsbcRukEDwDCOiSaOgyyebSc8KhULPbWfOea/mA VIw3qZTl11dWidzh8bGqnJQL8ae2kZs/Ko2zsQcNu1KbZ3INiG+hX0TCUnGKKeZCZLTaDAvSUHrbh 1NZfaClFk4hIogcZDreWyqCJVSpUaxotDsQt3wf5dHsTrEZa2osDJKwDmRtZC/TAJkpS1qXd+Htoc Tmyo/Gc1XHcGlcoPTJLJHcBg4hqUW3c9qIcWfnyyQVPqGdsCIrIhEzb6S8dfjjCDN3TcZZRUKygMc 1jDpVSb1Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJVdk-003rah-SH; Tue, 09 Mar 2021 06:14:45 +0000 Received: from mx2.suse.de ([195.135.220.15]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJVdg-003raH-19 for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 06:14:42 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1615270479; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Szn8CoKcdFhLmILaUcNU5Mw5xCclHsTUFexJC8stRy4=; b=jPjIK0O/HZtDDoN9i5q9qE9tCBF+qqDn/LLQf1IVkph/JDoObaw8ldwo6HNokrvlhNodgL Vs85iV11L2fM3q2k47ZOpXDOg6M687QX/KgVkfAXyk4PzKrZF8y74kYMkCJgwRL2t8uQV6 Lgy5TUIAMbtKoMqVu92zSt/DdCmoRak= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 378E8AC24; Tue, 9 Mar 2021 06:14:39 +0000 (UTC) Subject: Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-3-jgross@suse.com> <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <5cea7551-ce84-c084-ddaf-e84075823bd8@suse.com> Date: Tue, 9 Mar 2021 07:14:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_061440_260949_43DE1432 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3671949237365185801==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3671949237365185801== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6 Content-Type: multipart/mixed; boundary="WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Boris Ostrovsky , xen-devel@lists.xenproject.org, x86@kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, kvm@vger.kernel.org Cc: Deep Shah , "VMware, Inc." , Russell King , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Stefano Stabellini Message-ID: <5cea7551-ce84-c084-ddaf-e84075823bd8@suse.com> Subject: Re: [PATCH v5 02/12] x86/paravirt: switch time pvops functions to use static_call() References: <20210308122844.30488-1-jgross@suse.com> <20210308122844.30488-3-jgross@suse.com> <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> In-Reply-To: <1346dbb1-c43e-9ac2-10e4-3c10cb2ead78@oracle.com> --WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP Content-Type: multipart/mixed; boundary="------------F998C827E1466225E03A1952" Content-Language: en-US This is a multi-part message in MIME format. --------------F998C827E1466225E03A1952 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 08.03.21 18:00, Boris Ostrovsky wrote: >=20 > On 3/8/21 7:28 AM, Juergen Gross wrote: >> --- a/arch/x86/xen/time.c >> +++ b/arch/x86/xen/time.c >> @@ -379,11 +379,6 @@ void xen_timer_resume(void) >> } >> } >> =20 >> -static const struct pv_time_ops xen_time_ops __initconst =3D { >> - .sched_clock =3D xen_sched_clock, >> - .steal_clock =3D xen_steal_clock, >> -}; >> - >> static struct pvclock_vsyscall_time_info *xen_clock __read_mostly; >> static u64 xen_clock_value_saved; >> =20 >> @@ -528,7 +523,8 @@ static void __init xen_time_init(void) >> void __init xen_init_time_ops(void) >> { >> xen_sched_clock_offset =3D xen_clocksource_read(); >> - pv_ops.time =3D xen_time_ops; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> + paravirt_set_sched_clock(xen_sched_clock); >> =20 >> x86_init.timers.timer_init =3D xen_time_init; >> x86_init.timers.setup_percpu_clockev =3D x86_init_noop; >> @@ -570,7 +566,8 @@ void __init xen_hvm_init_time_ops(void) >> } >> =20 >> xen_sched_clock_offset =3D xen_clocksource_read(); >> - pv_ops.time =3D xen_time_ops; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> + paravirt_set_sched_clock(xen_sched_clock); >> x86_init.timers.setup_percpu_clockev =3D xen_time_init; >> x86_cpuinit.setup_percpu_clockev =3D xen_hvm_setup_cpu_clockevents;= >=20 >=20 > There is a bunch of stuff that's common between the two cases so it can= be factored out. Yes. >=20 >=20 >> =20 >> diff --git a/drivers/xen/time.c b/drivers/xen/time.c >> index 108edbcbc040..152dd33bb223 100644 >> --- a/drivers/xen/time.c >> +++ b/drivers/xen/time.c >> @@ -7,6 +7,7 @@ >> #include >> #include >> #include >> +#include >> =20 >> #include >> #include >> @@ -175,7 +176,7 @@ void __init xen_time_setup_guest(void) >> xen_runstate_remote =3D !HYPERVISOR_vm_assist(VMASST_CMD_enable, >> VMASST_TYPE_runstate_update_flag); >> =20 >> - pv_ops.time.steal_clock =3D xen_steal_clock; >> + static_call_update(pv_steal_clock, xen_steal_clock); >> =20 >=20 >=20 > Do we actually need this? We've already set this up in xen_init_time_op= s(). (But maybe for ARM). Correct. Arm needs this. Juergen --------------F998C827E1466225E03A1952 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------F998C827E1466225E03A1952-- --WlyrUNrhACnKGE7g1Gx1k7ZM6h5PqkFRP-- --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmBHEk0FAwAAAAAACgkQsN6d1ii/Ey8E swf+OyODJL+GMlmaqXVphW8kb4oF9BSQVqkcEtzcS+L7SRmJ9ZuimdIeCk6WrrqzUiDE1aeFsNeK hVT12DE64j551Af0uJdt3Q/PBEDiSsvW7V87fiAg8DL8I0XqJj29wP8vBjfJPVFgDVJHIsNK2Tnm K4O/6BbctZcBqC6WwuSpss7JXmRAS0ApTaaAypMTffbSKAwJ9whX+tlcFKpqvBqKVjV2x65b7Cj2 hE/CQ/MjxQhK9Qjz7y4M62kBOGiWt3PhJInwZSpRmbf1j0Qieht6KAbJhWvwm0WGTeoOI/JCLQWd I8/SFQj2W6p8N5ijnvLD5KskevErq8ti98OafCVDpA== =2Vak -----END PGP SIGNATURE----- --71uw2iHz3Ya5XGSDna2ezasDmqthVMGA6-- --===============3671949237365185801== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3671949237365185801==--