From: Stephen Boyd <swboyd@chromium.org>
To: Will Deacon <will@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Evan Green <evgreen@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/5] memremap: Add support for read-only memory mappings
Date: Thu, 18 Jul 2019 11:00:07 -0700 [thread overview]
Message-ID: <5d30b3a8.1c69fb81.8c54.63a6@mx.google.com> (raw)
In-Reply-To: <20190710141433.7ama3gncss3y6dcx@willie-the-truck>
Quoting Will Deacon (2019-07-10 07:14:34)
> On Fri, Jun 14, 2019 at 01:37:15PM -0700, Stephen Boyd wrote:
> > @@ -84,7 +91,10 @@ void *memremap(resource_size_t offset, size_t size, unsigned long flags)
> > }
> >
> > /* Try all mapping types requested until one returns non-NULL */
> > - if (flags & MEMREMAP_WB) {
> > + if ((flags & MEMREMAP_RO) && is_ram != REGION_INTERSECTS)
> > + addr = arch_memremap_ro(offset, size);
> > +
> > + if (!addr && (flags & MEMREMAP_WB)) {
> > /*
> > * MEMREMAP_WB is special in that it can be satisfied
> > * from the direct map. Some archs depend on the
> > @@ -103,7 +113,8 @@ void *memremap(resource_size_t offset, size_t size, unsigned long flags)
> > * address mapping. Enforce that this mapping is not aliasing
> > * System RAM.
> > */
> > - if (!addr && is_ram == REGION_INTERSECTS && flags != MEMREMAP_WB) {
> > + if (!addr && is_ram == REGION_INTERSECTS &&
> > + (flags != MEMREMAP_WB || flags != MEMREMAP_RO)) {
> > WARN_ONCE(1, "memremap attempted on ram %pa size: %#lx\n",
> > &offset, (unsigned long) size);
> > return NULL;
>
> This function seems a little confused about whether 'flags' is really a
> bitmap of flags, or whether it is equal to exactly one entry in the enum.
> Given that I think it's sensible for somebody to specify 'MEMREMAP_RO |
> MEMREMAP_WT', then we probably need to start checking these things a bit
> more thoroughly so we can reject unsupported combinations at the very least.
>
I'm also confused about the same thing. I thought it was a "getting
worse via best effort" type of thing based on the comment above the
function.
* In the case of multiple flags, the different
* mapping types will be attempted in the order listed below until one of
* them succeeds.
(I now realize I should have documented the new flag so that this order
would be known. I'll resend this series again with the documentation
fix.)
I also thought that the combination of read-only and write through would
be OK because the flags are more of a best effort approach to making a
mapping. Given that, is there anything to reject? Or do we just keep
trying until we can't try anymore?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-18 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 20:37 [PATCH v2 0/5] Read-only memremap() Stephen Boyd
2019-06-14 20:37 ` [PATCH v2 1/5] reserved_mem: Add a devm_memremap_reserved_mem() API Stephen Boyd
2019-06-14 20:37 ` [PATCH v2 2/5] soc: qcom: cmd-db: Migrate to devm_memremap_reserved_mem() Stephen Boyd
2019-06-14 20:37 ` [PATCH v2 3/5] memremap: Add support for read-only memory mappings Stephen Boyd
2019-07-10 14:14 ` Will Deacon
2019-07-18 18:00 ` Stephen Boyd [this message]
2019-06-14 20:37 ` [PATCH v2 4/5] arm64: Add support for arch_memremap_ro() Stephen Boyd
2019-06-14 20:37 ` [PATCH v2 5/5] soc: qcom: cmd-db: Map with read-only mappings Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d30b3a8.1c69fb81.8c54.63a6@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).