From: "André Przywara" <andre.przywara@arm.com>
To: Amit Tomer <amittomer25@gmail.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org,
linux-kernel@vger.kernel.org, cristian.ciocaltea@gmail.com,
"Rob Herring" <robh+dt@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7
Date: Mon, 13 Jul 2020 00:17:57 +0100 [thread overview]
Message-ID: <5e2eb92e-eada-9b14-3f15-38717284bc92@arm.com> (raw)
In-Reply-To: <CABHD4K8+cZMwA=pQx4Gvv5Z4xLof8Ln6fUNrB0=-SS2M_0_3aw@mail.gmail.com>
On 12/07/2020 19:45, Amit Tomer wrote:
Hi,
> On Sun, Jul 12, 2020 at 11:00 PM Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
>>
>> On Thu, Jul 02, 2020 at 08:22:56PM +0530, Amit Singh Tomar wrote:
>>> This commit adds uSD support for Cubieboard7 board based on Actions Semi
>>> S700 SoC. SD0 is connected to uSD slot. Since there is no PMIC support
>>> added yet, fixed regulator has been used as a regulator node.
>>>
>>> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
>>> ---
>>> Changes since v4:
>>> * No change.
>>> Changes since v3:
>>> * No change.
>>> Changes since v2:
>>> * No change.
>>> Changes since v1:
>>> * No change.
>>> Changes since RFC:
>>> * No change.
>>> ---
>>> arch/arm64/boot/dts/actions/s700-cubieboard7.dts | 41 ++++++++++++++++++++++++
>>> arch/arm64/boot/dts/actions/s700.dtsi | 1 +
>>> 2 files changed, 42 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
>>> index 63e375cd9eb4..ec117eb12f3a 100644
>>> --- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
>>> +++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
>>> @@ -13,6 +13,7 @@
>>>
>>> aliases {
>>> serial3 = &uart3;
>>> + mmc0 = &mmc0;
>>> };
>>>
>>> chosen {
>>> @@ -28,6 +29,23 @@
>>> device_type = "memory";
>>> reg = <0x1 0xe0000000 0x0 0x0>;
>>> };
>>> +
>>> + /* Fixed regulator used in the absence of PMIC */
>>> + vcc_3v1: vcc-3v1 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "fixed-3.1V";
>>> + regulator-min-microvolt = <3100000>;
>>> + regulator-max-microvolt = <3100000>;
>>> + };
>>
>> Is this regulator used somewhere?
>
> This is something I copied from bubblegum dts as I wasn't sure what is right way
> to include these regulators.
But this regulator is only used for the eMMC there, which we apparently
don't have on the Cubieboard 7?
> Also, another day tested it without having these regulators in , and
> still it seems to
> work. So should these be removed ?
If there are not even referenced in the .dts, then fixed regulators are
rather pointless. So yes, please remove this vcc-3v1 one.
What is the story with the other regulator? Is there a PMIC or a power
switch for the SD card? Or is the power supply actually hardwired?
Cheers,
Andre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-12 23:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:52 [PATCH v5 00/10] Add MMC and DMA support for Actions S700 Amit Singh Tomar
2020-07-02 14:52 ` [PATCH v5 01/10] dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml Amit Singh Tomar
2020-07-02 21:00 ` Rob Herring
2020-07-03 7:18 ` Amit Tomer
2020-07-03 7:54 ` Amit Tomer
2020-07-07 14:31 ` Rob Herring
2020-07-02 14:52 ` [PATCH v5 02/10] dmaengine: Actions: get rid of bit fields from dma descriptor Amit Singh Tomar
2020-07-12 17:11 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 03/10] dmaengine: Actions: Add support for S700 DMA engine Amit Singh Tomar
2020-07-02 22:07 ` kernel test robot
2020-07-02 14:52 ` [PATCH v5 04/10] clk: actions: Add MMC clock-register reset bits Amit Singh Tomar
2020-07-12 17:20 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 05/10] arm64: dts: actions: limit address range for pinctrl node Amit Singh Tomar
2020-07-12 17:23 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 06/10] arm64: dts: actions: Add DMA Controller for S700 Amit Singh Tomar
2020-07-12 17:24 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 07/10] dt-bindings: reset: s700: Add binding constants for mmc Amit Singh Tomar
2020-07-12 17:25 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions, s700-mmc Amit Singh Tomar
2020-07-12 17:26 ` [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions,s700-mmc Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 09/10] arm64: dts: actions: Add MMC controller support for S700 Amit Singh Tomar
2020-07-12 17:28 ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7 Amit Singh Tomar
2020-07-12 17:30 ` Manivannan Sadhasivam
2020-07-12 18:45 ` Amit Tomer
2020-07-12 23:17 ` André Przywara [this message]
2020-07-13 9:03 ` Amit Tomer
2020-07-13 3:00 ` Manivannan Sadhasivam
2020-07-13 9:08 ` Amit Tomer
2020-07-17 14:40 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e2eb92e-eada-9b14-3f15-38717284bc92@arm.com \
--to=andre.przywara@arm.com \
--cc=afaerber@suse.de \
--cc=amittomer25@gmail.com \
--cc=cristian.ciocaltea@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).