From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22B85C433E0 for ; Tue, 9 Mar 2021 20:31:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1B78650E5 for ; Tue, 9 Mar 2021 20:31:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B78650E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OsNgBUtpGTqSnp1ISzDpLwiSC6AmquAUyoXauQpJ97g=; b=AP0nma/Tq9pX+co+9JnqOIMj5 37UbwJgNogvhMl68+UyezAfowW6ufaB7qnz0g4TqMl5HjPQsWTxZF+peM3AOtbXraV5PJIm4CkqYs CINa6VnV8sMn5QRCqvQtK5XjBlz92945AVE6grkW+tYcBcMHPsebDlAy5ndQptH8IO4NE+oWwLqAo Hk92q0+1GD7zQB5cj6fwmX3F+w9QPNb080K25UO/h1cCtotNawAg7zx3RfJgmdjDNX0XJjLRXwlgG BpuwdQ6bd7nuH6hUsqhoTtMAfC4YIfJ2U0qFCYVfwFozR4PpkFkgHq0PiKgumRnB/b16q+/RxzOjn Msy/8057w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJizY-005MKX-F1; Tue, 09 Mar 2021 20:30:08 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJizS-005MJQ-RU for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 20:30:05 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id D16A73FA6A; Tue, 9 Mar 2021 20:29:54 +0000 (UTC) Subject: Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs To: Arnd Bergmann , Andy Shevchenko Cc: Linus Walleij , Linux ARM , Marc Zyngier , Rob Herring , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Linux Doc Mailing List , linux-samsung-soc , Linux-Arch , "linux-kernel@vger.kernel.org" References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-11-marcan@marcan.st> From: Hector Martin Message-ID: <5eb23b42-5fda-0524-8666-0eb2c37b4ac1@marcan.st> Date: Wed, 10 Mar 2021 05:29:52 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_203003_260332_CFC27E7E X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/03/2021 00.51, Arnd Bergmann wrote: > On Fri, Mar 5, 2021 at 4:09 PM Andy Shevchenko > wrote: >> On Fri, Mar 5, 2021 at 12:25 PM Linus Walleij wrote: >>> On Thu, Mar 4, 2021 at 10:40 PM Hector Martin wrote: >>> >>>> This documents the newly introduced ioremap_np() along with all the >>>> other common ioremap() variants, and some higher-level abstractions >>>> available. >>>> >>>> Signed-off-by: Hector Martin >>> >>> I like this, I just want one change: >>> >>> Put the common ioremap() on top in all paragraphs, so the norm >>> comes before the exceptions. >>> >>> I.e. it is weird to mention ioremap_np() before mentioning ioremap(). >> >> +1 here. That is what I have stumbled upon reading carefully. > > In that case, the order should probably be: > > ioremap > ioremap_wc > ioremap_wt > ioremap_np > ioremap_uc > ioremap_cache > > Going from most common to least common, rather than going from > strongest to weakest. Yeah, I was dwelling on the issue of ioremap_np being first when I wrote that... this alternative works for me, I'll sort it like this then. It'll just need some re-wording to make it all flow properly. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel