From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6265BC433B4 for ; Thu, 20 May 2021 15:08:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE30860C3D for ; Thu, 20 May 2021 15:08:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE30860C3D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KlapCbau/DB02q6e5WeLoguIP/zpz3NrkhFjt5AsDgU=; b=UtCsSr7RJFjlwj/gENF+mOmYoN vjf+ODDrKi2fk1vhvLnpXYO1nXFc9hqyUWGy8ocRF+Urof1hp4sLXNjjoClahwS+DsP6LwlWBnXce GXp0r+zQo5rEz/LdsLjEgu6RdMaD26/W49w7pSAJXa/XFi3siMEuYpIQe9Z/xNa6Ozd4yDWElikoM bs4gNcuQNf8PpibzF+u2bxMh4x5VmXMPNK2lL/FlybZ6TNWtwHGg087a9C0izHLLpc/IOqdrGzMSN AC9xiKrFzeFYmsXXgdgVc6N+n2Z+/17ge3LZFiIMiBVrwot7hNk7co3AxVz2dfv67jVJqaUf0Ee2g nqms0rbA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljkFY-001agp-RU; Thu, 20 May 2021 15:06:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljkFW-001afQ-Qq for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 15:06:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=WoDym5778WJBr1Q2ebYva3SKwMdAQzYHzSkY1l8qHzQ=; b=O3T6BgfSDniqpjjOIyO6bVADwi z4BK5BkeU5Jxbpv9BQxPETntev7kjtp3JxjKZP0/JhqN/1QqzI8g1MSlJA1w/UB6tk+3jYJhBv4Ac YspA6i9cICHlUUJfERCrag0EMhVZaX+nBN8kvZWAeev4bixUXzS6YqiUvl/9suQY1NRb1S2ZbmRsE xlBTlebRl6LuttsacnYGnMT0pPS9n8xjXCoAXiUqkmrBxm+BR0IDqZpjypBv9BJwt/ECntvZbolxD h6uOdfJ61YHi5bZDVNgPGtgtFaF4f/JZUedwkFFxxzFvXyR9twFZOsxsEJ/AtKKQOyjmB68loAh4F 6Zglodcw==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljkFT-00GRpn-O1 for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 15:06:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B333D11B3; Thu, 20 May 2021 08:05:54 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F08993F73B; Thu, 20 May 2021 08:05:51 -0700 (PDT) Subject: Re: [PATCH v12 4/8] arm64: kvm: Introduce MTE VM feature To: Catalin Marinas Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Haibo Xu , Andrew Jones References: <20210517123239.8025-1-steven.price@arm.com> <20210517123239.8025-5-steven.price@arm.com> <20210520115426.GB12251@arm.com> From: Steven Price Message-ID: <5f0996d6-0a6e-ebcd-afcd-8290faba6780@arm.com> Date: Thu, 20 May 2021 16:05:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210520115426.GB12251@arm.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_080607_909370_A15213E8 X-CRM114-Status: GOOD ( 29.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/05/2021 12:54, Catalin Marinas wrote: > On Mon, May 17, 2021 at 01:32:35PM +0100, Steven Price wrote: >> diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c >> index c5d1f3c87dbd..8660f6a03f51 100644 >> --- a/arch/arm64/kvm/mmu.c >> +++ b/arch/arm64/kvm/mmu.c >> @@ -822,6 +822,31 @@ transparent_hugepage_adjust(struct kvm_memory_slot *memslot, >> return PAGE_SIZE; >> } >> >> +static int sanitise_mte_tags(struct kvm *kvm, unsigned long size, >> + kvm_pfn_t pfn) >> +{ >> + if (kvm_has_mte(kvm)) { >> + /* >> + * The page will be mapped in stage 2 as Normal Cacheable, so >> + * the VM will be able to see the page's tags and therefore >> + * they must be initialised first. If PG_mte_tagged is set, >> + * tags have already been initialised. >> + */ >> + unsigned long i, nr_pages = size >> PAGE_SHIFT; >> + struct page *page = pfn_to_online_page(pfn); >> + >> + if (!page) >> + return -EFAULT; > > IIRC we ended up with pfn_to_online_page() to reject ZONE_DEVICE pages > that may be mapped into a guest and we have no idea whether they support > MTE. It may be worth adding a comment, otherwise, as Marc said, the page > wouldn't disappear. I'll add a comment. >> + >> + for (i = 0; i < nr_pages; i++, page++) { >> + if (!test_and_set_bit(PG_mte_tagged, &page->flags)) >> + mte_clear_page_tags(page_address(page)); > > We started the page->flags thread and ended up fixing it for the host > set_pte_at() as per the first patch: > > https://lore.kernel.org/r/c3293d47-a5f2-ea4a-6730-f5cae26d8a7e@arm.com > > Now, can we have a race between the stage 2 kvm_set_spte_gfn() and a > stage 1 set_pte_at()? Only the latter takes a lock. Or between two > kvm_set_spte_gfn() in different VMs? I think in the above thread we > concluded that there's only a problem if the page is shared between > multiple VMMs (MAP_SHARED). How realistic is this and what's the > workaround? > > Either way, I think it's worth adding a comment here on the race on > page->flags as it looks strange that here it's just a test_and_set_bit() > while set_pte_at() uses a spinlock. > Very good point! I should have thought about that. I think splitting the test_and_set_bit() in two (as with the cache flush) is sufficient. While there technically still is a race which could lead to user space tags being clobbered: a) It's very odd for a VMM to be doing an mprotect() after the fact to add PROT_MTE, or to be sharing the memory with another process which sets PROT_MTE. b) The window for the race is incredibly small and the VMM (generally) needs to be robust against the guest changing tags anyway. But I'll add a comment here as well: /* * There is a potential race between sanitising the * flags here and user space using mprotect() to add * PROT_MTE to access the tags, however by splitting * the test/set the only risk is user space tags * being overwritten by the mte_clear_page_tags() call. */ Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel