From: <Claudiu.Beznea@microchip.com>
To: <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <linux@armlinux.org.uk>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <rjw@rjwysocki.net>,
<pavel@ucw.cz>, <len.brown@intel.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 0/3] add support for power off check in suspend
Date: Mon, 28 Jan 2019 09:50:23 +0000 [thread overview]
Message-ID: <5f0cf9d1-9a6a-4c97-8f56-6c5ae8af1564@microchip.com> (raw)
In-Reply-To: <1546944944-13911-1-git-send-email-claudiu.beznea@microchip.com>
Hi Pavel, Rafael,
Do you have some other hints I could follow in order to solve the
scenario I tried to cover with these patches, if these are not
a proper fit for the current code?
Thank you,
Claudiu Beznea
On 08.01.2019 12:56, Claudiu Beznea - M18063 wrote:
> From: Claudiu Beznea <claudiu.beznea@microchip.com>
>
> Hi,
>
> AT91 platforms support a power saving mode where SoC's power is cut off (we call
> it backup mode). The resume is done with the help of bootloaders. To be able to
> suspend/resume Linux to/from this mode all the drivers suspend/resume callbacks
> should save/restore the content of all the active registers. We have 2 problems
> we are trying to solve:
> - some of these drivers are shared with other non Microchip SoCs (e.g. macb
> driver) and we don't want to disturbe other users of corresponding IPs with
> all the register save/restore operations;
> - the suspend/resume time for the rest of the power saving mode we are using
> could be improved if we would know in drivers the suspend mode the platform
> is switched to.
>
> A solution that would have been solve our problems was proposed in [1] but in
> the end it wasn't accepted. It ended up with the introduction of
> pm_suspend_target_state variable that could be used along with the changes in
> this series.
>
> While the discussion of [1] progressed it has been proposed (in [2]) to
> implement a function that would tell if the platform's power would be cut off
> at the end of the suspend procedure.
>
> The patches in this series does as follows:
> 1/3 - add a new member to platform_suspend_ops that will tell if platform's
> power will be cut off at the end of the suspend procedure; drivers could
> use it via platform_off_in_suspend()
> 2/3 - add a new function to regulator's core that could be used to check if a
> proper regulator has been configured (via DT) to be powered off in
> suspend. This is used on this series to check the CPU's regulator is
> properly configured in DT to be turned off in suspend.
> 3/3 - fill .off_in_suspend member of at91_pm_ops; the functionality in patch 2/3
> is used to double check CPU's regulator would be turned off in suspend.
>
> Thank you,
> Claudiu Beznea
>
> [1] https://lkml.org/lkml/2017/6/22/938
> [2] https://lkml.org/lkml/2017/7/16/457
>
> Changes in v2:
> - remove !! instruction in regulator_is_disabled_in_suspend() and
> at91_pm_state_allowed()
> - s/weather/wether in patch 1/1
>
> Claudiu Beznea (3):
> PM / Suspend: Add support to check if platform's power is off in
> suspend
> regulator: core: add helper to check if regulator is disabled in
> suspend
> ARM: at91: pm: add support for .off_in_suspend
>
> arch/arm/mach-at91/pm.c | 61 +++++++++++++++++++++++++++++++++++---
> drivers/regulator/core.c | 17 +++++++++++
> include/linux/regulator/consumer.h | 7 +++++
> include/linux/suspend.h | 6 ++++
> kernel/power/suspend.c | 13 ++++++++
> 5 files changed, 100 insertions(+), 4 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-01-28 9:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 10:56 [PATCH v2 0/3] add support for power off check in suspend Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 1/3] PM / Suspend: Add support to check if platform's power is off " Claudiu.Beznea
2019-01-09 14:14 ` Pavel Machek
2019-01-10 10:24 ` Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 2/3] regulator: core: add helper to check if regulator is disabled " Claudiu.Beznea
2019-01-09 16:57 ` Mark Brown
2019-01-10 10:24 ` Claudiu.Beznea
2019-01-11 12:39 ` Mark Brown
2019-01-11 14:08 ` Claudiu.Beznea
2019-01-14 22:53 ` Mark Brown
2019-01-15 9:19 ` Claudiu.Beznea
2019-01-08 10:56 ` [PATCH v2 3/3] ARM: at91: pm: add support for .off_in_suspend Claudiu.Beznea
2019-01-08 11:46 ` [PATCH v2 0/3] add support for power off check in suspend Rafael J. Wysocki
2019-01-08 14:07 ` Claudiu.Beznea
2019-01-28 9:50 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f0cf9d1-9a6a-4c97-8f56-6c5ae8af1564@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).