From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS
Date: Mon, 28 Jul 2014 13:02:47 +0200 [thread overview]
Message-ID: <6028388.mjACYPxFta@wuerfel> (raw)
In-Reply-To: <78788908-DDB5-46F8-83C1-FAE312D7BFB2@perenite.com>
On Monday 28 July 2014 12:50:47 Benoit Masson wrote:
> >
> > It should still list both "marvell,mv78230-i2c" and "marvell,mv64xxx-i2c",
> > as the generic name may not be enough to describe the register layout
> > correctly.
>
> I tend to disagree since the dts include the armada-xp.dtsi, which already declare
>
> "i2c0: i2c at 11000 {
> compatible = "marvell,mv78230-i2c", "marvell,mv64xxx-i2c";
> reg = <0x11000 0x100>;
> };
> "
>
> I tested the dts on the device and it does inherits the i2c declaration, did I miss something here ?
>
Inheriting from armada-xp.dtsi is fine, but if you manually set
"marvell,mv64xxx-i2c", that will override the old setting
and drop the "marvell,mv78230-i2c" part, which is bad because
it may break things later if it turns out that the mv78230
variant is not completely compatible with the old
mv64xxx variant.
Arnd
next prev parent reply other threads:[~2014-07-28 11:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-26 23:47 [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-27 1:52 ` Andrew Lunn
2014-07-28 8:49 ` Arnd Bergmann
2014-07-28 10:50 ` Benoit Masson
2014-07-28 11:02 ` Arnd Bergmann [this message]
2014-07-28 11:17 ` Benoit Masson
2014-07-28 11:37 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 22:52 Benoit Masson
2014-07-23 23:27 ` Jason Cooper
2014-07-23 23:29 ` Andrew Lunn
2014-07-23 23:42 ` Jason Cooper
2014-07-24 12:11 ` Jason Cooper
2014-07-24 4:00 ` Baruch Siach
2014-07-26 17:26 ` Andrew Lunn
2014-07-26 23:55 ` Benoit Masson
2014-07-23 22:35 [PATCH 1/2] Adding Lenovo - Lenovo Group Ltd. to the vendor-prefixes list Benoit Masson
2014-07-23 22:35 ` [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-23 22:42 ` Andrew Lunn
2014-07-23 22:56 ` Benoit Masson
2014-07-23 22:58 ` Andrew Lunn
[not found] ` <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com>
2014-07-23 23:15 ` Jason Cooper
2014-07-24 12:21 ` Gregory CLEMENT
2014-07-24 12:45 ` Jason Cooper
2014-07-24 13:29 ` Andrew Lunn
[not found] ` <C2E7C8C1-1198-4785-AB9C-C27B5E27A8D4@perenite.com>
2014-07-24 14:07 ` Jason Cooper
2014-07-24 14:29 ` Andrew Lunn
2014-07-24 14:56 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6028388.mjACYPxFta@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).