From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57DA1C6FD1F for ; Thu, 16 Mar 2023 11:37:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hu0ovGlbjmr57Wgw6GVJFA3DvQgqKtZmGDwspPpHelQ=; b=Pp3WYdFsxfZimE 7VLMCfsQu/BHvLvjNbe7J2JOcif9XF2XWxS4+WPbgK51PsVQLrHKKtsRMAgqofzyTBbMxvBFykt9U N2w4LYCc39klOiws2yOczDLqWsmn+klyz/K4JK3xovyDfcxNwjWletRFkokVlGg87lt4rcJy0lJzw es+clslVO+olD+c0iB03u/IjkwazldPoLPaIJts/Hw4B5p0Coq8wYM5RuL/LzaiBxlELBOFevwP3T gCSurEQhWc42p7vRK/2m04yFuFdeYKyFRtPK+BrmxJ344MN02a6hyGFPjj9EumVd641RgSm9/NbLp gdw28OtDIuoNR+fkLz+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcluj-00GG5b-2F; Thu, 16 Mar 2023 11:36:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pclug-00GG4H-2B for linux-arm-kernel@lists.infradead.org; Thu, 16 Mar 2023 11:36:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3623C61FED; Thu, 16 Mar 2023 11:36:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01E91C433EF; Thu, 16 Mar 2023 11:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678966613; bh=O9HMPyWgeiI0jJRwpx01XQshSoPMJEGZDfmKLwzW+UI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZGcLDh0kp6YPPYl7JeOcz+d7GmBqXMYfTc8DIRfh4TnMDR0KR2VbAIXuPPhh0PsQC 7+9unTxXk+9S1TZ6uCkIV3kmtvaxajNlU7mhDLYPFarETP068RjpmUfWmZ0sR6YCib fKJ8bG3/kvegAZAr3jEWawIuQlHgx8NI7wJ2omNRsno4pNblUXoTr+MaXejUqt8WO4 P/vMUl+YA+W3kvi4C1oxC1tOLvGe580mE3Q5FxU6pRqCywsxSeIAMzaC122BVWram4 cjwQ6se4WJ1r5CzsdXrfMCGK/PU3Xk9JrbFbSHhZjQV7N+6ZNHGUOaCOa/Zd3JJnul LvL3cXAQLN8fA== Message-ID: <60e73395-f670-6eaa-0eb7-389553320a71@kernel.org> Date: Thu, 16 Mar 2023 13:36:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [EXTERNAL] Re: [PATCH v4 4/5] soc: ti: pruss: Add helper functions to set GPI mode, MII_RT_event and XFR Content-Language: en-US To: Md Danish Anwar , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230313111127.1229187-1-danishanwar@ti.com> <20230313111127.1229187-5-danishanwar@ti.com> From: Roger Quadros In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_043654_790498_089DB9A3 X-CRM114-Status: GOOD ( 31.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 16/03/2023 13:05, Md Danish Anwar wrote: > Hi Roger, > > On 15/03/23 17:52, Roger Quadros wrote: >> >> >> On 13/03/2023 13:11, MD Danish Anwar wrote: >>> From: Suman Anna >>> >>> The PRUSS CFG module is represented as a syscon node and is currently >>> managed by the PRUSS platform driver. Add easy accessor functions to set >>> GPI mode, MII_RT event enable/disable and XFR (XIN XOUT) enable/disable >>> to enable the PRUSS Ethernet usecase. These functions reuse the generic >>> pruss_cfg_update() API function. >>> >>> Signed-off-by: Suman Anna >>> Co-developed-by: Grzegorz Jaszczyk >>> Signed-off-by: Grzegorz Jaszczyk >>> Signed-off-by: Puranjay Mohan >>> Signed-off-by: MD Danish Anwar >>> --- >>> drivers/soc/ti/pruss.c | 60 ++++++++++++++++++++++++++++++++ >>> include/linux/remoteproc/pruss.h | 22 ++++++++++++ >>> 2 files changed, 82 insertions(+) >>> >>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>> index 26d8129b515c..2f04b7922ddb 100644 >>> --- a/drivers/soc/ti/pruss.c >>> +++ b/drivers/soc/ti/pruss.c >>> @@ -203,6 +203,66 @@ static int pruss_cfg_update(struct pruss *pruss, unsigned int reg, >>> return regmap_update_bits(pruss->cfg_regmap, reg, mask, val); >>> } >>> >>> +/** >>> + * pruss_cfg_gpimode() - set the GPI mode of the PRU >>> + * @pruss: the pruss instance handle >>> + * @pru_id: id of the PRU core within the PRUSS >>> + * @mode: GPI mode to set >>> + * >>> + * Sets the GPI mode for a given PRU by programming the >>> + * corresponding PRUSS_CFG_GPCFGx register >>> + * >>> + * Return: 0 on success, or an error code otherwise >>> + */ >>> +int pruss_cfg_gpimode(struct pruss *pruss, enum pruss_pru_id pru_id, >>> + enum pruss_gpi_mode mode) >>> +{ >>> + if (pru_id < 0 || pru_id >= PRUSS_NUM_PRUS) >>> + return -EINVAL; >>> + >>> + if (mode < 0 || mode > PRUSS_GPI_MODE_MAX) >>> + return -EINVAL; >>> + >>> + return pruss_cfg_update(pruss, PRUSS_CFG_GPCFG(pru_id), >>> + PRUSS_GPCFG_PRU_GPI_MODE_MASK, >>> + mode << PRUSS_GPCFG_PRU_GPI_MODE_SHIFT); >>> +} >>> +EXPORT_SYMBOL_GPL(pruss_cfg_gpimode); >>> + >>> +/** >>> + * pruss_cfg_miirt_enable() - Enable/disable MII RT Events >>> + * @pruss: the pruss instance >>> + * @enable: enable/disable >>> + * >>> + * Enable/disable the MII RT Events for the PRUSS. >>> + * >>> + * Return: 0 on success, or an error code otherwise >>> + */ >>> +int pruss_cfg_miirt_enable(struct pruss *pruss, bool enable) >>> +{ >>> + u32 set = enable ? PRUSS_MII_RT_EVENT_EN : 0; >>> + >>> + return pruss_cfg_update(pruss, PRUSS_CFG_MII_RT, >>> + PRUSS_MII_RT_EVENT_EN, set); >>> +} >>> +EXPORT_SYMBOL_GPL(pruss_cfg_miirt_enable); >>> + >>> +/** >>> + * pruss_cfg_xfr_enable() - Enable/disable XIN XOUT shift functionality >>> + * @pruss: the pruss instance >>> + * @enable: enable/disable >>> + * @mask: Mask for PRU / RTU >> >> You should not expect the user to provide the mask but only >> the core type e.g. >> >> enum pru_type { >> PRU_TYPE_PRU = 0, >> PRU_TYPE_RTU, >> PRU_TYPE_TX_PRU, >> PRU_TYPE_MAX, >> }; >> >> Then you figure out the mask in the function. >> Also check for invalid pru_type and return error if so. >> > > Sure Roger, I will create a enum and take it as parameter in API. Based on > these enum I will calculate mask and do XFR shifting inside the API > pruss_cfg_xfr_enable(). > > There are two registers for XFR shift. > > #define PRUSS_SPP_XFER_SHIFT_EN BIT(1) > #define PRUSS_SPP_RTU_XFR_SHIFT_EN BIT(3) > > For PRU XFR shifting, the mask should be PRUSS_SPP_XFER_SHIFT_EN, > for RTU shifting mask should be PRUSS_SPP_RTU_XFR_SHIFT_EN and for PRU and RTU > shifting mask should be (PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN) > > So the enum would be something like this. > > /** > * enum xfr_shift_type - XFR shift type > * @XFR_SHIFT_PRU: Enables XFR shift for PRU > * @XFR_SHIFT_RTU: Enables XFR shift for RTU > * @XFR_SHIFT_PRU_RTU: Enables XFR shift for both PRU and RTU This is not required. User can call the API twice. once for PRU and once for RTU. > * @XFR_SHIFT_MAX: Total number of XFR shift types available. > * > */ > > enum xfr_shift_type { > XFR_SHIFT_PRU = 0, > XFR_SHIFT_RTU, > XFR_SHIFT_PRU_RTU, > XFR_SHIFT_MAX, > }; Why do you need this new enum definition? We already have pru_type defined somewhere. You can move it to a public header if not there yet. enum pru_type { PRU_TYPE_PRU = 0, PRU_TYPE_RTU, PRU_TYPE_TX_PRU, PRU_TYPE_MAX, }; > > In pruss_cfg_xfr_enable() API, I will use switch case, and for first three > enums, I will calculate the mask. > > If input is anything other than first three, I will retun -EINVAL. This will > serve as check for valid xfr_shift_type. > > The API will look like this. > > int pruss_cfg_xfr_enable(struct pruss *pruss, enum xfr_shift_type xfr_type, > bool enable); > { > u32 mask; > > switch (xfr_type) { > case XFR_SHIFT_PRU: > mask = PRUSS_SPP_XFER_SHIFT_EN; > break; > case XFR_SHIFT_RTU: > mask = PRUSS_SPP_RTU_XFR_SHIFT_EN; > break; > case XFR_SHIFT_PRU_RTU: > mask = PRUSS_SPP_XFER_SHIFT_EN | PRUSS_SPP_RTU_XFR_SHIFT_EN; > break; > default: > return -EINVAL; > } > > u32 set = enable ? mask : 0; > > return pruss_cfg_update(pruss, PRUSS_CFG_SPP, mask, set); > } > > This entire change I will keep as part of this patch only. > > Please let me know if this looks OK to you. > > cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel