From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B4EDC00140 for ; Fri, 5 Aug 2022 09:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WmruDp/yhPyqmZlRyid4Xdx6b2F9iq7nGBZyL0EMHhk=; b=qfDEciDG9NoVDU JeGF8ZX9E0GtpBGJCmrTj1SAOluXbwokInOa/7kNWJWryHn9vepFdJxakesFMrQQTKx8mhQTOcry8 g9FBXrr1vd/C3latxlZreV60Nvb/tINewyQAgCfH2mce0Z8SEUlTxb+Ngq7c2Vc2+P/tBjzniM+Is aTST4kg6q+EB7oHuM7bhQCA6KJXCgFbf4Id1M2rQd9vvwIvFjuRVkrNLiHgGZZQwESfQC1GTfZzO7 S6an0aQGXIoGhCelPA5rYq4c/xFkAK4NxjQe+kYDcWNf5wvjfY5VAIfGMeSaO7EdOK0C3N06h3Ot3 ct1gzUXA6iTxsLY9X1fQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJtS3-00DVwW-7d; Fri, 05 Aug 2022 09:17:03 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oJtRz-00DVqM-7X for linux-arm-kernel@lists.infradead.org; Fri, 05 Aug 2022 09:17:00 +0000 Received: by mail-lj1-x229.google.com with SMTP id bx38so2389513ljb.10 for ; Fri, 05 Aug 2022 02:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=NebOAZsDNUYEnk0zw74zqxdgooxqZ6OXU/cl7Qnopgo=; b=PwNdSdJ9vLfHwmC0vxJWGJatV/Psnd2QO3ZilR/uHik+SIXqZRdrG3ojXbOFCIhAKL g6Gq8ezk4foZnteWBwbEK4FFPv2qQPPJQliP0QJKmR+PazzsoPcZSmqFoE6tPpGiMO9J pBxQJhRyhWK9Ft4KaNykKPISKOLtxvqRqE70dDSyK8Y5es2Ecd+p3jjN/c/Fubqx31ri Z4Iy/PalR3/ESly9azFb202102tTADh9V4Ti0sZVR0Btg9v8POhWf5iqJL0gNt8vOSmG niRiCeHTB67wmLY/sU6V8nNo06AHisCyKwOeiIFMjAwCMBcedceIe+jg3siREVk43kfa /ptw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NebOAZsDNUYEnk0zw74zqxdgooxqZ6OXU/cl7Qnopgo=; b=l2GFxRh+EDrvtiW1u64fz+ezQ+nsgOLYaC9eSQSkkF12XibJ6OZaGAix4odMrG5swl Aczaj3iENOpIHxwpOHElxy5ATMaAvb24tT0A+9dfctTLjyyiejK8H9Rr7KUFo+RrXCIe VxCD4tsIDf0ATliFmAGcL/Uz9G5eMB4mXP1u+bSN6teAbAE01+Qz8MVh9x6OE4hp9djd T4Usshh7/zC0v7YiMERNRp4gBxwFqM6YbwzZzOBLdfj7mwv7x02EwZXwD/qUwayJu81v jD9Z9Cgr9YI4M+tcwxYrgdvVl4vRo0T8OUogG2RuHYSp7p6SmaSspOfr2XTFN5pCiE81 gIRQ== X-Gm-Message-State: ACgBeo32ilFTR7IbOgaekN279IlT4XhgtM2YFCikGvsxUkdnpLLgTT9w WyO5L5ZqTE47G4C+Eg3oGPmYVQ== X-Google-Smtp-Source: AA6agR4yVEvRwgIhQrQa6MU6+RgXf6u+bO9zwQ0E+tfgpNd2ldoDmEgjNO26h8O36iiLY01NSXJOmQ== X-Received: by 2002:a2e:84ca:0:b0:25d:77e0:2566 with SMTP id q10-20020a2e84ca000000b0025d77e02566mr1905585ljh.78.1659691011885; Fri, 05 Aug 2022 02:16:51 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id c29-20020a05651200dd00b0048af749c060sm403940lfp.157.2022.08.05.02.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 02:16:41 -0700 (PDT) Message-ID: <60f30470-ca14-1e12-3ed2-7b34c7a93f8a@linaro.org> Date: Fri, 5 Aug 2022 11:16:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 5/6] arm64: dts: meson: add S4 Soc Peripheral clock controller in DT Content-Language: en-US To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Jerome Brunet , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-6-yu.tu@amlogic.com> From: Krzysztof Kozlowski In-Reply-To: <20220805085716.5635-6-yu.tu@amlogic.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220805_021659_297902_B73599F1 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/08/2022 10:57, Yu Tu wrote: > Added information about the S4 SOC Peripheral Clock controller in DT. > > Signed-off-by: Yu Tu > --- > arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 26 +++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > index a816b1f7694b..71be1dda15a2 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi > @@ -6,6 +6,8 @@ > #include > #include > #include > +#include > +#include > > / { > cpus { > @@ -100,6 +102,30 @@ clkc_pll: pll-clock-controller@8000 { > #clock-cells = <1>; > }; > > + clkc_periphs: periphs-clock-controller { Node names should be generic, so "clock-controller" https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation You miss here unit address. Test your DTS with dtbs check and with regular compile with W=1. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel