From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B61C433E5 for ; Thu, 23 Jul 2020 11:46:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F6C72080D for ; Thu, 23 Jul 2020 11:46:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VvOPOeCK"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=toradex.com header.i=@toradex.com header.b="a44izKW2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F6C72080D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=toradex.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LplmCAfPIrQT/HX4HsNMxnsjtShyIaft7prHVjafNuA=; b=VvOPOeCK9tfM9GxJF+9xX3g8q kEu/TWGvuZnXcDAcYo3Wp7wpz0saxdSkt5TjUfayvdpor9SxWmy68S9djfxTh27Eq0P37nts244ZC pLbeB3mkMqDmnCN7Zrv1aSO7wdz5dcP1zj1VA8NN8ujlfNzs7u5yFbNT3E6W7D5kOuMaR/xDK4Yf1 CGJ6PzmdS6by1EKosnTUY3UlNcmo3r9pgsKP8e95jji/HZ9r4uCEI+nSJJBIF3KxnB0mQWj6ovilw vhbaIYdbbDWR9hNbo/tJzREuHTdNJogafRTj+eWEcYwm6EG45YZcQU8uMwnFo1KQADNmNjwU6zq64 N/MCkTTBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyZek-0004ed-8B; Thu, 23 Jul 2020 11:44:58 +0000 Received: from mail-eopbgr80133.outbound.protection.outlook.com ([40.107.8.133] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyZeh-0004c5-3p for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 11:44:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=icH4b3C5rj7Go2xg4hCcpGV2Chb2b8SB7ps+PKYr+HooCA4Hd0soLFWS4OjgapG8IS39bobHXkobW3jBdId8G6UeSmujweR/QrwY+uOZk+Ncm0PSpBgHT90lwNGrMC17BWeV4qrcpURtsBSNkjcjSkk54ug1NZusuYRsmV0dJsihS63Yq3d1Z/htDExmVR+G4/aa7LE1E5b4aDNxgP0eOJlMGSHU7R99IJI/RlmapScjq1dmdwD3vD1mHhaLEYn5wTUqP2MbYPKhtL2LrsLmD1BX1qMs1/tJKPmdyg6SOY0vkdhxFNAMnsRQhArfkPhErl4/COg6XtPtu6slB1VsWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCG4A1yu9zXJqiS4xCtkQsKV+5um3ivb8EpssX5+Igc=; b=MdAvACuUUQUjDB6uJkJGIFs+vf7759qchynphrlqEVmwaqsrcko5lwFlPmQjTz2D0FhND4xGbALsKInnXWGLNpzAKEZ0faPD+tO+84e8d+gLlSuFjLDpSZ+f8u3ocFqqYWL19ACPsXHWEP3Uvsv/rY1vk1cmPgUSpc1GfhSXtRSZ4FVjRdUj1z7NkoN+mGikD6JoJgkWbM0igHi5MXtngWNfc2pWzrvQ1uTH2cvjoC63uLSutpAqPxp5G45OSAF2DeerPXVGe9Pn+k3gN8AZsyGNoqaAlXPwMxlTUNibnZUy4OnzlgRkOs1S5a7IFZRVW8qZUQYw0DtbhPu11dshFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=toradex.com; dmarc=pass action=none header.from=toradex.com; dkim=pass header.d=toradex.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toradex.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fCG4A1yu9zXJqiS4xCtkQsKV+5um3ivb8EpssX5+Igc=; b=a44izKW2ma6DXCZlThgCaiiVQ33WrD9qLOxF9Vj+GNtDVNDbDn/LzLKDr9pfSBiw6Si15JWoZQ6izYokPua899EW7M+YXSYU3cxCfuMRzfo2HxHnBOvcYTMCQEvzpmEq34aHc0WiOUWK3H/0kXF8GbTX1IXqIM6PuRlrmYy9bjs= Received: from AM6PR05MB6120.eurprd05.prod.outlook.com (2603:10a6:20b:a8::25) by AM6PR05MB5411.eurprd05.prod.outlook.com (2603:10a6:20b:36::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.23; Thu, 23 Jul 2020 11:44:49 +0000 Received: from AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d]) by AM6PR05MB6120.eurprd05.prod.outlook.com ([fe80::1d81:6a9b:8c26:3b7d%4]) with mapi id 15.20.3216.020; Thu, 23 Jul 2020 11:44:49 +0000 From: Philippe Schenker To: "shawnguo@kernel.org" Subject: Re: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Topic: [PATCH 3/3] ARM: dts: colibri-imx7: add usb dual-role switch capability Thread-Index: AQHWVr15sZvxLwnO3E+b+KcqajdLWakFR14AgAAjuQCAAU+xgIAABwcAgAkG2gCAAFsvgIAE/AIA Date: Thu, 23 Jul 2020 11:44:48 +0000 Message-ID: <60f571d4ba50bb3377d0c2b7f2dfcfc31fad578a.camel@toradex.com> References: <20200710132423.497230-1-philippe.schenker@toradex.com> <20200710132423.497230-3-philippe.schenker@toradex.com> <73240ab0-5069-40c5-4ade-7fcc2207dfaf@pengutronix.de> <7e6f8135-120f-0831-20ad-25648ea646b8@pengutronix.de> <83b230cef109e1a413ab1036c21ad763a1d127eb.camel@toradex.com> <20200720021125.GC11560@dragon> <5616f6e189845de7c4acfd9eede540ef6e6e9eb0.camel@toradex.com> In-Reply-To: <5616f6e189845de7c4acfd9eede540ef6e6e9eb0.camel@toradex.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.4 authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=toradex.com; x-originating-ip: [31.10.206.124] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: edef8900-d217-41ba-df79-08d82efdce5b x-ms-traffictypediagnostic: AM6PR05MB5411: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Stg5DnKdzQT2ayTLIZu19jY14AjzicdlKnC226hvL8Ve3eKNVs5z5U1eYmGSxpfoFW97F9xuHmzbqPqNabScMFmtuMDvc6Gsunl6lBnOXMxGmdHJoqMkqpaftHC58QVKVFyImXAcPnaQUzxJJ9uUKI+qyBJn9fs7EEcwJuzZuxbfY9SGlqe0heMJQPeDOba5Hi9KwI/XbrKL2ZmosBSV3bcENp+tdIlqOsTXwRKs+seUNj+6wCGVoKTLEpSI3YhD2I452oF5N/LMfjAw4qVpalrJudmd12AxE6a4slbGNFhjPChEaeFGqngETOKL3B+tMdZKxFwzz9bO+Isto5RaFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR05MB6120.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(376002)(396003)(346002)(6486002)(2616005)(44832011)(6916009)(36756003)(71200400001)(64756008)(66556008)(66946007)(66476007)(91956017)(5660300002)(76116006)(66446008)(54906003)(6512007)(2906002)(316002)(7416002)(86362001)(8936002)(8676002)(26005)(186003)(6506007)(53546011)(478600001)(4326008)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: O9x7M/wsIATqlopJAWAEBG68Q73cyXO+A1fnHJj3TwEyV5VHKDSgcmPJEIy6p/kg7XR/ojDFU3ksfY9iCm4JXTneTrwjjbOqGwo9k7/7cskrXeDvbI+aKq5YlfdWwG9NnumHJvmoQudNCUlEZ/VPLNSRaMN7HiFiv1VMMDNrkGvcYrIqFXuUYrqhsLkSyQMxWi1b+kuqPRfnzje61w+0Kijry7ENkVkVy0Dni+Ve849N7rEUwI82PHx8SQ4mBIG3vhvXL9Pa/bmH5Dk77xYi8w4Tdf8k3qFoT4w/ATH5VbQ6hDelXvi3ugRDGkZQyKYTZAGskQ642a9tcSB4vvbkJ/lLBEBRkAnQK83YIGBLOZBnUxamwhZlxON2nKG2dE1J0v/YmwSclnzQqjYDgi9MQOHx3LYAjwn7StarMHvTd8a6XQdWTfbKMwKyf0lEUh3n4mc8cuB+hE1YvTtETQ45KyGciyCahuBQ06M5uJqBsHA= x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM6PR05MB6120.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: edef8900-d217-41ba-df79-08d82efdce5b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2020 11:44:49.5826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d9995866-0d9b-4251-8315-093f062abab4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lf3g2+UdzYDlHOZqwBWakRz8wkOvts3EbGpnijXln9s/JrwFYqnhKWyFH7+xHOSi3LhEbxcucO66BBiC6UYnzU0ZmzUaF/fB2Ml1O4fF9Io= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5411 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_074455_374426_717D54F7 X-CRM114-Status: GOOD ( 32.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "a.fatoum@pengutronix.de" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-imx@nxp.com" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-07-20 at 09:37 +0200, Philippe Schenker wrote: > On Mon, 2020-07-20 at 10:11 +0800, Shawn Guo wrote: > > On Tue, Jul 14, 2020 at 08:20:34AM +0000, Philippe Schenker wrote: > > > On Tue, 2020-07-14 at 09:55 +0200, Ahmad Fatoum wrote: > > > > Hello Philippe, > > > > > > > > On 7/13/20 1:53 PM, Philippe Schenker wrote: > > > > > On Mon, 2020-07-13 at 11:46 +0200, Ahmad Fatoum wrote: > > > > > > Hello Philippe, > > > > > > > > > > > > > + extcon_usbc_det: usbc_det { > > > > > > > + compatible = "linux,extcon-usb-gpio"; > > > > > > > > > > > > According to 4602f3bff266 ("usb: common: add USB GPIO based > > > > > > connection > > > > > > detection driver"): > > > > > > "the old way using extcon to support USB Dual-Role switch is > > > > > > now > > > > > > deprecated > > > > > > when use Type-B connector." > > > > > > > > > > > > Have you considered using a compatible = "gpio-usb-b- > > > > > > connector" > > > > > > child > > > > > > node instead? > > > > > > > > > > > > Cheers, > > > > > > Ahmad > > > > > > > > > > Thanks for the Hint Ahmad, > > > > > > > > > > I already tried and just now tried again but it doesn't work > > > > > on > > > > > our > > > > > hardware. Are you sure this works with chipidea driver? > > > > > > > > I haven't, just wanted to point its existence out in case you > > > > didn't > > > > know. > > > > Seems we need to call of_platform_populate somewhere in the > > > > driver. > > > > Unsure what other changes are necessary. > > > > > > Yep, thanks for that! It seems like that need to be really called > > > as > > > I > > > can't get a probe of the new usb connector driver. I quickly > > > grepped > > > through code and saw that tegra USB driver is calling > > > of_platform_populate and they also use that gpio-usb-b-connector. > > > > > > > > Should this new usb-connector stuff work in general with every > > > > > old > > > > > driver? > > > > > > > > If the driver support isn't there yet, I think use of extcon is > > > > fine > > > > as is. > > > > Shouldn't we improve chipidea driver to get it work with gpio-usb-b- > > connector? > > I know this would be nice but I don't know that code well enough to be > able to make this changes in a timely manner. And I rather like to > have > support for USB dual-role support "the old way" now than never (we > actually tried this for along time on our Colibri boards). > > I discovered a bug in that driver together with Peter Chen, which got > now solved by him and I would like to use the host/device switching on > colibri-imx6/7 boards now. Hi Shawn, Could you let me know how I should proceed with these patches? Thanks, Philippe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel