From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Cc: <linux-aspeed@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ARM: soc: aspeed: Add secure boot controller support
Date: Wed, 9 Mar 2022 16:59:20 +0100 [thread overview]
Message-ID: <618a4361-ca04-81e4-99af-f7d9a3a0b7d6@kaod.org> (raw)
In-Reply-To: <92c2301f-5759-c13c-84f6-52ec69af7de6@kaod.org>
[ ... ]
>> + sbe.abr_image = !!(security_status & ABR_IMAGE_SOURCE);
>> + sbe.low_security_key = !!(security_status & LOW_SEC_KEY);
>> + sbe.otp_protected = !!(security_status & OTP_PROTECTED);
>> + sbe.secure_boot = !!(security_status & SECURE_BOOT);
>> + /* Invert the bit, as 1 is boot from SPI/eMMC */
>> + sbe.uart_boot = !(security_status & UART_BOOT);
>> +
>> + debugfs_root = debugfs_create_dir("aspeed", NULL);
>
> may be use 'arch_debugfs_dir' or is that the same ? and test the returned
> value as it can fail.
Also, CONFIG_DEBUG_FS is not always selected.
Thanks,
C.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-09 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 3:03 [PATCH] ARM: soc: aspeed: Add secure boot controller support Joel Stanley
2022-03-07 1:06 ` Andrew Jeffery
2022-03-09 15:53 ` Cédric Le Goater
2022-03-09 15:59 ` Cédric Le Goater [this message]
2022-03-09 22:40 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618a4361-ca04-81e4-99af-f7d9a3a0b7d6@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).