From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF88C4727D for ; Mon, 5 Oct 2020 13:01:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65A23207BC for ; Mon, 5 Oct 2020 13:01:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xYZ0eigX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ItECm5qN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A23207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FczbyZvIg4e28mZ2vCtMTr69vu1J4WYLNdi+mwCpKUc=; b=xYZ0eigXvigAH9pOxGvgfu314 sHgChmo2j1XhWnTVLbyRqm3gd2MfWSbL/n0Vj1SHPPQx8ThgEeyjKGOf44gyAkDG4kNLES21e9TP1 BeLOBmNmqPAUCZeWLEgExkF/1/FIGu/fEUwo8Bhl2vugU5hGfwLAHETBfw4675HTLbHWvn00r8TeT jLrmHgx8Dgtxd0BbQ8VTF+rKTfEAp2ZQgpUJhiWGytCs1orzl4GMnuWeC9LNn4Z/ASEio+tcjmGEv HaDFIHgQR1hqBLvurzcpO/bmlnjX5TTJqJkotTrG8VuYvEZjb6Ig7HyLRh5JdwKD+Qg/tZv/9ZGV0 alYfgYQ3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPQ5t-0005jz-SY; Mon, 05 Oct 2020 12:59:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPQ5r-0005jS-3i for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 12:59:56 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE5BD20756; Mon, 5 Oct 2020 12:59:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601902794; bh=f3Gi+VtWFwk+VdDk4hz/N+rcjPMKX4KsgkpEvF8IBVk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ItECm5qNh+RNP4lNCHN5fPVoZukbPJmat7pqlbKaPj2S/ywNV00VC4SH30LHec9sS oZyuChr+Kx0YvbxbMS0i2IDlctS6hfb+5Tu2rjVP5Jk7KDKZ3x/GCgzDGrVGOeCa1S QM2h2l6j1K3XP4AhI81dLcuGcASouYuTGthCy73s= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kPQ5o-00HN64-2i; Mon, 05 Oct 2020 13:59:52 +0100 MIME-Version: 1.0 Date: Mon, 05 Oct 2020 13:59:52 +0100 From: Marc Zyngier To: Thierry Reding Subject: Re: [PATCH 2/3] soc/tegra: pmc: Allow optional irq parent callbacks In-Reply-To: <20201005112755.GS425362@ulmo> References: <20201005111443.1390096-1-maz@kernel.org> <20201005111443.1390096-3-maz@kernel.org> <20201005112755.GS425362@ulmo> User-Agent: Roundcube Webmail/1.4.8 Message-ID: <62586cc041b513240fba252f0b256e30@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: thierry.reding@gmail.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com, digetx@gmail.com, skomatineni@nvidia.com, vreddytalla@nvidia.com, tglx@linutronix.de, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_085955_218080_30AC2352 X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Venkat Reddy Talla , linux-kernel@vger.kernel.org, Jonathan Hunter , Sowjanya Komatineni , linux-tegra@vger.kernel.org, Dmitry Osipenko , kernel-team@android.com, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-05 12:27, Thierry Reding wrote: > On Mon, Oct 05, 2020 at 12:14:42PM +0100, Marc Zyngier wrote: >> Make the PMC driver resistent to variable depth interrupt hierarchy, >> which we are about to introduce. The irq_chip structure is now >> allocated statically, providing the indirection for the couple of >> callbacks that are SoC-specific. >> >> Signed-off-by: Marc Zyngier >> --- >> drivers/soc/tegra/pmc.c | 65 >> ++++++++++++++++++++++++++++++++++------- >> 1 file changed, 54 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c >> index d332e5d9abac..9960f7c18431 100644 >> --- a/drivers/soc/tegra/pmc.c >> +++ b/drivers/soc/tegra/pmc.c >> @@ -439,7 +439,6 @@ struct tegra_pmc { >> struct pinctrl_dev *pctl_dev; >> >> struct irq_domain *domain; >> - struct irq_chip irq; > > Did you have any particular reason for pulling this out of the struct > tegra_pmc and making it a global variable? The main reason is that it really isn't per-PMC. You can do everything with a single one that is used even if you have multiple PMCs of different types (not sure that's possible with the current HW, but still). M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel