From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A1CC43331 for ; Mon, 11 Nov 2019 14:16:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BE8E21925 for ; Mon, 11 Nov 2019 14:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGHDwJ/k"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dcidApTO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BE8E21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=38nbJrFG1Ud7Px5jZXIa9a2DnF1NjbtGGS5mRd/tr9g=; b=rGHDwJ/kx+oQ+/q/Ysst0cYGu uaQty1AtTHtr+VAAXYf5eXoXP4TKrm7kofG5gIP7K3pxkZ3L2gfqDdBxRUrDYGBeeZ6cA87XS+Ee6 iZaSh+J50OXOlEL8mJ1kSV/nS/F/QGGVCISwFTAcvL+4hg17TiXb0eGTTiiCYfmWOTH4exxC4xu+r +CvuefFXVpWvF/5KCZo0Z6UPwluHets+YkN+EmovZ8yfFJuf8PSAl89yJVkG7yhTrEC7LvVIjE3pl Zdkj/x7t/ZIeZTnre+SXMk5Cq4ooG4UGpeZ0DCvxN92Bzb0Ifq+c6/aDqj24/ytheGyDF87BNNvLA wueKAKe5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUAUG-0006c5-1l; Mon, 11 Nov 2019 14:16:12 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUAUD-0006bk-Ex for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 14:16:10 +0000 Received: by mail-pf1-x441.google.com with SMTP id 193so10753529pfc.13 for ; Mon, 11 Nov 2019 06:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=febfKlWJi5gGxYdmeWZw4Fi5Cx8ThIzR9wUIWuDizCE=; b=dcidApTOUPNVuSFDYFLRSDVmUaujchonwjxB3OPh3A8fUBSMjJ1VijN6wTxjziztJ3 mMfB+A9a6kbau0dpDL15pcCI4gsrXB3ITA0mQ+ZxnFb/ql20jhYY1ZjqWVhp40kaQz1o 8H+YWXud1Pd6HQhbT4SSOQ59OQr6M6n7rRbikjvv632blP/8RGM70rCTdDkAkRz7JV7k oJ3LCt9MvQRCX3Ut75e0mjcdhtthxh1zH9G9yPxpFLLLtLPi+rkRWwqKnQmvV/fhXquy +mvPG8CnJL7MNS40XwnttmrXtPzkbUwiSwsP3IZtdFZ6ni2BfmvE42ABruSG65PYhbh6 VgWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=febfKlWJi5gGxYdmeWZw4Fi5Cx8ThIzR9wUIWuDizCE=; b=rLG9WbmILnmWqt4SzA+V39ElsNznxS/74b6SvwwaKmdOii5cHUpl0gTbses7vfr9Db s14VpRc7mEZu30r4lyMFYMmc3bwehpgtt6ZJrqd7Cy9UVBy/zMOHymRJYghWrr4sWP9B 6gjhIp3i7SydWdNFl/VmcSuKKpBquRXSOIVrKuTbbxwcdhlmAFryeKBan221pqaruuIj jhtiPV7Nr3Rv43Oy46wqERn1YafO+83DcBDD3ivVMapYmWC8cR4+QVaX9HqHuK3j1gQ+ BDysx6YzvyJnsDY5rNRVtK2m1woIQDFdERXpYbcIHzrHiDy5dvwwWrd9bBGOSHha96tG uhdw== X-Gm-Message-State: APjAAAU9xPPQmSODJf2YiIquSo7hRZgcIn1db1J/vHgD0FBy6YGIPdLU NxkB2/walOr34MnUMQb0pr0= X-Google-Smtp-Source: APXvYqwKi/pjpY+1q9oCaxglZOH6Jtmslpke/PA4yi6SHCxe0djIH9S8SnYfqxtXvP4AihM0ZUNDpg== X-Received: by 2002:a17:90a:9741:: with SMTP id i1mr35005987pjw.41.1573481768634; Mon, 11 Nov 2019 06:16:08 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id u8sm3700134pga.47.2019.11.11.06.16.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Nov 2019 06:16:07 -0800 (PST) Subject: Re: [PATCH -next] fsi: aspeed: Use devm_kfree in aspeed_master_release() To: YueHaibing , jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrew@aj.id.au References: <20191109033209.45244-1-yuehaibing@huawei.com> From: Guenter Roeck Message-ID: <62eacd00-300c-bc3e-b680-605bd0b7a983@roeck-us.net> Date: Mon, 11 Nov 2019 06:16:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191109033209.45244-1-yuehaibing@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_061609_528296_4241E8E9 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, alistair@popple.id.au, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-fsi@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/8/19 7:32 PM, YueHaibing wrote: > 'aspeed' is allocted by devm_kfree(), it should not be > freed bt kfree(). > > Fixes: 1edac1269c02 ("fsi: Add ast2600 master driver") > Signed-off-by: YueHaibing > --- > drivers/fsi/fsi-master-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c > index 3dd82dd..0f63eec 100644 > --- a/drivers/fsi/fsi-master-aspeed.c > +++ b/drivers/fsi/fsi-master-aspeed.c > @@ -361,7 +361,7 @@ static void aspeed_master_release(struct device *dev) > struct fsi_master_aspeed *aspeed = > to_fsi_master_aspeed(dev_to_fsi_master(dev)); > > - kfree(aspeed); > + devm_kfree(dev, aspeed); > } > > /* mmode encoders */ > The memory is attached to the device, and will thus be freed once the device is released. Why is the release function needed in the first place ? Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel