From: "Heiko Stübner" <heiko@sntech.de>
To: Alex Bee <knaerzche@gmail.com>, wens@kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add sdmmc_ext for RK3328
Date: Wed, 23 Jun 2021 15:40:30 +0200 [thread overview]
Message-ID: <6327455.haC6HkEk0m@diego> (raw)
In-Reply-To: <CAGb2v67K-BRhQ_a1yXtdPCX8T30FJPLojueJ2cvpXmGUskOLjA@mail.gmail.com>
Am Mittwoch, 23. Juni 2021, 15:11:12 CEST schrieb Chen-Yu Tsai:
> On Wed, Jun 23, 2021 at 8:00 PM Alex Bee <knaerzche@gmail.com> wrote:
> >
> > RK3328 SoC has a fourth mmc controller called SDMMC_EXT. Some
> > boards have sdio wifi connected to it. In order to use it
> > one would have to add the pinctrls from sdmmc0ext group which
> > is done on board level.
> >
> > While at that also add the reset controls for the other mmc
> > controllers.
>
> I recommend splitting this part into a separate patch, and
> adding an appropriate "Fixes" tag to it.
I'm with you on that. Adding the resets to the existing controllers
should be a separate patch.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-23 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 12:00 [PATCH] arm64: dts: rockchip: Add sdmmc_ext for RK3328 Alex Bee
2021-06-23 12:53 ` Johan Jonker
2021-06-23 13:53 ` Alex Bee
2021-06-23 13:11 ` Chen-Yu Tsai
2021-06-23 13:40 ` Heiko Stübner [this message]
2021-06-23 13:52 ` Alex Bee
2021-06-23 14:59 ` [PATCH v2] " Alex Bee
2021-06-23 15:02 ` [PATCH] arm64: dts: rockchip: Add sdmmc/sdio/emmc reset controls " Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6327455.haC6HkEk0m@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=knaerzche@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).