From: "Xu, Yanfei" <yanfei.xu@windriver.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: rppt@kernel.org, ardb@kernel.org, linus.walleij@linaro.org,
akpm@linux-foundation.org, carver4lio@163.com,
tiantao6@hisilicon.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform
Date: Wed, 19 May 2021 12:39:16 +0800 [thread overview]
Message-ID: <63618f13-07cf-6867-bcb1-7a725e6f3ef4@windriver.com> (raw)
In-Reply-To: <20210518120633.GW12395@shell.armlinux.org.uk>
On 5/18/21 8:06 PM, Russell King (Oracle) wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> On Tue, May 18, 2021 at 12:29:32PM +0100, Russell King (Oracle) wrote:
>> On Tue, May 18, 2021 at 07:12:54PM +0800, Yanfei Xu wrote:
>>> The value of "vmalloc=" set in cmdline is always 8M more than the value
>>> of "VmallocTotal" in meminfo. When use the "vmalloc=" parameter, user
>>> expect to get the size what they input, and no need to consider the 8M
>>> "hole" hided in codes. This commit make real vmalloc size equal to value
>>> of "vmalloc=" in cmdline.
>>>
>>> Also, the commit will reduce the size of vmalloc printed in boot message
>>> by 8M when the size set in cmdline is irrational.
>>
>> Hi,
>>
>> I think I'd like to do several cleanups with this:
>>
>> 1. change vmalloc_min to be an unsigned long.
>> 2. exclude VMALLOC_OFFSET from vmalloc_min, moving it into
>> adjust_lowmem_bounds where vmalloc_min is used.
>> 3. rename vmalloc_min to be vmalloc_start
>> 4. enforce vmalloc_start to be a multiple of 2MiB
>> 5. in early_vmalloc(), calculate vmalloc_max as:
>> VMALLOC_END - (PAGE_OFFSET + SZ_32M + VMALLOC_OFFSET)
>> and use that to set the upper bound of vmalloc_reserve (which is
>> something your patch doesn't do, which I think is a bug.
>>
>> Thoughts?
>
> I've slightly modified the above idea, and will shortly follow up with
> some patches to show the idea a bit better...
>
Thanks for making it better!
Regards,
Yanfei
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-19 4:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:12 [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Yanfei Xu
2021-05-18 11:29 ` Russell King (Oracle)
2021-05-18 12:06 ` Russell King (Oracle)
2021-05-18 12:15 ` [PATCH 1/4] ARM: change vmalloc_min to be unsigned long Russell King (Oracle)
2021-05-18 22:09 ` Linus Walleij
2021-05-18 12:15 ` [PATCH 2/4] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle)
2021-05-18 22:11 ` Linus Walleij
2021-05-18 12:15 ` [PATCH 3/4] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle)
2021-05-18 22:19 ` Linus Walleij
2021-05-18 22:26 ` Nicolas Pitre
2021-05-18 22:32 ` Nicolas Pitre
2021-05-18 22:34 ` Linus Walleij
2021-05-18 22:38 ` Nicolas Pitre
2021-05-28 9:55 ` Russell King (Oracle)
2021-05-19 4:41 ` Xu, Yanfei
2021-05-20 9:00 ` Russell King (Oracle)
2021-05-28 2:52 ` Xu, Yanfei
2021-05-28 10:00 ` Russell King (Oracle)
2021-05-19 5:25 ` Xu, Yanfei
2021-05-18 12:15 ` [PATCH 4/4] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle)
2021-05-18 22:21 ` Linus Walleij
2021-05-19 4:39 ` Xu, Yanfei [this message]
2021-05-19 5:32 ` [PATCH] arm: make the size of vmalloc in cmdline and meminfo uniform Xu, Yanfei
2021-05-20 4:52 ` Alexander Dahl
2021-05-20 6:50 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 1/6] ARM: change vmalloc_min to be unsigned long Russell King (Oracle)
2021-05-28 13:10 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 2/6] ARM: use a temporary variable to hold maximum vmalloc size Russell King (Oracle)
2021-05-28 13:11 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 3/6] ARM: change vmalloc_min to vmalloc_start Russell King (Oracle)
2021-05-28 12:21 ` Linus Walleij
2021-05-28 13:05 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 4/6] ARM: change vmalloc_start to vmalloc_size Russell King (Oracle)
2021-05-28 12:22 ` Linus Walleij
2021-05-28 13:15 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 5/6] ARM: use "* SZ_1M" rather than "<< 20" Russell King (Oracle)
2021-05-28 12:23 ` Linus Walleij
2021-05-28 13:17 ` Xu, Yanfei
2021-05-28 10:11 ` [PATCH v2 6/6] ARM: use MiB for vmalloc sizes Russell King (Oracle)
2021-05-28 12:24 ` Linus Walleij
2021-05-28 13:20 ` Xu, Yanfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63618f13-07cf-6867-bcb1-7a725e6f3ef4@windriver.com \
--to=yanfei.xu@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=carver4lio@163.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rppt@kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).