From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BUG6152_INVALID_DATE_TZ_ABSURD,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID, INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD00ECA9EB5 for ; Mon, 4 Nov 2019 13:32:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8023D20B7C for ; Mon, 4 Nov 2019 13:32:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LCIePH3V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8023D20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BnDXFvT9/7/czfNpYoOzyUISgYlo+YtLuhSdLcNW24I=; b=LCIePH3VhWkmCOeeHv40+TSFr UbVBHBTyqle84fiE5U90pXCGg4GKukgCFOq9IRJfaGNhMmreEEmDEzv/7TCZg1bQUIV93meA0MkT3 HqOzAWIaO/X40wHeDZo0+eImVXPiR3Jz3N58Z9ekg5wzY/XEB9nhwfk+71126uPhsvkzEIkCJmwE9 tJuo1soXxoLO807P/mypNOlc+OJ/bg0eTDgvFwhePBrVXI6rX9JHZySEU/OwxCdSXv8Z8oDT/Fu/A +ZSZufwiW8r4smwWeU9pfPQa1ybvgpVDgf8VmwCzUDA0mF2cZU++RaQDTLKjoWIuwHu8eTwD7++1l BEj46Fdwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRcSp-0000xe-7f; Mon, 04 Nov 2019 13:32:11 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRcRO-000803-GR for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 13:30:44 +0000 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1iRcQv-0005Lj-UU; Mon, 04 Nov 2019 14:30:13 +0100 To: Sami Tolvanen Subject: Re: [PATCH v4 03/17] arm64: kvm: stop treating register x18 as caller save X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Date: Mon, 04 Nov 2019 14:39:34 +0109 From: Marc Zyngier In-Reply-To: <79e8f958cbde52a3d90aec24dd4638d9@www.loen.fr> References: <20191018161033.261971-1-samitolvanen@google.com> <20191101221150.116536-1-samitolvanen@google.com> <20191101221150.116536-4-samitolvanen@google.com> <79e8f958cbde52a3d90aec24dd4638d9@www.loen.fr> Message-ID: <63921b46250e2eb8eb9fcf0f8ec93b0c@www.loen.fr> X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: samitolvanen@google.com, will@kernel.org, catalin.marinas@arm.com, rostedt@goodmis.org, mhiramat@kernel.org, ard.biesheuvel@linaro.org, dave.martin@arm.com, keescook@chromium.org, labbott@redhat.com, mark.rutland@arm.com, ndesaulniers@google.com, jannh@google.com, miguel.ojeda.sandonis@gmail.com, yamada.masahiro@socionext.com, clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_053042_750520_22D867A7 X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Masahiro Yamada , Catalin Marinas , Jann Horn , Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Miguel Ojeda , Masami Hiramatsu , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-11-04 12:13, Marc Zyngier wrote: > Hi Sami, > > On 2019-11-01 23:20, Sami Tolvanen wrote: >> From: Ard Biesheuvel >> >> In preparation of reserving x18, stop treating it as caller save in >> the KVM guest entry/exit code. Currently, the code assumes there is >> no need to preserve it for the host, given that it would have been >> assumed clobbered anyway by the function call to __guest_enter(). >> Instead, preserve its value and restore it upon return. >> >> Link: https://patchwork.kernel.org/patch/9836891/ >> Signed-off-by: Ard Biesheuvel >> [Sami: updated commit message, switched from x18 to x29 for the >> guest >> context] >> Signed-off-by: Sami Tolvanen >> Reviewed-by: Kees Cook > > If you intend for this to be merged via the arm64 tree, please add my > > Reviewed-by: Marc Zyngier Erm... Muscle memory strikes again. Please ignore the above and use the following instead: Reviewed-by: Marc Zyngier Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel