From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3151C0650F for ; Sun, 11 Aug 2019 20:16:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B072F2085A for ; Sun, 11 Aug 2019 20:16:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="grgoz5cU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="UXBPE7/X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B072F2085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QNoeW2A+gf16RxBtbl7YYpGzjtWoJXx91oLR3OwZ70o=; b=grgoz5cUiuyGLo MdmKtYWnUJUl3Oa0XTb8GYqOCncy1HsS/+la0kmvmQ+kwiuS8whnTJZnOxj5JpCHrjqRozYBo7qEv 3DnRVRcQvLcdV2+t+hDd4coVSIj4pD+xnqR9zFSXaFKdTKKuOGDS3+/uytn2/m2eRyHxPHefT3VhW ag0yan0O8R0Bjkfq41oo1kYw7T1QS8gDdBM/gVlP8zg0iCj+03M7irNai5XwNQNeBlIG92kYxzWIA K3c7nZYKF4Pg3vkLNJvMxzR1O8Qc+pGsr4gNuHJS0eDuzTXnlAl2kmn9rMCK9s8g+Iy7w6gldEPOy VixI3N2ycD4TrNgNAiNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hwuGi-0006T9-DP; Sun, 11 Aug 2019 20:16:44 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hwuGf-0006SM-2l; Sun, 11 Aug 2019 20:16:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1565554561; bh=3kJZz9MtM4IycBB5++CRUMsdjM9afoO5ssqFTHYDTFQ=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=UXBPE7/XqrRAQJosZXZlLVWzbY5+iktGlenikxjP6d5kbG4LtIcceRGDmeMtsxHpj H91t3tHpP0BzF3oK6z6COXMM3nrLqnauC3sQmJ4UFf7dn/QUQf1MY9AnLb5Dn88Dzl b3fH517p75+i7L3gys2iMMkikbENQjP8KDSi/ER4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.162] ([37.4.249.106]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2mFi-1iQdvp1KVY-0136ib; Sun, 11 Aug 2019 22:16:01 +0200 Subject: Re: [PATCH 12/18] pinctrl: bcm2835: Add support for BCM2711 pull-up functionality To: Linus Walleij References: <1563776607-8368-1-git-send-email-wahrenst@gmx.net> <1563776607-8368-3-git-send-email-wahrenst@gmx.net> From: Stefan Wahren Message-ID: <63f17284-5551-9492-9eff-f8a4c003196b@gmx.net> Date: Sun, 11 Aug 2019 22:15:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:kZQhLC+37knN7koeRxivgD7Ex21z780f90KQ0PFrFGVPzmYdpRh LkUk2Pvie/qP/eKtJHdAn0Caz9G36mzXlHyrIVRYq8Ge873TNFqbKIcSHpQeYNpqOGmP5+o AwOi8ZCa07SigQsn1tEt2xUIn/XE8eST/8GMGtikC18Hp4TPpdNtE6Y4qoPbgiv0aRo+YDw dG7y6LYdG5wb9t52Qagig== X-UI-Out-Filterresults: notjunk:1;V03:K0:oAouFmHG4m8=:kyRzVeiVXqBUjn6tANbtBm RuOaSaOUzu9sEKFtiH/qSW6h6diBq0jYWh/0zCvnj1LaY1KttoLdpLDoDaG4VYlafhj8/dBrJ F1VI1gmaUgPNJ+sLuWEWhsgwvoUF7qj1a9cLQhq3b9Y2/MGi38fw/2LM9QS2Hcue7eLgCeGyW h1pDyo1nixPO5dGvEYgaNjVG+zt7fQUmyUj5pdwRPTi9fHMWVgJxwtZPNZrndvdWnCJfhKmeK LxirIOPw9oxXGdeHvPYZObW7ohWj5Fro4FNDWYAzgvJV2oUpqOaFod5Hza7QEJwBO4Y2xEUPj JUOftzV7PfrD2Y20E96dJ2MKVKvy9fs1Lx93QPbJZMoUtE91necmAHJ0QJa+E24+1lHd583cv VuGqY2Hqc3HG6FI6mD/De/jfHB0kXK8WfGxSFd34uvSiZ22l7suHyVf+FTALmdl0eeqoyRxoj W/h1ICQKbFOcxcIcp1QCP6S2q6avv3eAWvn4kMeVHFqKB8rIbvxtT+6BWckPNFbFvuDO2VHdo HSQJvVVLnLK8in7WFbbpKFKnAQHKUnIa5Q0iWvjYNy3ZbXZer/XUFhmvkxy7wME05OdJuZ7Oh SL6b3icqj22YlqbIe/kaQsblJp/nzY/8eYaKDEJY22r3pIrbnFtIxAu82tF4A2GqwxlH0v1NC ziI3pQUMxx64UyddKzyWc2p4uEfIebO3v3AKsTDf3UCpa8yJo1wcF7/jcr4DsMjGzmWGo1SY4 M5aJoYCIk/9Ui4i27CNnMyE0bTv+RpfhEEMM5KKnv+N6LHnmXQeDahHu8cT9a2auXttljYxjT r/iWX7uWUzgs4+hUZOXJ8IyLu0KozkdfR4/pptaPnURjCUyUrm00SFSvsEcKDW2mhw3SsvxbU KGhfRqZz1hG8NN3oAy4ShETA9ra3Whz0q1O+Fo6GHlfTcOm0myviYPu6Nc5SBQdJENdf2QZp0 NctdCQApVfVv4vzU4xY/zmMSuYmPuSxoURhthic+3SLGpLzBUwx0XY2//aPOg+OHeY54MQqmE DlMJ7LsTFTqCT8oc445kRnUDEafPv6rO57Xx1QLG3/aVgBtEjmliRaj+DBBnyXVIAM6eSdt12 itKCyfJrMGCKyE8z2JCDcPemUylk3P+dETNN8GrDiawSw2loqti61ctVc797hLioo3gWU+1hi bIpDg= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190811_131641_422098_896FCD44 X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Matthias Brugger , Scott Branden , "open list:GPIO SUBSYSTEM" , Stephen Boyd , Ray Jui , Michael Turquette , linux-mmc , Adrian Hunter , Rob Herring , Eric Anholt , Florian Fainelli , bcm-kernel-feedback-list , Linux ARM , Nicolas Saenz Julienne , linux-rpi-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 05.08.19 um 11:38 schrieb Linus Walleij: > On Mon, Jul 22, 2019 at 8:24 AM Stefan Wahren wrote: > >> The BCM2711 has a new way of selecting the pull-up/pull-down setting >> for a GPIO pin. The registers used for the BCM2835, GP_PUD and >> GP_PUDCLKn0, are no longer connected. A new set of registers, >> GP_GPIO_PUP_PDN_CNTRL_REGx must be used. This commit will add >> a new compatible string "brcm,bcm2711-gpio" and the kernel >> driver will use it to select which method is used to select >> pull-up/pull-down. >> >> This patch based on a patch by Al Cooper which was intended for the >> BCM7211. This is a bugfixed and improved version. >> >> Signed-off-by: Stefan Wahren > Patch applied. Thanks > > I think I complained about some other version of this patch, this one > looks entirely acceptable. > > Can we get rid of custom pull settings etc from the upstream device > trees so we don't set bad examples? I have a strong urge to > throw in a pr_warn() about any use of it. Ironically, my pre-RFC version tried to convert all BCM2835 pinmux settings to generic ones. Unfortunately it seems that i made a mistake, because it didn't work as expected. Since we stumpled above more and more other issues (not relevant to pinctrl) during upstream review, i decided to start with legacy pull-up support, so we can fix this later in the devicetree for both platforms (currently BCM2711 uses most of the old BCM2835 pinmuxes including the legacy stuff). So yes my plan is to fix this soon. Stefan > > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel