From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Appana Durga Kedareswara Rao <appanad@xilinx.com>,
Anssi Hannula <anssi.hannula@bitwise.fi>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
Michal Simek <michals@xilinx.com>,
"wg@grandegger.com" <wg@grandegger.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/6] net: can: xilinx_can: Fix flags field initialization for axi can and canps
Date: Wed, 9 Oct 2019 09:17:49 +0200 [thread overview]
Message-ID: <644fb76f-8169-4911-2293-92ae2dfe4e1c@pengutronix.de> (raw)
In-Reply-To: <MN2PR02MB64004059908C95EB5E16746FDC950@MN2PR02MB6400.namprd02.prod.outlook.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2387 bytes --]
On 10/9/19 6:01 AM, Appana Durga Kedareswara Rao wrote:
> Hi,
>
> <Snip>
>> On 18.3.2019 13.32, Appana Durga Kedareswara rao wrote:
>>> AXI CAN IP and CANPS IP supports tx fifo empty feature, this patch
>>> updates the flags field for the same.
>>>
>>> Signed-off-by: Appana Durga Kedareswara rao
>>> <appana.durga.rao@xilinx.com>
>>> ---
>>> drivers/net/can/xilinx_can.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/net/can/xilinx_can.c
>>> b/drivers/net/can/xilinx_can.c index 2de51ac..22569ef 100644
>>> --- a/drivers/net/can/xilinx_can.c
>>> +++ b/drivers/net/can/xilinx_can.c
>>> @@ -1428,6 +1428,7 @@ static const struct dev_pm_ops xcan_dev_pm_ops
>> =
>>> { };
>>>
>>> static const struct xcan_devtype_data xcan_zynq_data = {
>>> + .flags = XCAN_FLAG_TXFEMP,
>>> .bittiming_const = &xcan_bittiming_const,
>>> .btr_ts2_shift = XCAN_BTR_TS2_SHIFT,
>>> .btr_sjw_shift = XCAN_BTR_SJW_SHIFT,
>>
>> Thanks for catching this, this line seemed to have been incorrectly removed by
>> my 9e5f1b273e ("can: xilinx_can: add support for Xilinx CAN FD core").
>>
>> But:
>>
>>> @@ -1435,6 +1436,7 @@ static const struct xcan_devtype_data
>>> xcan_zynq_data = { };
>>>
>>> static const struct xcan_devtype_data xcan_axi_data = {
>>> + .flags = XCAN_FLAG_TXFEMP,
>>> .bittiming_const = &xcan_bittiming_const,
>>> .btr_ts2_shift = XCAN_BTR_TS2_SHIFT,
>>> .btr_sjw_shift = XCAN_BTR_SJW_SHIFT,
>>
>>
>> Are you sure this is right?
>> In the documentation [1] there does not seem to be any TXFEMP interrupt, it
>> would be interrupt bit 14 but AXI CAN 5.0 seems to only go up to 11.
>>
>> Or maybe it is undocumented or there is a newer version somewhere?
>
> Sorry for the delay in the reply.
> Agree TXFEMP interrupt feature is not supported by the Soft IP CAN.
> Since this patch already got applied will send a separate patch to fix this.
Please base your patch on net/master and add the appropriate fixes tag:
Fixes: 3281b380ec9f ("can: xilinx_can: Fix flags field initialization for axi can and canps")
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-09 7:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 11:32 [PATCH 0/6] net: can: xilinx_can: Bug fixes and Enhancements Appana Durga Kedareswara rao
2019-03-18 11:32 ` [PATCH 1/6] net: can: xilinx_can: Fix style issues Appana Durga Kedareswara rao
2019-03-18 11:32 ` [PATCH 2/6] net: can: xilinx_can: Fix flags field initialization for axi can and canps Appana Durga Kedareswara rao
2019-10-04 14:32 ` Anssi Hannula
2019-10-09 4:01 ` Appana Durga Kedareswara Rao
2019-10-09 7:17 ` Marc Kleine-Budde [this message]
2019-10-09 7:31 ` Appana Durga Kedareswara Rao
2019-03-18 11:32 ` [PATCH 3/6] net: can: xilinx_can: Add cantype parameter in xcan_devtype_data struct Appana Durga Kedareswara rao
2019-03-18 11:32 ` [PATCH 4/6] net: can: xilinx_can: Add support for CANFD FD frames Appana Durga Kedareswara rao
2019-03-18 11:32 ` [PATCH 5/6] net: can: xilinx_can: Add SPDX license Appana Durga Kedareswara rao
2019-03-18 11:32 ` [PATCH 6/6] net: can: xilinx_can: Fix kernel doc warnings Appana Durga Kedareswara rao
2019-03-20 13:08 ` [PATCH 0/6] net: can: xilinx_can: Bug fixes and Enhancements Marc Kleine-Budde
2019-03-21 6:36 ` Appana Durga Kedareswara Rao
2019-04-23 6:38 ` Appana Durga Kedareswara Rao
2019-06-07 6:58 ` Appana Durga Kedareswara Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644fb76f-8169-4911-2293-92ae2dfe4e1c@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=anssi.hannula@bitwise.fi \
--cc=appanad@xilinx.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).