From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D93F9C00140 for ; Tue, 2 Aug 2022 08:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jPTfEb550SjK+haqg4qh8JUJYplGMiMpsSTbHxLH4Ug=; b=4kEG/aaxD8xV72 JS7/PC/2Ep5cgGA6anEmTMSmTLdQH5tP5NfootCB31O9WKfB8wB7OiBowmSXZPPQoKfi/4rdguFow 9cwBfgAl/sYbAxuwPP9JCksEDtUPiBQg8wGAYrUH6Z6Bl3l+b9yEDGp/VPlOOz2GlK/G5hfsxMqkK GXYLh3lDS5Bln5WrEuhNMabiyB0hAjNKtNTxOV5rQeQADDQ3a+3wGEdRmB02aOXIrgXJn0va+IOL4 CfCFZ2NoBlPtqu8CkRU7qafpG1yrbxFr2e1AVmhEDByq+Fy8oAjudHQ+LNhWR5+Mw+9/Qd/b16xKu miOd5zFaWLVsfGIJBPog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInLi-00BsAt-W2; Tue, 02 Aug 2022 08:33:59 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInLe-00Bs84-HT for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 08:33:56 +0000 Received: by mail-lf1-x12b.google.com with SMTP id bq11so15820612lfb.5 for ; Tue, 02 Aug 2022 01:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1ozmbsN2tgjXvPMdLMQFGo2ZV9fcaQMnF+02jQaScWo=; b=xiDFHToAk53VqqiejooYK/XgNB5mKuNz8WRx/QqME+8fOqnbf+fM8Vxd7FAAatCyJx hvU1TGDiOfHaUWhFP2YZApPg5ShXnWIAsahH5o+ul7zbNBW7rWJVihGhwjvE6teAvwdK wLsAJiemDPc68V7aQLFnMwgFh6kH3OyAVRyhk7UG5hqJ3fqzttbWyFfDezbMEdIxHz2X Hqo45gVcyArFQi+RpBv2sk8UlVcnIeNqwwgRqJDTw17K1rhw2xyHkrolTK0jzqqtk/Zc Cqz4bsnwSgM2QmwYMTVCaYGsJhGX1Gbiaz9dgELpIduIQq3AoBVrcYurKvBIRnTKBz+9 v/eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1ozmbsN2tgjXvPMdLMQFGo2ZV9fcaQMnF+02jQaScWo=; b=STLiyt9IAg6GLuP9etiPqYRVrSw7z6z7BVaTCdkFJW3geSE4emcuOuQzjfq6YahBGW TlACmoEfVBS9nGburQtZX539+ZeL5GRfzDggZdx5MPaXeRxEd/cvcD+GffEaRX/xWfxx pQUWTJBL+Psek+dVoJ1xVK54yW9a4/BfKEk2ot+h/FlZsPNVdGEAPOLO/4oydrUoNzoL 9Aoz5wMdlRaBqDZ5+ZNOiphFfQKLA505gCE128NpkqkquGZ150Fa3AYoGwB7uw0B0Mtz OtPxRT7GswO1K69uRaOEG67LhvpiCLBeTC3xukNfpbx7PsuDC59S/Hfl6eor+2YuswGS 2NQg== X-Gm-Message-State: AJIora+sv5e1racfgdk0+JrUEUcKPzJ9hni8v+S0FV6l5o3sivwsds3x h+DCubNa//cv7MViD/qLMxxkgQ== X-Google-Smtp-Source: AGRyM1sQl5cqH63HPgknS6/o1ykpwybk//qudzbfgglFjDL8qQJpX626a+cQNqh9Xlkj2+M40g0KWQ== X-Received: by 2002:a19:dc4d:0:b0:489:63cb:20c7 with SMTP id f13-20020a19dc4d000000b0048963cb20c7mr6494786lfj.101.1659429232964; Tue, 02 Aug 2022 01:33:52 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id t17-20020a2e4611000000b0025e1ec74e25sm869652lja.43.2022.08.02.01.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:33:52 -0700 (PDT) Message-ID: <64e3702b-f09b-5a2e-b6a5-4c8752fbad77@linaro.org> Date: Tue, 2 Aug 2022 10:33:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 9/9] ARM: dts: uniphier: Remove compatible "snps,dw-pcie-ep" from Pro5 pcie-ep node Content-Language: en-US To: Arnd Bergmann , Kunihiko Hayashi Cc: Rob Herring , Krzysztof Kozlowski , Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1656894026-15707-1-git-send-email-hayashi.kunihiko@socionext.com> <1656894026-15707-10-git-send-email-hayashi.kunihiko@socionext.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_013354_902257_9B4AE76D X-CRM114-Status: GOOD ( 14.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2022 13:58, Arnd Bergmann wrote: > On Mon, Jul 4, 2022 at 2:20 AM Kunihiko Hayashi > wrote: >> >> UniPhier PCIe endpoint controller doesn't use "snps,dw-pcie-ep" compatible, >> so this is no longer needed. Remove the compatible string from the pcie-ep >> node to fix the following warning. >> >> uniphier-pro5-epcore.dtb: pcie@66000000: compatible: ['socionext,uniphier-pro5-pcie-ep', 'snps,dw-pcie-ep'] is too long >> From schema: Documentation/devicetree/bindings/pci/socionext,uniphier-pcie-ep.yaml >> > > This sounds like a problem with the binding rather than the dt file. Is this not > a designware pci endpoint? Should it be documented in that binding instead? Depends. We had one or two similar cases, where we dropped the snps/dw generic compatible, because device was actually quite different and could not match against snps/dw compatible. IOW, if device bound/matched via generic compatible it would be entirely non-operational. Logically I think it is okay to drop the generic compatible. Different question is any ABI break. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel