From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>, Marc Zyngier <maz@kernel.org>
Cc: Nishanth Menon <nm@ti.com>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/2] dt-bindings: irqchip: Update bindings to drop the usage of gic as parent
Date: Fri, 25 Oct 2019 19:07:59 +0300 [thread overview]
Message-ID: <65f23e59-c1e5-f44e-80e4-c4f450a2e670@ti.com> (raw)
In-Reply-To: <20190923042405.26064-2-lokeshvutla@ti.com>
Hi Lokesh,
On 9/23/19 7:24 AM, Lokesh Vutla wrote:
> Drop the firmware related dt-bindings and use the hardware specified
> interrupt numbers within Interrupt Router. This ensures interrupt router
> DT node need not assume any interrupt parent type.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> .../interrupt-controller/ti,sci-intr.txt | 28 +++++++++----------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> index 1a8718f8855d..de5de2a4b467 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
> @@ -44,15 +44,14 @@ Required Properties:
> 4: If intr supports level triggered interrupts.
> - interrupt-controller: Identifies the node as an interrupt controller
> - #interrupt-cells: Specifies the number of cells needed to encode an
> - interrupt source. The value should be 2.
> - First cell should contain the TISCI device ID of source
> - Second cell should contain the interrupt source offset
> - within the device.
> + interrupt source. The value should be 1.
> + First cell should contain interrupt router input number
> + as specified by hardware.
> +- power-domains: phandle pointing to the corresponding PM domain node
> + and an ID representing the device.
> - ti,sci: Phandle to TI-SCI compatible System controller node.
> -- ti,sci-dst-id: TISCI device ID of the destination IRQ controller.
> -- ti,sci-rm-range-girq: Array of TISCI subtype ids representing the host irqs
> - assigned to this interrupt router. Each subtype id
> - corresponds to a range of host irqs.
> +- interrupt-ranges: Ranges that convert the INTR output interrupt numbers to
> + parent's interrupt number.
I believe this change is transparent for INTA for things inside NAVSS,
like DMA, rings, etc?
>
> For more details on TISCI IRQ resource management refer:
> http://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
> @@ -62,21 +61,20 @@ Example:
> The following example demonstrates both interrupt router node and the consumer
> node(main gpio) on the AM654 SoC:
>
> -main_intr: interrupt-controller0 {
> +main_gpio_intr: interrupt-controller0 {
> compatible = "ti,sci-intr";
> ti,intr-trigger-type = <1>;
> interrupt-controller;
> interrupt-parent = <&gic500>;
> - #interrupt-cells = <2>;
> + power-domains = <&k3_pds 131 TI_SCI_PD_SHARED>;
> + #interrupt-cells = <1>;
> ti,sci = <&dmsc>;
> - ti,sci-dst-id = <56>;
> - ti,sci-rm-range-girq = <0x1>;
> + interrupt-ranges = <0 360 32>;
> };
>
> main_gpio0: gpio@600000 {
> ...
> - interrupt-parent = <&main_intr>;
> - interrupts = <57 256>, <57 257>, <57 258>,
> - <57 259>, <57 260>, <57 261>;
> + interrupt-parent = <&main_gpio_intr>;
> + interrupts = <192>, <193>, <194>, <195>, <196>, <197>;
> ...
> };
>
- Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-25 16:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 4:24 [RFC PATCH 0/2] irqchip/ti-sci-intr: Add support for INTR connecting to INTR Lokesh Vutla
2019-09-23 4:24 ` [RFC PATCH 1/2] dt-bindings: irqchip: Update bindings to drop the usage of gic as parent Lokesh Vutla
2019-10-02 12:57 ` Marc Zyngier
2019-10-03 13:15 ` Lokesh Vutla
2019-10-09 5:00 ` Lokesh Vutla
2019-10-24 10:22 ` Lokesh Vutla
2019-10-25 10:46 ` Marc Zyngier
2019-10-25 16:07 ` Peter Ujfalusi [this message]
2019-10-29 6:20 ` Lokesh Vutla
2019-09-23 4:24 ` [RFC PATCH 2/2] irqchip/ti-sci-intr: Add support for INTR being a parent to INTR Lokesh Vutla
2019-10-02 13:12 ` Marc Zyngier
2019-10-04 3:37 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f23e59-c1e5-f44e-80e4-c4f450a2e670@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=maz@kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).