From: tengfeif@codeaurora.org
To: Mark Rutland <mark.rutland@arm.com>
Cc: tengfei@codeaurora.org, anshuman.khandual@arm.com,
marc.zyngier@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
andreyknvl@google.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: break while loop if task had been rescheduled
Date: Thu, 30 May 2019 10:41:11 +0800 [thread overview]
Message-ID: <665641d42e21da3466693ac49ac5d40e@codeaurora.org> (raw)
In-Reply-To: <20190524104148.GB12796@lakrids.cambridge.arm.com>
On 2019-05-24 18:41, Mark Rutland wrote:
> On Tue, May 21, 2019 at 05:20:04PM +0800, Tengfei Fan wrote:
>> While printing a task's backtrace and this task isn't
>> current task, it is possible that task's fp and fp+8
>> have the same value, so cannot break the while loop.
>> This can break while loop if this task had been
>> rescheduled during print this task's backtrace.
>
> There are a few cases where backtracing can get stuck in an infinite
> loop. I'd attempted to address that more generally in my
> arm64/robust-stacktrace branch [1].
>
> Looking at tsk->state here is inherently racy, and doesn't solve the
> general case, so I'd prefer to avoid that.
>
> Do my patches help you here? If so, I'm happy to rebase those to
> v5.2-rc1 and repost.
I think your arm64/robust-stacktrace branch [1] can cover my issue,
please
rebase and reposet
Thanks,
Tengfei Fan
>
> Thanks,
> Mark.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/robust-stacktrace
>
>>
>> Signed-off-by: Tengfei Fan <tengfeif@codeaurora.org>
>> ---
>> arch/arm64/kernel/traps.c | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
>> index 2975598..9df6e02 100644
>> --- a/arch/arm64/kernel/traps.c
>> +++ b/arch/arm64/kernel/traps.c
>> @@ -103,6 +103,9 @@ void dump_backtrace(struct pt_regs *regs, struct
>> task_struct *tsk)
>> {
>> struct stackframe frame;
>> int skip = 0;
>> + long cur_state = 0;
>> + unsigned long cur_sp = 0;
>> + unsigned long cur_fp = 0;
>>
>> pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk);
>>
>> @@ -127,6 +130,9 @@ void dump_backtrace(struct pt_regs *regs, struct
>> task_struct *tsk)
>> */
>> frame.fp = thread_saved_fp(tsk);
>> frame.pc = thread_saved_pc(tsk);
>> + cur_state = tsk->state;
>> + cur_sp = thread_saved_sp(tsk);
>> + cur_fp = frame.fp;
>> }
>> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>> frame.graph = 0;
>> @@ -134,6 +140,23 @@ void dump_backtrace(struct pt_regs *regs, struct
>> task_struct *tsk)
>>
>> printk("Call trace:\n");
>> do {
>> + if (tsk != current && (cur_state != tsk->state
>> + /*
>> + * We would not be printing backtrace for the task
>> + * that has changed state from uninterruptible to
>> + * running before hitting the do-while loop but after
>> + * saving the current state. If task is in running
>> + * state before saving the state, then we may print
>> + * wrong call trace or end up in infinite while loop
>> + * if *(fp) and *(fp+8) are same. While the situation
>> + * will stop print when that task schedule out.
>> + */
>> + || cur_sp != thread_saved_sp(tsk)
>> + || cur_fp != thread_saved_fp(tsk))) {
>> + printk("The task:%s had been rescheduled!\n",
>> + tsk->comm);
>> + break;
>> + }
>> /* skip until specified stack frame */
>> if (!skip) {
>> dump_backtrace_entry(frame.pc);
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-30 2:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:20 [PATCH] arm64: break while loop if task had been rescheduled Tengfei Fan
2019-05-22 9:04 ` Anshuman Khandual
2019-05-30 1:38 ` tengfeif
2019-05-24 10:41 ` Mark Rutland
2019-05-30 2:41 ` tengfeif [this message]
2019-05-24 3:16 tengfeif
2019-05-24 10:38 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=665641d42e21da3466693ac49ac5d40e@codeaurora.org \
--to=tengfeif@codeaurora.org \
--cc=andreyknvl@google.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=tengfei@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).