From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89791C43603 for ; Fri, 13 Dec 2019 22:23:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 606012077B for ; Fri, 13 Dec 2019 22:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jmVCOuIQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VVsL5OLB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 606012077B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/Poob3/mFh0mwgY2c5WgBL1P5ZoW55XoBWt8AGml87s=; b=jmVCOuIQgg1tOtKoikkh8A9K4 8o5N3g2vV3s+9g84fbu810F5XdwRUyx3HzL93zNC/CnY3Wx+iLSX05XpkqEmigpNWatQp+rPTCsGi SpxM9+mZgYkGRhxCYQ1gahJXoOmCepNpzYdRFAxZEAJ0Z5WT5YWQonaMU1sG0WRf53gDE8IeBQWlo 2KKHdce1RTJauTxThPgBJt37kMnIj/egxUZ4uNuuC+w6YjoOHfu976fUspRBWktFKJnuHv1dNhC8y CIbJo3fkLBXYHOQpJ1OXwqdF7cW8YSY0SB2pPbbDpHb0ja1BJS3NpTIij0iKF42TwhlXIsK/FDgQH zjzArYbtQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ift9s-0007bC-JK; Fri, 13 Dec 2019 22:11:36 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ift9o-0007aa-VL for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 22:11:34 +0000 Received: by mail-pf1-x442.google.com with SMTP id 2so2174542pfg.12 for ; Fri, 13 Dec 2019 14:11:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=C+QP07g8UnbrKTlv69LJ7GDz3+K6EqCsH4JenbUk3Kw=; b=VVsL5OLBC828OXXGuWkPmeOqE6dl9B1vqgwII2zwTEEOps5suW7Ta8Tre5nO/z2k5S KEjA30YWoBPYuMq0CR/TSXZ2C2fut9PjKHddKlOkU9HcshazJrg1NBvXowZX6gVgzA3w ye8MHrRio7y68YvHSTR5QBXkxAuT7T+170DLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C+QP07g8UnbrKTlv69LJ7GDz3+K6EqCsH4JenbUk3Kw=; b=nIoEyFMUYrrNWuh9ND1aU6WBE1pE5xaEGuxp5x9QixkC3iKTi3spe2SCIqd8+JtQCM 8DqR6NNxJi/sQnBMn8ZjZgoRHGvd1r3nAn0hbNSBAnbqNRic4SJv6aLLAONDaRjdiKAv cOrrKzVpYRv72R3WzCsD5TMi/0nyChRszuuYaciCF/J0/u0gOveXeHALI/X5NmCqDfAT s1i6JZiH7KXj/WtexSgRF+1xGD8WTRE4vLSVea27OJRypJHXNQWBSPkk723S1vhxyDK5 jRPlFIX1rXt5sb2A9GhAGqOIoqwq+tj2tgGmwns78x0bdZavqFo9tSgZevUmCPOxETXW d7Sw== X-Gm-Message-State: APjAAAVv8fD6mXof6ud8OEdNqw2b7ZJ2GXptwQd7jatWutq68nDBK+N5 zTwqdp7aex9eIFFF/dB/4oFDmw== X-Google-Smtp-Source: APXvYqwIZlSLDSybVYp++8LzZ91boGCACbVxcoAb9anmR3Fz0rOVecZifUt5x7t7Risgbey7DBgAcQ== X-Received: by 2002:aa7:8f05:: with SMTP id x5mr1979774pfr.86.1576275089947; Fri, 13 Dec 2019 14:11:29 -0800 (PST) Received: from rj-aorus.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id d38sm10991179pgd.59.2019.12.13.14.11.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 14:11:28 -0800 (PST) Subject: Re: [PATCH] ARM: dts: NSP: Use hardware I2C for BCM958625HR To: Florian Fainelli , linux-arm-kernel@lists.infradead.org References: <20191213195102.23789-1-f.fainelli@gmail.com> From: Ray Jui Message-ID: <667acf12-cff3-8955-8849-b99db50375bb@broadcom.com> Date: Fri, 13 Dec 2019 14:11:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191213195102.23789-1-f.fainelli@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_141133_012153_41B83FCC X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Scott Branden , Ray Jui , open list , Rob Herring , "maintainer:BROADCOM IPROC ARM ARCHITECTURE" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-12-13 11:51 a.m., Florian Fainelli wrote: > Now that the i2c-bcm-iproc driver has been fixed to permit reading more > than 63 bytes in a single transaction with commit fd01eecdf959 ("i2c: > iproc: Fix i2c master read more than 63 bytes") we no longer need to > bitbang i2c over GPIOs which was necessary before to allow the > PHYLINK/SFP subsystems to read SFP modules. > This is good to hear! > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/bcm958625hr.dts | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/boot/dts/bcm958625hr.dts b/arch/arm/boot/dts/bcm958625hr.dts > index a2c9de35ddfb..536fb24f38bb 100644 > --- a/arch/arm/boot/dts/bcm958625hr.dts > +++ b/arch/arm/boot/dts/bcm958625hr.dts > @@ -55,18 +55,9 @@ > priority = <200>; > }; > > - /* Hardware I2C block cannot do more than 63 bytes per transfer, > - * which would prevent reading from a SFP's EEPROM (256 byte). > - */ > - i2c1: i2c { > - compatible = "i2c-gpio"; > - sda-gpios = <&gpioa 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > - scl-gpios = <&gpioa 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > - }; > - So I suppose GPIO 4 and 5 from the 'gpioa' controller are tied to the same SCL/SDA pins from i2c0 and they are internally muxed, right? Is the mux to GPIO done automatically when pins are configured as GPIO, and therefore you don't require any additional changes to pinmux to make this work, after changing it back to use real I2C0 block below? > sfp: sfp { > compatible = "sff,sfp"; > - i2c-bus = <&i2c1>; > + i2c-bus = <&i2c0>; > mod-def0-gpios = <&gpioa 28 GPIO_ACTIVE_LOW>; > los-gpios = <&gpioa 24 GPIO_ACTIVE_HIGH>; > tx-fault-gpios = <&gpioa 30 GPIO_ACTIVE_HIGH>; > @@ -74,6 +65,10 @@ > }; > }; > > +&i2c0 { > + status = "okay"; > +}; > + > &amac0 { > status = "okay"; > }; > Change looks good to me. Reviewed-by: Ray Jui Thanks, Ray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel