From: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
To: "Shawn Guo" <shawnguo@kernel.org>,
"Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: fix PWM[1-4] interrupts
Date: Mon, 24 Jun 2019 09:36:37 +0200 [thread overview]
Message-ID: <670f98af-2c55-de1f-d36c-37d1f33086c7@armadeus.com> (raw)
In-Reply-To: <20190624004703.GF3800@dragon>
Hello,
On 6/24/19 2:47 AM, Shawn Guo wrote:
> +Lothar
>
> On Tue, Jun 18, 2019 at 05:58:34PM +0200, Sébastien Szymanski wrote:
>> According to the i.MX6UL/L RM, table 3.1 "ARM Cortex A7 domain interrupt
>> summary", the interrupts for the PWM[1-4] go from 83 to 86.
>>
>> Fixes: b9901fe84f02 ("ARM: dts: imx6ul: add pwm[1-4] nodes")
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>
> Just curious - did you spot the error by testing PWM or merely by
> looking at the code and document?
I spotted the error when trying to play sound with PWM [1].
The PWM driver (drivers/pwm/pwm-imx27.c) don't use interrupt that's
probably why nobody notice this error.
[1] https://github.com/sasamy/imx-snd-pwm
Regards,
>
> Shawn
>
>> ---
>> arch/arm/boot/dts/imx6ul.dtsi | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
>> index bbf010c73336..a7f6d1d58e20 100644
>> --- a/arch/arm/boot/dts/imx6ul.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul.dtsi
>> @@ -358,7 +358,7 @@
>> pwm1: pwm@2080000 {
>> compatible = "fsl,imx6ul-pwm", "fsl,imx27-pwm";
>> reg = <0x02080000 0x4000>;
>> - interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clks IMX6UL_CLK_PWM1>,
>> <&clks IMX6UL_CLK_PWM1>;
>> clock-names = "ipg", "per";
>> @@ -369,7 +369,7 @@
>> pwm2: pwm@2084000 {
>> compatible = "fsl,imx6ul-pwm", "fsl,imx27-pwm";
>> reg = <0x02084000 0x4000>;
>> - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clks IMX6UL_CLK_PWM2>,
>> <&clks IMX6UL_CLK_PWM2>;
>> clock-names = "ipg", "per";
>> @@ -380,7 +380,7 @@
>> pwm3: pwm@2088000 {
>> compatible = "fsl,imx6ul-pwm", "fsl,imx27-pwm";
>> reg = <0x02088000 0x4000>;
>> - interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupts = <GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clks IMX6UL_CLK_PWM3>,
>> <&clks IMX6UL_CLK_PWM3>;
>> clock-names = "ipg", "per";
>> @@ -391,7 +391,7 @@
>> pwm4: pwm@208c000 {
>> compatible = "fsl,imx6ul-pwm", "fsl,imx27-pwm";
>> reg = <0x0208c000 0x4000>;
>> - interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&clks IMX6UL_CLK_PWM4>,
>> <&clks IMX6UL_CLK_PWM4>;
>> clock-names = "ipg", "per";
>> --
>> 2.21.0
>>
--
Sébastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-24 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 15:58 [PATCH 1/1] ARM: dts: imx6ul: fix PWM[1-4] interrupts Sébastien Szymanski
2019-06-18 16:43 ` Fabio Estevam
2019-06-24 0:47 ` Shawn Guo
2019-06-24 7:36 ` Sébastien Szymanski [this message]
2019-06-24 13:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=670f98af-2c55-de1f-d36c-37d1f33086c7@armadeus.com \
--to=sebastien.szymanski@armadeus.com \
--cc=LW@KARO-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).