From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F38C76192 for ; Wed, 17 Jul 2019 06:36:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B8D521743 for ; Wed, 17 Jul 2019 06:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XP8CnUP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B8D521743 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FPB2t+y7+l12QynXzQqCZqOJf4b113Eow5sk/mWYgW8=; b=XP8CnUP1vEEQrp uHUJcEqh+DfEgCI6sJaIhcVXtDdp5+O7W2z0P80mYDEtbbXB7trGhI+26whNyQtyW8sORexHqPXHp 5Q9gxQdwbrWkG93o7DeXbzFHwQFzAERdndx3bTqsWJTCrvD4IY6NJ+hSUkQ2yi+6qiPMUYn7yEKLx UVe2DZy+8QiUnEIJ0kJBdm97p+iKyjxiLUH0WWbbca4voKT/3NKAHue/eYILtqNfn2FMutywLB/AF U4J12sjhO984DBUwDuKg6Pix/VjfZsMiFR/9ribKRJomzRyC1m0lvRglCGC49uL/vUUnLXW/PzNLu YyoZXKgMTkxQXDQxrmqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hndYE-0000eZ-7H; Wed, 17 Jul 2019 06:36:30 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hndYA-0000Ik-3V for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 06:36:28 +0000 Received: from DGGEMM402-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 7D03515792F57B4A9A3D; Wed, 17 Jul 2019 14:36:14 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM402-HUB.china.huawei.com (10.3.20.210) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 17 Jul 2019 14:36:13 +0800 Received: from DGGEMM506-MBX.china.huawei.com ([169.254.3.227]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0439.000; Wed, 17 Jul 2019 14:36:09 +0800 From: "Zengtao (B)" To: Maxime Ripard Subject: RE: [PATCH] phy: Change the configuration interface param to void* to make it more general Thread-Topic: [PATCH] phy: Change the configuration interface param to void* to make it more general Thread-Index: AQHVN9Ajzwa2MbZo40exGsBlwJEt36bEv5mAgAln51A= Date: Wed, 17 Jul 2019 06:36:09 +0000 Message-ID: <678F3D1BB717D949B966B68EAEB446ED2FF5B22D@DGGEMM506-MBX.china.huawei.com> References: <1562868255-31467-1-git-send-email-prime.zeng@hisilicon.com> <20190711112039.leuvelpm7opeoaxq@flea> In-Reply-To: <20190711112039.leuvelpm7opeoaxq@flea> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.222.33] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_233626_322251_EC1FB64D X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , "kishon@ti.com" , Paul Kocialkowski , Chen-Yu Tsai , Sakari Ailus , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime: Thanks for your reply. >-----Original Message----- >From: Maxime Ripard [mailto:maxime.ripard@bootlin.com] >Sent: Thursday, July 11, 2019 7:21 PM >To: Zengtao (B) >Cc: kishon@ti.com; Chen-Yu Tsai ; Paul Kocialkowski >; Sakari Ailus ; >linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org >Subject: Re: [PATCH] phy: Change the configuration interface param to void* >to make it more general > >* PGP Signed by an unknown key > >On Fri, Jul 12, 2019 at 02:04:08AM +0800, Zeng Tao wrote: >> The phy framework now allows runtime configurations, but only limited >> to mipi now, and it's not reasonable to introduce user specified >> configurations into the union phy_configure_opts structure. An simple >> way is to replace with a void *. > >I'm not sure why it's unreasonable? > The phy.h will need to include vendor specific phy headers, and the union phy_configure_opts will become more complex. I don't think this is a good solution to include all vendor specific phy configs into a single union structure. >> We have already got some phy drivers which introduce private phy API >> for runtime configurations, and with this patch, they can switch to >> the phy_configure as a replace. > >If you have a custom mode of operation, then you'll need a custom >phy_mode as well, and surely you can have a custom set of parameters. > >Since those functions are meant to provide a two-way negotiation of the >various parameters, you'll have to have that structure shared between the >two either way, so the only thing required in addition to what you would have >passing a void is one line to add that structure in the union. > >That's barely unreasonable. > >Maxime > >-- >Maxime Ripard, Bootlin >Embedded Linux and Kernel engineering >https://bootlin.com > >* Unknown Key >* 0x671851C5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel