From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADAA3C433E9 for ; Fri, 5 Mar 2021 11:21:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1480265017 for ; Fri, 5 Mar 2021 11:21:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1480265017 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jxQuX5JxYbCjTuk/eZZ0CqLnojNucInLWXGIJVmTiH8=; b=m934NTbYin0c6fuj5MHq7RfCy 7lBhq2/eCS4S1QQT9+frhLWLQbf82OuTWT3MTNOQ6HSAGCq3YOUuHztT0ec4U4aYuwGN8JqChkPzi nZbV5y9J1NZ3stgae849jDEfaSPY+4X18McmZshyHab6BsbnOqDCJVDMvwZqRJhByCquQV+5sjidu haa1wXo99ARoCGXeZ/8y6JO5YJQq5seKs6s2VHqigXDgX0i+tcpqZXIwrtKs3242JOS8GEBKnvE+S e9tpAbSb41YwaHHOC4OCjgqUDADbXE6NHP1U+AsQ56bYOSHVmpjoKE0h8zZqBNk3K9ZMthCpWcQFk i+QjmPgfQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI8Uc-00EjJh-MF; Fri, 05 Mar 2021 11:19:38 +0000 Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI8UU-00EjHm-NN for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 11:19:33 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4DsQHM2bClz1rwZx; Fri, 5 Mar 2021 12:19:27 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4DsQHM1RXpz1qql1; Fri, 5 Mar 2021 12:19:27 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id g8ukw2-2iY5D; Fri, 5 Mar 2021 12:19:25 +0100 (CET) X-Auth-Info: hIq5BtVqXipAHuinsCM9doc6SMljcqc46cXsddXrcgU= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 5 Mar 2021 12:19:25 +0100 (CET) Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add PU,VDD1P1,VDD2P5 regulators To: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org, Christoph Niedermaier , Fabio Estevam , Ludwig Zenz , NXP Linux Team , Greg Kroah-Hartman , Arnd Bergmann References: <20210203235403.308539-1-marex@denx.de> <20210303125614.GG15865@dragon> <3189923d-df38-6dab-6be7-b2439c234fe4@denx.de> <20210304075652.GN15865@dragon> <5ae1374f-fd10-523f-7b6f-fa7fb40eba20@denx.de> <20210305083931.GT15865@dragon> From: Marek Vasut Message-ID: <678b6564-14c2-7085-8750-06bbc235ae8d@denx.de> Date: Fri, 5 Mar 2021 12:19:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210305083931.GT15865@dragon> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_111931_257595_F6B2ED2A X-CRM114-Status: GOOD ( 22.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/5/21 9:39 AM, Shawn Guo wrote: > On Thu, Mar 04, 2021 at 01:07:32PM +0100, Marek Vasut wrote: >> On 3/4/21 8:56 AM, Shawn Guo wrote: >>> On Wed, Mar 03, 2021 at 03:04:07PM +0100, Marek Vasut wrote: >>>> On 3/3/21 1:56 PM, Shawn Guo wrote: >>>>> On Thu, Feb 04, 2021 at 12:54:03AM +0100, Marek Vasut wrote: >>>>>> Per schematic, both PU and SOC regulator are supplied from LTC3676 SW1 >>>>>> via VDDSOC_IN rail, add the PU input. Both VDD1P1, VDD2P5 are supplied >>>>>> from LTC3676 SW2 via VDDHIGH_IN rail, add both inputs. >>>>>> >>>>>> Fixes: 52c7a088badd ("ARM: dts: imx6q: Add support for the DHCOM iMX6 SoM and PDK2") >>>>> >>>>> It's more like an improvement or additions rather than fixes. I dropped >>>>> the tag and applied for -next. >>>> >>>> I would argue that describing SoC regulators correctly is a bugfix, since it >>>> can lead to stability issues of the SoC. >>> >>> Then resend the patch with details of the issue that it fixes. >> >> Can you please tell me what is missing in the original patch description >> that justifies dropping the Fixes: tag ? I would argue that fully describing >> CPU regulators in DT is a fix which should go through the stable tree and >> the original patch description is accurate. > > You claim that the patch fixes a stability issue, but commit log > mentions nothing about it. Correction, I claim it can lead to stability issues, so far none were observed to my knowledge. But I would argue a correct regulator setup in DT for a specific device is a bugfix and should go through stable tree. Please correct me if I'm wrong. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel