From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0440C433B4 for ; Tue, 11 May 2021 15:11:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0750561396 for ; Tue, 11 May 2021 15:11:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0750561396 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wujvPgLcrQtG1aVBul5szLeSgAl7S8ObMHqxUvg9hes=; b=UafAsR5Q4MteN5aZkYQn3m575 JL6uArJ9cw0Juh5+tjxN2HGmCob7bgsTNrAq5l7kDf0hHyRQBGB3tmR33u2PBr/XOgD50GJUHWH0p LcQfzaQsNSy/9NYr775h/QhP6vWtYm/knuhCA3G/77PjcXM2ljSyjBAwPjkEsJRBmpOlImeu5H37T r1sxwNMb3nURErtNLkWb/T5F7Vgz5YkgzvFq5Z829A4kzM7cvnY8ruE1kLuum6ygWraXnNU09r/o+ NjxMr74474dhGyfP5fYJ9WbxYwTKRe3YpcprUDdaKaL12jhEcRUC1ng6tlF4oJ7M9GHJ8c1kT/uwM zjnnBdCGQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgU1F-000YwZ-Ig; Tue, 11 May 2021 15:09:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgU14-000Yuf-F1 for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 15:09:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=Dd3BAY4LHeMGt4I7Gn+peV7+TPMSkkQjBljubv2gyC0=; b=atINbUUBtgGzkb5ZbGtgq8IFx6 UGhqbiU91hyCjIR3ARLoyA9YkGmr9vdJ03uyOXSiYeIh8BkuBP/59HGwHL27o4SGfwPwYYFGFTwXv p37rMdK0QkXlfgNeBY6XPrOHvt5kX3hljTdA3NHUwOBjWzzI9Ksf75Ytix3QEELgkj40Rx2Skp2W1 46XOzETXuNJDhfP2GxUR/QoEqlHPjLiGeJBXhmymdlAldaZUtmteVDBHXLmPOihkRGBAP191FSXC7 5qNnmk5zwLuHDxZqvtfojTn6pc0/TEn/3GfWULVFOVVLR20hfLTxuyVtB55meDV4bG/uJg4yfy+30 oqhDr2Wg==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgU11-009hqR-EK for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 15:09:45 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14BF9c8l100508; Tue, 11 May 2021 10:09:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1620745778; bh=Dd3BAY4LHeMGt4I7Gn+peV7+TPMSkkQjBljubv2gyC0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=R5VmpG5HumEEfO1DV0oTYVmhrwgz4rCL95Ft5hs4nW3yJU4Vbap9aWo0RjgQVxUD4 dk6qsCTYTFRAVqiTc2goyV6KjtZKQmuWXQiir7TCdOBYH2dEo2G/9glZQrgMcUVgfv b3oJdqQuuOFAm3rmRsCS8z2uRrwzstxkbJwQmu7g= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14BF9cJk033955 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 May 2021 10:09:38 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 11 May 2021 10:09:37 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 11 May 2021 10:09:37 -0500 Received: from [10.250.234.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14BF9WRc090534; Tue, 11 May 2021 10:09:35 -0500 Subject: Re: [PATCH] arm64: dts: ti: k3-am65|j721e|am64: Map the dma / navigator subsystem via explicit ranges To: Nishanth Menon , Tero Kristo , CC: , , , References: <20210510145429.8752-1-nm@ti.com> From: Vignesh Raghavendra Message-ID: <67cc87c4-2ad8-04ab-e583-0b544bcadbce@ti.com> Date: Tue, 11 May 2021 20:39:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210510145429.8752-1-nm@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_080943_643231_65728954 X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/10/21 8:24 PM, Nishanth Menon wrote: > Instead of using empty ranges property, lets map explicitly the address > range that is mapped onto the dma / navigator subsystems (navss/dmss). > > This is also exposed via the dtbs_check with dt-schema newer than > 2021.03 version by throwing out following: > arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: bus@100000: main-navss: > {'type': 'object'} is not allowed for > {'compatible': ['simple-mfd'], '#address-cells': [[2]], ..... > > This has already been correctly done for J7200, however was missed for > other k3 SoCs. Fix that oversight. > > Signed-off-by: Nishanth Menon > --- > Acked-by: Vignesh Raghavendra > if possible, I'd like to pick this fixup for 5.13 window.. > > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 ++-- > arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++-- > 5 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index a49e41021573..bb19db04a746 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -42,12 +42,12 @@ gic_its: msi-controller@1820000 { > }; > }; > > - dmss: dmss { > + dmss: bus@48000000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > dma-ranges; > - ranges; > + ranges = <0x00 0x48000000 0x00 0x48000000 0x00 0x06400000>; > > ti,sci-dev-id = <25>; > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 037f9776c4c8..fea8260d33a8 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -445,11 +445,11 @@ intr_main_gpio: interrupt-controller@a00000 { > ti,interrupt-ranges = <0 392 32>; > }; > > - main-navss { > + main_navss: bus@30800000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x0 0x30800000 0x0 0x30800000 0x0 0xbc00000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > index 0388c02c2203..f5b8ef2f5f77 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi > @@ -116,11 +116,11 @@ adc { > }; > }; > > - mcu-navss { > + mcu_navss: bus@28380000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index 512371e36a30..b2d25af872e2 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -88,11 +88,11 @@ main_gpio_intr: interrupt-controller@a00000 { > ti,interrupt-ranges = <8 392 56>; > }; > > - main-navss { > + main_navss: bus@30000000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>; > dma-coherent; > dma-ranges; > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > index ad12a5c9f209..172629fa3c7c 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi > @@ -250,11 +250,11 @@ adc { > }; > }; > > - mcu-navss { > + mcu_navss: bus@28380000 { > compatible = "simple-mfd"; > #address-cells = <2>; > #size-cells = <2>; > - ranges; > + ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>; > dma-coherent; > dma-ranges; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel