From: David Hildenbrand <david@redhat.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, akpm@linux-foundation.org,
will@kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE
Date: Thu, 11 Feb 2021 09:37:50 +0100 [thread overview]
Message-ID: <683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com> (raw)
In-Reply-To: <1613024531-19040-1-git-send-email-anshuman.khandual@arm.com>
On 11.02.21 07:22, Anshuman Khandual wrote:
> The following warning gets triggered while trying to boot a 64K page size
> without THP config kernel on arm64 platform.
>
> WARNING: CPU: 5 PID: 124 at mm/vmstat.c:1080 __fragmentation_index+0xa4/0xc0
> Modules linked in:
> CPU: 5 PID: 124 Comm: kswapd0 Not tainted 5.11.0-rc6-00004-ga0ea7d62002 #159
> Hardware name: linux,dummy-virt (DT)
> [ 8.810673] pstate: 20400005 (nzCv daif +PAN -UAO -TCO BTYPE=--)
> [ 8.811732] pc : __fragmentation_index+0xa4/0xc0
> [ 8.812555] lr : fragmentation_index+0xf8/0x138
> [ 8.813360] sp : ffff0000864079b0
> [ 8.813958] x29: ffff0000864079b0 x28: 0000000000000372
> [ 8.814901] x27: 0000000000007682 x26: ffff8000135b3948
> [ 8.815847] x25: 1fffe00010c80f48 x24: 0000000000000000
> [ 8.816805] x23: 0000000000000000 x22: 000000000000000d
> [ 8.817764] x21: 0000000000000030 x20: ffff0005ffcb4d58
> [ 8.818712] x19: 000000000000000b x18: 0000000000000000
> [ 8.819656] x17: 0000000000000000 x16: 0000000000000000
> [ 8.820613] x15: 0000000000000000 x14: ffff8000114c6258
> [ 8.821560] x13: ffff6000bff969ba x12: 1fffe000bff969b9
> [ 8.822514] x11: 1fffe000bff969b9 x10: ffff6000bff969b9
> [ 8.823461] x9 : dfff800000000000 x8 : ffff0005ffcb4dcf
> [ 8.824415] x7 : 0000000000000001 x6 : 0000000041b58ab3
> [ 8.825359] x5 : ffff600010c80f48 x4 : dfff800000000000
> [ 8.826313] x3 : ffff8000102be670 x2 : 0000000000000007
> [ 8.827259] x1 : ffff000086407a60 x0 : 000000000000000d
> [ 8.828218] Call trace:
> [ 8.828667] __fragmentation_index+0xa4/0xc0
> [ 8.829436] fragmentation_index+0xf8/0x138
> [ 8.830194] compaction_suitable+0x98/0xb8
> [ 8.830934] wakeup_kcompactd+0xdc/0x128
> [ 8.831640] balance_pgdat+0x71c/0x7a0
> [ 8.832327] kswapd+0x31c/0x520
> [ 8.832902] kthread+0x224/0x230
> [ 8.833491] ret_from_fork+0x10/0x30
> [ 8.834150] ---[ end trace 472836f79c15516b ]---
>
> This warning comes from __fragmentation_index() when the requested order
> is greater than MAX_ORDER.
>
> static int __fragmentation_index(unsigned int order,
> struct contig_page_info *info)
> {
> unsigned long requested = 1UL << order;
>
> if (WARN_ON_ONCE(order >= MAX_ORDER)) <===== Triggered here
> return 0;
>
> Digging it further reveals that pageblock_order has been assigned a value
> which is greater than MAX_ORDER failing the above check. But why this
> happened ? Because HUGETLB_PAGE_ORDER for the given config on arm64 is
> greater than MAX_ORDER.
>
> The solution involves enabling HUGETLB_PAGE_SIZE_VARIABLE which would make
> pageblock_order a variable instead of constant HUGETLB_PAGE_ORDER. But that
> change alone also did not really work as pageblock_order still got assigned
> as HUGETLB_PAGE_ORDER in set_pageblock_order(). HUGETLB_PAGE_ORDER needs to
> be less than MAX_ORDER for its appropriateness as pageblock_order otherwise
> just fallback to MAX_ORDER - 1 as before. While here it also fixes a build
> problem via type casting MAX_ORDER in rmem_cma_setup().
I'm wondering, is there any real value in allowing FORCE_MAX_ZONEORDER
to be "11" with ARM64_64K_PAGES/ARM64_16K_PAGES?
Meaning: are there any real use cases that actually build a kernel
without TRANSPARENT_HUGEPAGE and with ARM64_64K_PAGES/ARM64_16K_PAGES?
As builds are essentially broken, I assume this is not that relevant? Or
how long has it been broken?
It might be easier to just drop the "TRANSPARENT_HUGEPAGE" part from the
FORCE_MAX_ZONEORDER config.
--
Thanks,
David / dhildenb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-11 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 6:22 [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE Anshuman Khandual
2021-02-11 6:22 ` [PATCH 1/3] mm/page_alloc: Fix pageblock_order when HUGETLB_PAGE_ORDER >= MAX_ORDER Anshuman Khandual
2021-02-11 8:00 ` Christoph Hellwig
2021-02-12 7:12 ` Anshuman Khandual
2021-02-11 6:22 ` [PATCH 2/3] arm64/hugetlb: Enable HUGETLB_PAGE_SIZE_VARIABLE Anshuman Khandual
2021-02-11 8:01 ` Christoph Hellwig
2021-02-12 7:13 ` Anshuman Khandual
2021-02-11 6:22 ` [PATCH 3/3] dma-contiguous: Type cast MAX_ORDER as unsigned int Anshuman Khandual
2021-02-11 8:04 ` Christoph Hellwig
2021-02-12 7:19 ` Anshuman Khandual
2021-02-11 8:37 ` David Hildenbrand [this message]
2021-02-12 7:02 ` [PATCH 0/3] mm/page_alloc: Fix pageblock_order with HUGETLB_PAGE_SIZE_VARIABLE Anshuman Khandual
2021-02-12 9:39 ` David Hildenbrand
2021-02-16 9:02 ` Anshuman Khandual
2021-02-16 9:04 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683c812a-ce3d-ef74-10d1-eaf8a3ae93d4@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).