[PATCH v2 0/3] Add R8A7792/Blanche PFC support

[PATCH v2 0/3] Add R8A7792/Blanche PFC support

[Sergei Shtylyov]

Hello.

   Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-20160711-v4.7-rc7' tag. We're adding the R8A7792 PFC node and
then describe the pins for the SCIFs and SMSC LAN89218 Ethernet chip found on
the Blanche board. These patches depend on the R8A7792 PFC driver patchset
in order to work properly.

[1/3] ARM: dts: r8a7792: add PFC support
[2/3] ARM: dts: blanche: add SCIF0/3 pins
[3/3] ARM: dts: blanche: add Ethernet pins

WBR, Sergei

[PATCH v3 1/3] ARM: dts: r8a7792: add PFC support

[Sergei Shtylyov]

Define the generic R8A7792 part of the PFC device node.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

---
Changes in version 2:
- killed extra empty line;
- added Geert's tag.

 arch/arm/boot/dts/r8a7792.dtsi |    5 +++++
 1 file changed, 5 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792.dtsi
+++ renesas/arch/arm/boot/dts/r8a7792.dtsi
@@ -108,6 +108,11 @@
 			#power-domain-cells = <1>;
 		};
 
+		pfc: pin-controller at e6060000 {
+			compatible = "renesas,pfc-r8a7792";
+			reg = <0 0xe6060000 0 0x144>;
+		};
+
 		dmac0: dma-controller at e6700000 {
 			compatible = "renesas,dmac-r8a7792",
 				     "renesas,rcar-dmac";

[PATCH v3 2/3] ARM: dts: blanche: add SCIF0/3 pins

[Sergei Shtylyov]

Add the (previously omitted) SCIF0/3 pin data to the Blanche board's
device tree.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

---
Changes in version 2:
- added Geert's tag.

 arch/arm/boot/dts/r8a7792-blanche.dts |   18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -57,10 +57,28 @@
 	clock-frequency = <20000000>;
 };
 
+&pfc {
+	scif0_pins: scif0 {
+		groups = "scif0_data";
+		function = "scif0";
+	};
+
+	scif3_pins: scif3 {
+		groups = "scif3_data";
+		function = "scif3";
+	};
+};
+
 &scif0 {
+	pinctrl-0 = <&scif0_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &scif3 {
+	pinctrl-0 = <&scif3_pins>;
+	pinctrl-names = "default";
+
 	status = "okay";
 };

[PATCH v3 3/3] ARM: dts: blanche: add Ethernet pins

[Sergei Shtylyov]

Add the (previously omitted) pin data for the SMSC LAN89218 Ethernet chip
to  the Blanche board's device tree:  the chip's IRQ output is connected to
the SoC's IRQ0 pin and its nCS input is connected to the SoC's EX_CS0# pin.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
Changes in version 3:
- killed extra empty line;
- reformatted the changelog.

 arch/arm/boot/dts/r8a7792-blanche.dts |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -50,6 +50,9 @@
 		reg-io-width = <4>;
 		vddvario-supply = <&d3_3v>;
 		vdd33a-supply = <&d3_3v>;
+
+		pinctrl-0 = <&lan89218_pins>;
+		pinctrl-names = "default";
 	};
 };
 
@@ -67,6 +70,17 @@
 		groups = "scif3_data";
 		function = "scif3";
 	};
+
+	lan89218_pins: lan89218 {
+		intc {
+			groups = "intc_irq0";
+			function = "intc";
+		};
+		lbsc {
+			groups = "lbsc_ex_cs0";
+			function = "lbsc";
+		};
+	};
 };
 
 &scif0 {

[PATCH v2 0/3] Add R8A7792/Blanche PFC support

[Simon Horman]

On Thu, Jul 14, 2016 at 11:58:49PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
>    Here's the set of 3 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-20160711-v4.7-rc7' tag. We're adding the R8A7792 PFC node and
> then describe the pins for the SCIFs and SMSC LAN89218 Ethernet chip found on
> the Blanche board. These patches depend on the R8A7792 PFC driver patchset
> in order to work properly.
> 
> [1/3] ARM: dts: r8a7792: add PFC support
> [2/3] ARM: dts: blanche: add SCIF0/3 pins
> [3/3] ARM: dts: blanche: add Ethernet pins

Thanks, I have queued this up.

[PATCH] ARM: dts: blanche: add support for general purpose switches

[Sergei Shtylyov]

Add support  for the  general purpose  software switches  SW2 and tactile
switches SW24/25 as a virtual keyboard (like it was done with the Lager/
Koelsch boards).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
'renesas.git' repo.

 arch/arm/boot/dts/r8a7792-blanche.dts |   49 ++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -11,6 +11,8 @@
 
 /dts-v1/;
 #include "r8a7792.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Blanche";
@@ -54,6 +56,53 @@
 		pinctrl-0 = <&lan89218_pins>;
 		pinctrl-names = "default";
 	};
+
+	keyboard {
+		compatible = "gpio-keys";
+
+		key-1 {
+			linux,code = <KEY_1>;
+			label = "SW2-1";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 10 GPIO_ACTIVE_LOW>;
+		};
+		key-2 {
+			linux,code = <KEY_2>;
+			label = "SW2-2";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 11 GPIO_ACTIVE_LOW>;
+		};
+		key-3 {
+			linux,code = <KEY_3>;
+			label = "SW2-3";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 12 GPIO_ACTIVE_LOW>;
+		};
+		key-4 {
+			linux,code = <KEY_4>;
+			label = "SW2-4";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 15 GPIO_ACTIVE_LOW>;
+		};
+		key-a {
+			linux,code = <KEY_A>;
+			label = "SW24";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+		};
+		key-b {
+			linux,code = <KEY_B>;
+			label = "SW25";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
+		};
+	};
 };
 
 &extal_clk {

[PATCH] ARM: dts: blanche: add SDHI0 support

[Sergei Shtylyov]

Define the Blanche board dependent part of the SDHI0 (connected to the
micro-SD slot) device node along with  the necessary voltage regulator.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
'renesas.git' repo plus the general purpose switches patch  posted yesterday.

 arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -103,6 +103,17 @@
 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
 		};
 	};
+
+	vcc_sdhi0: regulator-vcc-sdhi0 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "SDHI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
 };
 
 &extal_clk {
@@ -139,6 +150,11 @@
 		groups = "can0_data", "can_clk";
 		function = "can0";
 	};
+
+	sdhi0_pins: sdhi0 {
+		groups = "sdhi0_data4", "sdhi0_ctrl";
+		function = "sdhi0";
+	};
 };
 
 &scif0 {
@@ -161,3 +177,12 @@
 
 	status = "okay";
 };
+
+&sdhi0 {
+	pinctrl-0 = <&sdhi0_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&vcc_sdhi0>;
+	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
+	status = "okay";
+};

[PATCH] ARM: dts: blanche: add DU support

[Sergei Shtylyov]

Define  the  Blanche board dependent part of the DU device node.
Add the device nodes for the  Analog Devices ADV7511W  HDMI transmitter
(connected to DU0) and ADV7123 video DAC (connected to DU1).  Add the
necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA
connectors.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch
posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -57,6 +57,61 @@
 		pinctrl-names = "default";
 	};
 
+	vga-encoder {
+		compatible = "adi,adv7123";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				adv7123_in: endpoint {
+					remote-endpoint = <&du_out_rgb1>;
+				};
+			};
+			port at 1 {
+				reg = <1>;
+				adv7123_out: endpoint {
+					remote-endpoint = <&vga_in>;
+				};
+			};
+		};
+	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con: endpoint {
+				remote-endpoint = <&adv7511_out>;
+			};
+		};
+	};
+
+	vga {
+		compatible = "vga-connector";
+
+		port {
+			vga_in: endpoint {
+				remote-endpoint = <&adv7123_out>;
+			};
+		};
+	};
+
+	x1_clk: x1 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <74250000>;
+	};
+
+	x2_clk: x2 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <65000000>;
+	};
+
 	keyboard {
 		compatible = "gpio-keys";
 
@@ -155,6 +210,16 @@
 		groups = "sdhi0_data4", "sdhi0_ctrl";
 		function = "sdhi0";
 	};
+
+	du0_pins: du0 {
+		groups = "du0_rgb888", "du0_sync", "du0_disp";
+		function = "du0";
+	};
+
+	du1_pins: du1 {
+		groups = "du1_rgb666", "du1_sync", "du1_disp";
+		function = "du1";
+	};
 };
 
 &scif0 {
@@ -186,3 +251,63 @@
 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
+
+&i2c1 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	hdmi at 39 {
+		compatible = "adi,adv7511w";
+		reg = <0x39>;
+		interrupt-parent = <&irqc>;
+		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port at 0 {
+				reg = <0>;
+				adv7511_in: endpoint {
+					remote-endpoint = <&du_out_rgb0>;
+				};
+			};
+
+			port at 1 {
+				reg = <1>;
+				adv7511_out: endpoint {
+					remote-endpoint = <&hdmi_con>;
+				};
+			};
+		};
+	};
+};
+
+&du {
+	pinctrl-0 = <&du0_pins &du1_pins>;
+	pinctrl-names = "default";
+
+	clocks = <&mstp7_clks R8A7792_CLK_DU0>, <&mstp7_clks R8A7792_CLK_DU1>,
+		 <&x1_clk>, <&x2_clk>;
+	clock-names = "du.0", "du.1", "dclkin.0", "dclkin.1";
+	status = "okay";
+
+	ports {
+		port at 0 {
+			endpoint {
+				remote-endpoint = <&adv7511_in>;
+			};
+		};
+		port at 1 {
+			endpoint {
+				remote-endpoint = <&adv7123_in>;
+			};
+		};
+	};
+};

[PATCH] ARM: dts: blanche: add support for general purpose switches

[Simon Horman]

On Wed, Aug 17, 2016 at 10:03:06PM +0300, Sergei Shtylyov wrote:
> Add support  for the  general purpose  software switches  SW2 and tactile
> switches SW24/25 as a virtual keyboard (like it was done with the Lager/
> Koelsch boards).
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks, I have queued this up.

[PATCH] ARM: dts: blanche: add SDHI0 support

[Simon Horman]

Hi Sergei,

On Thu, Aug 18, 2016 at 09:31:54PM +0300, Sergei Shtylyov wrote:
> Define the Blanche board dependent part of the SDHI0 (connected to the
> micro-SD slot) device node along with  the necessary voltage regulator.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
> 'renesas.git' repo plus the general purpose switches patch  posted yesterday.
> 
>  arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> @@ -103,6 +103,17 @@
>  			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	vcc_sdhi0: regulator-vcc-sdhi0 {
> +		compatible = "regulator-fixed";
> +
> +		regulator-name = "SDHI0 Vcc";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +
> +		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +	};
>  };

Is it intentional that there is no vccq_sdhi0 ?

>  
>  &extal_clk {
> @@ -139,6 +150,11 @@
>  		groups = "can0_data", "can_clk";
>  		function = "can0";
>  	};
> +
> +	sdhi0_pins: sdhi0 {
> +		groups = "sdhi0_data4", "sdhi0_ctrl";
> +		function = "sdhi0";
> +	};
>  };
>  
>  &scif0 {
> @@ -161,3 +177,12 @@
>  
>  	status = "okay";
>  };
> +
> +&sdhi0 {
> +	pinctrl-0 = <&sdhi0_pins>;
> +	pinctrl-names = "default";
> +
> +	vmmc-supply = <&vcc_sdhi0>;
> +	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};
> 

[PATCH] ARM: dts: blanche: add DU support

[Simon Horman]

Hi Sergei,

On Fri, Aug 19, 2016 at 11:42:54PM +0300, Sergei Shtylyov wrote:
> Define  the  Blanche board dependent part of the DU device node.
> Add the device nodes for the  Analog Devices ADV7511W  HDMI transmitter
> (connected to DU0) and ADV7123 video DAC (connected to DU1).  Add the
> necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA
> connectors.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
> 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch
> posted earlier.
> 
>  arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
>  1 file changed, 125 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts

...

> @@ -186,3 +251,63 @@
>  	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
>  	status = "okay";
>  };
> +
> +&i2c1 {
> +	status = "okay";
> +	clock-frequency = <400000>;

Is it intentional that there are no pinctrl properties here?

...

[PATCH] ARM: dts: blanche: add DU support

[Geert Uytterhoeven]

Hi Simon,

On Mon, Aug 22, 2016 at 9:41 AM, Simon Horman <horms@verge.net.au> wrote:
> On Fri, Aug 19, 2016 at 11:42:54PM +0300, Sergei Shtylyov wrote:
>> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>
> ...
>
>> @@ -186,3 +251,63 @@
>>       cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
>>       status = "okay";
>>  };
>> +
>> +&i2c1 {
>> +     status = "okay";
>> +     clock-frequency = <400000>;
>
> Is it intentional that there are no pinctrl properties here?

$ git grep -w I2C arch/arm/boot/dts/r8a7792.dtsi
arch/arm/boot/dts/r8a7792.dtsi:         /* I2C doesn't need pinmux */
$

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] ARM: dts: blanche: add DU support

[Sergei Shtylyov]

Hello.

On 8/22/2016 10:41 AM, Simon Horman wrote:

>> Define  the  Blanche board dependent part of the DU device node.
>> Add the device nodes for the  Analog Devices ADV7511W  HDMI transmitter
>> (connected to DU0) and ADV7123 video DAC (connected to DU1).  Add the
>> necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA
>> connectors.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
>> 'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch
>> posted earlier.
>>
>>  arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 125 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>
> ...
>
>> @@ -186,3 +251,63 @@
>>  	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
>>  	status = "okay";
>>  };
>> +
>> +&i2c1 {
>> +	status = "okay";
>> +	clock-frequency = <400000>;
>
> Is it intentional that there are no pinctrl properties here?

    Yes, as I commented in r8a7792.dtsi, all I2C pins are not multiplexed.

MBR, Sergei

[PATCH] ARM: dts: blanche: add SDHI0 support

[Sergei Shtylyov]

On 08/22/2016 10:33 AM, Simon Horman wrote:

>> Define the Blanche board dependent part of the SDHI0 (connected to the
>> micro-SD slot) device node along with  the necessary voltage regulator.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
>> 'renesas.git' repo plus the general purpose switches patch  posted yesterday.
>>
>>  arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> @@ -103,6 +103,17 @@
>>  			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
>>  		};
>>  	};
>> +
>> +	vcc_sdhi0: regulator-vcc-sdhi0 {
>> +		compatible = "regulator-fixed";
>> +
>> +		regulator-name = "SDHI0 Vcc";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +
>> +		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
>> +		enable-active-high;
>> +	};
>>  };
>
> Is it intentional that there is no vccq_sdhi0 ?

    Yes, it's fixed at 3.3V.

[...]

MBR, Sergei

[PATCH] ARM: dts: blanche: add support for general purpose LEDs

[Sergei Shtylyov]

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's
'renesas.git' repo plus the SDHI0/DU patches posted earlier.

 arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -159,6 +159,27 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+			label = "LED17";
+		};
+		led18 {
+			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
+			label = "LED18";
+		};
+		led19 {
+			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
+			label = "LED19";
+		};
+		led20 {
+			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
+			label = "LED20";
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 

[PATCH] ARM: dts: blanche: add SDHI0 support

[Simon Horman]

On Mon, Aug 22, 2016 at 05:04:10PM +0300, Sergei Shtylyov wrote:
> On 08/22/2016 10:33 AM, Simon Horman wrote:
> 
> >>Define the Blanche board dependent part of the SDHI0 (connected to the
> >>micro-SD slot) device node along with  the necessary voltage regulator.
> >>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>
> >>---
> >>This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
> >>'renesas.git' repo plus the general purpose switches patch  posted yesterday.
> >>
> >> arch/arm/boot/dts/r8a7792-blanche.dts |   25 +++++++++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >>Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> >>===================================================================
> >>--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
> >>+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> >>@@ -103,6 +103,17 @@
> >> 			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
> >> 		};
> >> 	};
> >>+
> >>+	vcc_sdhi0: regulator-vcc-sdhi0 {
> >>+		compatible = "regulator-fixed";
> >>+
> >>+		regulator-name = "SDHI0 Vcc";
> >>+		regulator-min-microvolt = <3300000>;
> >>+		regulator-max-microvolt = <3300000>;
> >>+
> >>+		gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
> >>+		enable-active-high;
> >>+	};
> >> };
> >
> >Is it intentional that there is no vccq_sdhi0 ?
> 
>    Yes, it's fixed at 3.3V.

Thanks, I have queued this up.

[PATCH] ARM: dts: blanche: add DU support

[Simon Horman]

On Mon, Aug 22, 2016 at 01:34:12PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 8/22/2016 10:41 AM, Simon Horman wrote:
> 
> >>Define  the  Blanche board dependent part of the DU device node.
> >>Add the device nodes for the  Analog Devices ADV7511W  HDMI transmitter
> >>(connected to DU0) and ADV7123 video DAC (connected to DU1).  Add the
> >>necessary subnodes to interconnect DU, HDMI/VDAC devices, and HDMI/VGA
> >>connectors.
> >>
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>
> >>---
> >>This patch is against the 'renesas-devel-20160817-v4.8-rc2' of Simon Horman's
> >>'renesas.git' repo plus the general purpose switches patch and the SDHI0 patch
> >>posted earlier.
> >>
> >> arch/arm/boot/dts/r8a7792-blanche.dts |  125 ++++++++++++++++++++++++++++++++++
> >> 1 file changed, 125 insertions(+)
> >>
> >>Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> >>===================================================================
> >>--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
> >>+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> >
> >...
> >
> >>@@ -186,3 +251,63 @@
> >> 	cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
> >> 	status = "okay";
> >> };
> >>+
> >>+&i2c1 {
> >>+	status = "okay";
> >>+	clock-frequency = <400000>;
> >
> >Is it intentional that there are no pinctrl properties here?
> 
>    Yes, as I commented in r8a7792.dtsi, all I2C pins are not multiplexed.

Thanks for satisfying my curiosity.
I have queued this up.

[PATCH] ARM: dts: blanche: add support for general purpose LEDs

[Simon Horman]

On Mon, Aug 22, 2016 at 11:39:30PM +0300, Sergei Shtylyov wrote:
> Add support for the general purpose LEDs on the Blanche board.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
> This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's
> 'renesas.git' repo plus the SDHI0/DU patches posted earlier.
> 
>  arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
> @@ -159,6 +159,27 @@
>  		};
>  	};
>  
> +	leds {
> +		compatible = "gpio-leds";
> +
> +		led17 {
> +			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
> +			label = "LED17";

I am unclear of the motivation for using the label property when
its value is so similar to the name of the node.

The reason I noticed this is that it appears to differ from led nodes
for other Renesas ARM SoCs. I'm not opposed to using the label property
if there is some value to it. But I would prefer to use it consistently.
And I'd prefer not to add it to all the other SoCs unless there is a reason
to.

> +		};
> +		led18 {
> +			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
> +			label = "LED18";
> +		};
> +		led19 {
> +			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
> +			label = "LED19";
> +		};
> +		led20 {
> +			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
> +			label = "LED20";
> +		};
> +	};
> +
>  	vcc_sdhi0: regulator-vcc-sdhi0 {
>  		compatible = "regulator-fixed";
>  
> 

[PATCH] ARM: dts: blanche: add support for general purpose LEDs

[Sergei Shtylyov]

On 08/23/2016 10:39 AM, Simon Horman wrote:

>> Add support for the general purpose LEDs on the Blanche board.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> This patch is against the 'renesas-devel-20160822-v4.8-rc3' of Simon Horman's
>> 'renesas.git' repo plus the SDHI0/DU patches posted earlier.
>>
>>  arch/arm/boot/dts/r8a7792-blanche.dts |   21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>> @@ -159,6 +159,27 @@
>>  		};
>>  	};
>>
>> +	leds {
>> +		compatible = "gpio-leds";
>> +
>> +		led17 {
>> +			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
>> +			label = "LED17";
>
> I am unclear of the motivation for using the label property when
> its value is so similar to the name of the node.
>
> The reason I noticed this is that it appears to differ from led nodes
> for other Renesas ARM SoCs.

     I was looking at the Koelsch's DT as an example (and Gose's DT also had 
labels).

> I'm not opposed to using the label property
> if there is some value to it. But I would prefer to use it consistently.
> And I'd prefer not to add it to all the other SoCs unless there is a reason
> to.

    Looks like the driver can infer the LED names from the device node names. 
I'll recast.

[...]

MBR, Sergei

[PATCH v2] ARM: dts: blanche: add support for general purpose LEDs

[Sergei Shtylyov]

Add support for the general purpose LEDs on the Blanche board.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160824-v4.8-rc3' of Simon Horman's
'renesas.git'.

Changes in version 2:
- removed the "label" props.

 arch/arm/boot/dts/r8a7792-blanche.dts |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-blanche.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
+++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -159,6 +159,23 @@
 		};
 	};
 
+	leds {
+		compatible = "gpio-leds";
+
+		led17 {
+			gpios = <&gpio10 10 GPIO_ACTIVE_HIGH>;
+		};
+		led18 {
+			gpios = <&gpio10 11 GPIO_ACTIVE_HIGH>;
+		};
+		led19 {
+			gpios = <&gpio10 12 GPIO_ACTIVE_HIGH>;
+		};
+		led20 {
+			gpios = <&gpio10 23 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 

[PATCH v2] ARM: dts: blanche: add support for general purpose LEDs

[Simon Horman]

On Wed, Aug 24, 2016 at 10:22:22PM +0300, Sergei Shtylyov wrote:
> Add support for the general purpose LEDs on the Blanche board.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thanks, I have queued this up.

[PATCH] ARM: dts: wheat: add support for tactile switches

[Sergei Shtylyov]

Add  support for the  tactile switches  SW2/3 (on the debug board) as a
virtual keyboard like it  was done with the Blanche board).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'renesas-devel-20160905-v4.8-rc5' of Simon Horman's
'renesas.git' repo plus the Wheat DU patch...

 arch/arm/boot/dts/r8a7792-wheat.dts |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Index: renesas/arch/arm/boot/dts/r8a7792-wheat.dts
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792-wheat.dts
+++ renesas/arch/arm/boot/dts/r8a7792-wheat.dts
@@ -12,6 +12,7 @@
 /dts-v1/;
 #include "r8a7792.dtsi"
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Wheat";
@@ -56,6 +57,25 @@
 		pinctrl-names = "default";
 	};
 
+	keyboard {
+		compatible = "gpio-keys";
+
+		key-a {
+			linux,code = <KEY_A>;
+			label = "SW2";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+		};
+		key-b {
+			linux,code = <KEY_B>;
+			label = "SW3";
+			wakeup-source;
+			debounce-interval = <20>;
+			gpios = <&gpio11 2 GPIO_ACTIVE_LOW>;
+		};
+	};
+
 	vcc_sdhi0: regulator-vcc-sdhi0 {
 		compatible = "regulator-fixed";
 

[PATCH] ARM: dts: wheat: add support for tactile switches

[Geert Uytterhoeven]

On Mon, Sep 5, 2016 at 11:33 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add  support for the  tactile switches  SW2/3 (on the debug board) as a
> virtual keyboard like it  was done with the Blanche board).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

DT syntax looks OK to me, I have no board schematics or documentation.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] ARM: dts: wheat: add support for tactile switches

[Simon Horman]

On Tue, Sep 06, 2016 at 09:11:41AM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 5, 2016 at 11:33 PM, Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > Add  support for the  tactile switches  SW2/3 (on the debug board) as a
> > virtual keyboard like it  was done with the Blanche board).
> >
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> DT syntax looks OK to me, I have no board schematics or documentation.

Thanks, I have queued this up.