From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B032BC4360C for ; Wed, 2 Oct 2019 20:59:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 807432070B for ; Wed, 2 Oct 2019 20:59:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S3w9fts7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 807432070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wwwdotorg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ko3lVV0AKvmNkLrX5ymABwJXZf6aQ3zMheHQzWVVU3M=; b=S3w9fts7RdSeQc7IwaoHILeZj qqJ9atuFiec1XJp0WwGRyx/xgc8PsLA0ezL0grwg1CQ22fEW7xBLqxuo7gmHsaq1kSCCDUJyb2v6n 2HwgWpUdRcK8FJQ+inbuM9OEqI3MquK4E+88TWvKTVlq8QYqfmgfFT2eS1P1k3bZMnW/h3W7AhKQB jlMGGka2S0YMZjewiRkuUBJYE28tTENwvqHcLWBnvZwzqo1vJCBx1idmLxmiLSCczaAyLhCkCpKyg lb4MO5+DyRi+znw8A93BnbnMtwzTltDkd7J+hJQPfvXUqsnZqg/d2qOdJ0keZeIlSuxzvtgA+HalA 7bCYKN9XA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFliG-0007K0-VM; Wed, 02 Oct 2019 20:59:08 +0000 Received: from avon.wwwdotorg.org ([104.237.132.123]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFliD-0007IB-8n for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2019 20:59:06 +0000 Received: from [10.20.204.51] (unknown [216.228.112.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by avon.wwwdotorg.org (Postfix) with ESMTPSA id D9A9C1C00ED; Wed, 2 Oct 2019 14:59:03 -0600 (MDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.100.3 at avon.wwwdotorg.org Subject: Re: [PATCH 1/4] clk: tegra: Enable fuse clock on Tegra124 To: Thierry Reding References: <20191001211346.104400-1-swarren@wwwdotorg.org> <20191002110454.GJ3716706@ulmo> From: Stephen Warren Message-ID: <6a48d716-2312-4623-f47a-a53ac2ece83c@wwwdotorg.org> Date: Wed, 2 Oct 2019 14:59:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191002110454.GJ3716706@ulmo> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191002_135905_392766_3847D188 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Stephen Boyd , Peter De Schrijver , linux-clk@vger.kernel.org, Jonathan Hunter , linux-tegra@vger.kernel.org, Michael Turquette , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/2/19 5:04 AM, Thierry Reding wrote: > On Tue, Oct 01, 2019 at 03:13:43PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> For a little over a year, U-Boot has configured the flow controller to >> perform automatic RAM re-repair on off->on power transitions of the CPU >> rail1]. This is mandatory for correct operation of Tegra124. However, RAM >> re-repair relies on certain clocks, which the kernel must enable and >> leave running. The fuse clock is one of those clocks. Enable this clock >> so that LP1 power mode (system suspend) operates correctly. >> >> [1] 3cc7942a4ae5 ARM: tegra: implement RAM repair >> >> Reported-by: Jonathan Hunter >> Cc: stable@vger.kernel.org >> Signed-off-by: Stephen Warren >> --- >> drivers/clk/tegra/clk-tegra124.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c >> index 0224fdc4766f..f53f6315c646 100644 >> --- a/drivers/clk/tegra/clk-tegra124.c >> +++ b/drivers/clk/tegra/clk-tegra124.c >> @@ -1291,6 +1291,7 @@ static struct tegra_clk_init_table common_init_table[] __initdata = { >> }; >> >> static struct tegra_clk_init_table tegra124_init_table[] __initdata = { >> + { TEGRA124_CLK_FUSE, -1, 0, 1 }, > > I think the correct way to do this these days is to mark the clock as > CRITICAL. Not sure if there's an easy way to do that given that the > clock init table doesn't allow storing flags. > > Do you have any good ideas on how to achieve this with the critical flag > instead of forcing the refcount to 1? > > Perhaps something like the below would work? > ... The following works for me; does this seem like a reasonable approach? It does set the critical flag for all SoCs, including any that don't require RAM re-repair. I'm not sure which do; I know it's more than just Tegra124, but I'm not sure how far back/forward the requirement goes. > diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c > index 1ed85f120a1b..76dd91eebd13 100644 > --- a/drivers/clk/tegra/clk-tegra-periph.c > +++ b/drivers/clk/tegra/clk-tegra-periph.c > @@ -785,7 +785,7 @@ static struct tegra_periph_init_data gate_clks[] = { > GATE("ahbdma", "hclk", 33, 0, tegra_clk_ahbdma, 0), > GATE("apbdma", "pclk", 34, 0, tegra_clk_apbdma, 0), > GATE("kbc", "clk_32k", 36, TEGRA_PERIPH_ON_APB | TEGRA_PERIPH_NO_RESET, tegra_clk_kbc, 0), > - GATE("fuse", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse, 0), > + GATE("fuse", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse, CLK_IS_CRITICAL), > GATE("fuse_burn", "clk_m", 39, TEGRA_PERIPH_ON_APB, tegra_clk_fuse_burn, 0), > GATE("kfuse", "clk_m", 40, TEGRA_PERIPH_ON_APB, tegra_clk_kfuse, 0), > GATE("apbif", "clk_m", 107, TEGRA_PERIPH_ON_APB, tegra_clk_apbif, 0), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel