From: Peter Rosin <peda@axentia.se>
To: Michael Walle <michael@walle.cc>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
krzysztof.kozlowski+dt@linaro.org, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
kavyasree.kotagiri@microchip.com, Manohar.Puri@microchip.com,
lee.jones@linaro.org, claudiu.beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] mux: lan966: Add support for flexcom mux controller
Date: Tue, 17 May 2022 14:00:49 +0200 [thread overview]
Message-ID: <6a6b9fe4-d588-1150-5f83-d91c91be9924@axentia.se> (raw)
In-Reply-To: <20220517115327.4139280-1-michael@walle.cc>
2022-05-17 at 13:53, Michael Walle wrote:
> Hi,
>
>>> +struct mux_lan966x {
>>
>> Why is the file named lan966, but then everything inside lan966x?
>
> So I was about to reply to the bindings but since that question
> came up here, too, I'll do it here.
>
> IMHO the name "lan966" is super confusing and if I followed it
> correctly, it was just invented because the DT guys don't want to
> have a wildcard in the compatibles. But LAN966 isn't a real product,
> just LAN9662 and LAN9668 is.
No wonder I failed when I searched the web for "lan966"...
So, as you were told in the thread you point at below, you name
stuff after one of them (and not some random thing that doesn't
exist), but then handle both in the same file(s). Like you would
have if one was introduced first and the other came later.
Cheers,
Peter
>
> I'd really prefer to have a consistent naming. I've said it once
> [1], having "lan966" (over lan966x) feels like cheating and is even
> worse, because everyone would assume there is a thing named LAN966.
> lan966x might lead the reader to think twice what the 'x' means.
>
> So I'd prefer to have lan966x in the documentation and the drivers
> and just "microchip,lan9668" or "microchip,lan9662" in the
> compatibles.
>
> -michael
>
> [1] https://lore.kernel.org/linux-devicetree/d18291ff8d81f03a58900935d92115f2@walle.cc/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-17 12:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 8:49 [PATCH v2 0/4] Add support for lan966 flexcom multiplexer Kavyasree Kotagiri
2022-05-09 8:49 ` [PATCH v2 1/4] dt-bindings: mfd: atmel, flexcom: Convert to json-schema Kavyasree Kotagiri
2022-05-10 10:32 ` [PATCH v2 1/4] dt-bindings: mfd: atmel,flexcom: " Krzysztof Kozlowski
2022-05-09 8:49 ` [PATCH v2 2/4] dt-bindings: mfd: atmel, flexcom: Add lan966 compatible string and mux properties Kavyasree Kotagiri
2022-05-10 10:33 ` [PATCH v2 2/4] dt-bindings: mfd: atmel,flexcom: " Krzysztof Kozlowski
2022-05-09 8:49 ` [PATCH v2 3/4] dt-bindings: mux: Add lan966 flexcom mux controller Kavyasree Kotagiri
2022-05-10 10:37 ` Krzysztof Kozlowski
2022-05-09 8:49 ` [PATCH v2 4/4] mux: lan966: Add support for " Kavyasree Kotagiri
2022-05-09 11:37 ` Peter Rosin
2022-05-09 11:41 ` Peter Rosin
2022-05-10 14:59 ` Kavyasree.Kotagiri
2022-05-10 19:38 ` Peter Rosin
2022-05-11 14:28 ` Kavyasree.Kotagiri
2022-05-11 15:43 ` Peter Rosin
2022-05-27 6:00 ` Kavyasree.Kotagiri
2022-05-17 11:53 ` Michael Walle
2022-05-17 12:00 ` Peter Rosin [this message]
2022-05-10 1:46 ` kernel test robot
2022-05-10 3:28 ` kernel test robot
2022-05-11 9:06 ` Claudiu.Beznea
2022-05-23 14:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a6b9fe4-d588-1150-5f83-d91c91be9924@axentia.se \
--to=peda@axentia.se \
--cc=Manohar.Puri@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=kavyasree.kotagiri@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).