linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix kernel panic on serror exception caused by user process
Date: Tue, 17 Jul 2018 15:20:47 +0100	[thread overview]
Message-ID: <6ac1a5b0-6767-bb76-012e-b8270a580ca2@arm.com> (raw)
In-Reply-To: <CAM5rFu8avWLrUhEsCHBTKv=sM6dE3Sh_0=5M3Eh0WcT9EdmtSg@mail.gmail.com>

Hi hari,

On 17/07/18 14:40, Hari Vyas wrote:
> On Tue, Jul 17, 2018 at 5:18 PM, Mark Rutland <mark.rutland@arm.com> wrote:
>> ... indeed, and this was a bug, which was addressed by ensuring that
>> an uncontainable SError was always fatal.
>>
> If I check commit message for do_serror(), it says some hooks can be
> added to avoid panic.
> ---
> commit a92d4d1454ab8b43b80b89fa31fcedb8821f8164
> Author: Xie XiuQi <xiexiuqi@huawei.com>
> 
> Future patches may change do_serror() to return if the SError
> Interrupt was notification of a
> corrected error
>  --

This is referring to the v8.2 RAS Extensions, which add architect-ed ESR values
to SError. In this example the CPU would use the ESR_ELx.AET bits to describe
the error as something hardware has corrected. e.g. using ecc. (details in
D10.2.39 of the ARM-ARM and [0])
commit 6bf0dcfd7135 ("arm64: kernel: Survive corrected RAS errors notified by
SError") adds these hooks based on the ESR information.

Without the information in the ESR (and a few other registers), we can't know
what the SError means, it has to be fatal.


Thanks,

James

[0]
https://static.docs.arm.com/ddi0587/a/RAS%20Extension-release%20candidate_march_29.pdf

  reply	other threads:[~2018-07-17 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17  9:31 [PATCH] arm64: fix kernel panic on serror caused by user process Hari Vyas
2018-07-17  9:31 ` [PATCH] arm64: fix kernel panic on serror exception " Hari Vyas
2018-07-17 10:06   ` Mark Rutland
2018-07-17 11:32     ` Hari Vyas
2018-07-17 11:48       ` Mark Rutland
2018-07-17 13:40         ` Hari Vyas
2018-07-17 14:20           ` James Morse [this message]
2018-07-17 14:26           ` Robin Murphy
2018-07-17 14:45           ` Russell King - ARM Linux
2018-07-18  9:14             ` Hari Vyas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ac1a5b0-6767-bb76-012e-b8270a580ca2@arm.com \
    --to=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).