From: Julien Thierry <julien.thierry@arm.com>
To: Torsten Duwe <duwe@lst.de>, Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@arm.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6] arm64: implement ftrace with regs
Date: Wed, 16 Jan 2019 10:08:38 +0000 [thread overview]
Message-ID: <6ac63f70-d9a4-6b56-ed59-fc18873d8293@arm.com> (raw)
In-Reply-To: <8eb70db4-92a2-95a2-075c-f26690aab3ed@arm.com>
On 16/01/2019 09:57, Julien Thierry wrote:
> Hi Torsten,
>
> On 04/01/2019 14:10, Torsten Duwe wrote:
>> Use -fpatchable-function-entry (gcc8) to add 2 NOPs at the beginning
>> of each function. Replace the first NOP thus generated with a quick LR
>> saver (move it to scratch reg x9), so the 2nd replacement insn, the call
>> to ftrace, does not clobber the value. Ftrace will then generate the
>> standard stack frames.
>>
>> Note that patchable-function-entry in GCC disables IPA-RA, which means
>> ABI register calling conventions are obeyed *and* scratch registers
>> such as x9 are available.
>>
>> Introduce and handle an ftrace_regs_trampoline for module PLTs, right
>> after ftrace_trampoline, and double the size of this special section.
>>
>> Signed-off-by: Torsten Duwe <duwe@suse.de>
>>
>
> I wanted to test this patch (and try to benchmark having the "mov x9,
> x30" always present in function prelude vs having two nops), but I
> cannot get this patch to apply (despite having a version including both
> commits below).
>
> Could you provide a git branch from which I could try to rebase the
> patch? (Or a new version of the series)
>
>> ---
>>
>> This patch applies on 4.20 with the additional changes
>> bdb85cd1d20669dfae813555dddb745ad09323ba
>> (arm64/module: switch to ADRP/ADD sequences for PLT entries)
>> and
>> 7dc48bf96aa0fc8aa5b38cc3e5c36ac03171e680
>> (arm64: ftrace: always pass instrumented pc in x0)
>> along with their respective series, or alternatively on Linus' master,
>> which already has these.
>>
>> changes since v5:
>>
>> * fix mentioned pc in x0 to hold the start address of the call site,
>> not the return address or the branch address.
>> This resolves the problem found by Amit.
>>
>> ---
>> arch/arm64/Kconfig | 2
>> arch/arm64/Makefile | 4 +
>> arch/arm64/include/asm/assembler.h | 1
>> arch/arm64/include/asm/ftrace.h | 13 +++
>> arch/arm64/include/asm/module.h | 3
>> arch/arm64/kernel/Makefile | 6 -
>> arch/arm64/kernel/entry-ftrace.S | 131 ++++++++++++++++++++++++++++++++++
>> arch/arm64/kernel/ftrace.c | 125 ++++++++++++++++++++++++--------
>> arch/arm64/kernel/module-plts.c | 3
>> arch/arm64/kernel/module.c | 2
>> drivers/firmware/efi/libstub/Makefile | 3
>> include/asm-generic/vmlinux.lds.h | 1
>> include/linux/compiler_types.h | 4 +
>> 13 files changed, 262 insertions(+), 36 deletions(-)
>
> [...]
>
>> --- a/arch/arm64/kernel/entry-ftrace.S
>> +++ b/arch/arm64/kernel/entry-ftrace.S
>
> [...]
>
>> @@ -122,6 +124,7 @@ skip_ftrace_call: // }
>> ENDPROC(_mcount)
>>
>> #else /* CONFIG_DYNAMIC_FTRACE */
>> +#ifndef CONFIG_DYNAMIC_FTRACE_WITH_REGS
>> /*
>> * _mcount() is used to build the kernel with -pg option, but all the branch
>> * instructions to _mcount() are replaced to NOP initially at kernel start up,
>> @@ -159,6 +162,124 @@ GLOBAL(ftrace_graph_call) // ftrace_gra
>>
>> mcount_exit
>> ENDPROC(ftrace_caller)
>> +#else /* CONFIG_DYNAMIC_FTRACE_WITH_REGS */
>> +
>> +/*
>> + * Since no -pg or similar compiler flag is used, there should really be
>> + * no reference to _mcount; so do not define one. Only some value for
>> + * MCOUNT_ADDR is needed for comparison. Let it point here to have some
>> + * sort of magic value that can be recognised when debugging.
>> + */
>> +GLOBAL(_mcount)
>> + ret /* make it differ from regs caller */
>
> There's something I can't figure out. Since there are no callers to
> _mcount, how does the ftrace core builds up its record of patchable
> functions?
>
> I don't understand fully the core ftrace code but I've got the
> impression that without this record of struct dyn_ftrace, ftrace cannot
> patch in calls to tracers in the future.
>
> Am I missing something?
>
Forget that second part, I just saw the vmlinux.lds.h change.
--
Julien Thierry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-16 10:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 14:10 [PATCH v6] arm64: implement ftrace with regs Torsten Duwe
2019-01-04 17:50 ` Mark Rutland
2019-01-04 18:06 ` Steven Rostedt
2019-01-04 22:41 ` Torsten Duwe
2019-01-05 11:05 ` Torsten Duwe
2019-01-05 20:00 ` Steven Rostedt
2019-01-07 11:19 ` Mark Rutland
2019-01-14 12:13 ` Balbir Singh
2019-01-14 12:26 ` Mark Rutland
2019-01-16 15:56 ` Julien Thierry
2019-01-16 18:01 ` Julien Thierry
2019-01-07 4:57 ` Amit Daniel Kachhap
2019-01-16 9:57 ` Julien Thierry
2019-01-16 10:08 ` Julien Thierry [this message]
2019-01-17 15:48 ` Torsten Duwe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac63f70-d9a4-6b56-ed59-fc18873d8293@arm.com \
--to=julien.thierry@arm.com \
--cc=amit.kachhap@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=duwe@lst.de \
--cc=jpoimboe@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).