From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org
Cc: alexander.shishkin@linux.intel.com, peterz@infradead.org,
coresight@lists.linaro.org, Mike.Leach@arm.com,
leo.yan@linaro.org
Subject: Re: [PATCH v2 04/16] coresight: Adding return code to sink::disable() operation
Date: Tue, 26 Mar 2019 14:55:51 +0000 [thread overview]
Message-ID: <6c49fb4c-3bf8-ec39-ba3a-c8431b361c87@arm.com> (raw)
In-Reply-To: <20190325215632.17013-5-mathieu.poirier@linaro.org>
On 03/25/2019 09:56 PM, Mathieu Poirier wrote:
> In preparation to handle device reference counting inside of the sink
> drivers, add a return code to the sink::disable() operation so that
> proper action can be taken if a sink has not been disabled.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This one and the next patch in the series, together fixes an issue
where we could leave the a sink still enabled, but with refcounts
dropped. (i.e, if we collide with someone reading the sink, while
trying to disable).
As such the issue has been lying around since the beginning, we don't
have to bother about fixing the issue in one single patch.
Thus,
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-26 14:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 21:56 [PATCH v2 00/16] coresight: Add support for CPU-wide trace scenarios Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 01/16] coresight: pmu: Adding ITRACE property to cs_etm PMU Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 02/16] coresight: etm4x: Add kernel configuration for CONTEXTID Mathieu Poirier
2019-03-26 11:59 ` Suzuki K Poulose
2019-03-25 21:56 ` [PATCH v2 03/16] coresight: etm4x: Configure tracers to emit timestamps Mathieu Poirier
2019-03-26 11:53 ` Suzuki K Poulose
2019-03-25 21:56 ` [PATCH v2 04/16] coresight: Adding return code to sink::disable() operation Mathieu Poirier
2019-03-26 14:55 ` Suzuki K Poulose [this message]
2019-03-25 21:56 ` [PATCH v2 05/16] coresight: Move reference counting inside sink drivers Mathieu Poirier
2019-03-26 15:04 ` Suzuki K Poulose
2019-03-25 21:56 ` [PATCH v2 06/16] coresight: Properly address errors in sink::disable() functions Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 07/16] coresight: Properly address concurrency in sink::update() functions Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 08/16] coresight: perf: Clean up function etm_setup_aux() Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 09/16] coresight: perf: Refactor function free_event_data() Mathieu Poirier
2019-03-26 15:07 ` Suzuki K Poulose
2019-03-25 21:56 ` [PATCH v2 10/16] coresight: Communicate perf event to sink buffer allocation function Mathieu Poirier
2019-03-26 15:12 ` Suzuki K Poulose
2019-03-25 21:56 ` [PATCH v2 11/16] coresight: tmc-etr: Refactor function tmc_etr_setup_perf_buf() Mathieu Poirier
2019-03-26 15:29 ` Suzuki K Poulose
2019-03-26 16:29 ` Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 12/16] coresight: tmc-etr: Introduce the notion of process ID to ETR devices Mathieu Poirier
2019-03-26 16:46 ` Suzuki K Poulose
2019-03-26 18:06 ` Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 13/16] coresight: tmc-etr: Allow events to use the same ETR buffer Mathieu Poirier
2019-03-26 16:18 ` Suzuki K Poulose
2019-03-26 17:55 ` Mathieu Poirier
2019-03-27 11:32 ` Suzuki K Poulose
2019-03-27 17:01 ` Mathieu Poirier
2019-04-01 13:01 ` Suzuki K Poulose
2019-04-03 2:13 ` Mathieu Poirier
2019-03-30 15:43 ` Leo Yan
2019-04-01 7:29 ` Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 14/16] coresight: tmc-etr: Add support for CPU-wide trace scenarios Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 15/16] coresight: tmc-etf: " Mathieu Poirier
2019-03-25 21:56 ` [PATCH v2 16/16] coresight: etb10: " Mathieu Poirier
2019-03-27 7:52 ` [PATCH v2 00/16] coresight: " Leo Yan
2019-03-27 14:40 ` Mathieu Poirier
2019-03-27 14:44 ` Leo Yan
2019-04-11 18:52 ` Robert Walker
2019-04-16 19:37 ` Mathieu Poirier
2019-04-24 16:22 ` Robert Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c49fb4c-3bf8-ec39-ba3a-c8431b361c87@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Mike.Leach@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).