From: Michal Simek <michal.simek@xilinx.com>
To: Olof Johansson <olof@lixom.net>, <linux-spi@vger.kernel.org>
Cc: Rajan Vaja <rajan.vaja@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jolly Shah <jollys@xilinx.com>
Subject: Re: [PATCH] spi: zynqmp: Fix build break
Date: Mon, 29 Apr 2019 09:28:13 -0700 [thread overview]
Message-ID: <6d31dc90-7d0a-fc8d-cbc3-331200a01755@xilinx.com> (raw)
In-Reply-To: <20190429162246.6061-1-olof@lixom.net>
On 29. 04. 19 9:22, Olof Johansson wrote:
> Missing include:
> drivers/spi/spi-zynqmp-gqspi.c:1025:13: error: implicit declaration of
> function 'zynqmp_pm_get_eemi_ops'; did you mean
> 'zynqmp_process_dma_irq'? [-Werror=implicit-function-declaration]
>
> Fixes: 3d0313786470a ('drivers: Defer probe if firmware is not ready')
> Cc: Rajan Vaja <rajan.vaja@xilinx.com>
> Cc: Jolly Shah <jollys@xilinx.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> drivers/spi/spi-zynqmp-gqspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
> index d07b6f940f9f..9850a0efe85a 100644
> --- a/drivers/spi/spi-zynqmp-gqspi.c
> +++ b/drivers/spi/spi-zynqmp-gqspi.c
> @@ -14,6 +14,7 @@
> #include <linux/delay.h>
> #include <linux/dma-mapping.h>
> #include <linux/dmaengine.h>
> +#include <linux/firmware/xlnx-zynqmp.h>
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-29 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 8:39 [GIT PULL] arm64: dts: Xilinx ZynqMP SoC changes for v5.2 Michal Simek
2019-04-29 6:07 ` Olof Johansson
2019-04-29 16:20 ` Olof Johansson
2019-04-29 16:22 ` [PATCH] spi: zynqmp: Fix build break Olof Johansson
2019-04-29 16:28 ` Michal Simek [this message]
2019-05-21 21:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d31dc90-7d0a-fc8d-cbc3-331200a01755@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rajan.vaja@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).