From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C220AC433ED for ; Mon, 26 Apr 2021 12:46:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E16C61263 for ; Mon, 26 Apr 2021 12:46:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E16C61263 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FPTC/byf9uXN6l/86Rvuf7VAsYEsDp2H5v+M+Cgn/pc=; b=Z7XGO010IkwDbOBz2aGdAXY4F KynHHFNdoYfGxkA2e9lbjrDiA9qZdOFMeoDvCadkOy79onfPKVWoMyV/d2kphno+nJi1hwZlf4De5 65Lpd4byCgJZcXAQdBxqn4oFCLOXJQrbbgolfYLGtcsoSHIRw02malBX+wfrKnoPMPq4gCQAq5eHA 2BwZPNlXwZRMaEtlzzgHKDFfiwy7wJgRGZ9XWII/Z7bV0kCgLb+vXyJdcyq7vFxcRhFwRz4NW3UgW UxWUq41aVXkZeOfV3uhU7P3WnLUNtEn3tQuknp41xy95Ilw5K78MkoIRD7eA1kByTQHH5ec8aqkUV wS+vVi48A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb0bF-007dha-C8; Mon, 26 Apr 2021 12:44:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb0bA-007dgU-4W for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 12:44:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619441050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSlotn4fBSdFFf3NHGJvYzieEsXBeHjCWbwR+pEgCSM=; b=fvGVwPCbB9cKx7a5DZ7UCHJTSueIrPx4SRqCSqzbLgtrjr53q7YfWo1xQRGnqzsMMKpmYq aZyyHHosoxXJjfCPq5V8BkIbKHdTAkGqhflW5dWszIm0G+fXWH3BT6fpeKzXvZ8SXBHfCN Nf68eunrAdEbRj5DjhWfMFd8QqyBR0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619441060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSlotn4fBSdFFf3NHGJvYzieEsXBeHjCWbwR+pEgCSM=; b=e0AV3nORAiLkDojQZyZwN7sCEG0Ao1phcnOFtuhD4g8lah/k0CdvPhwE0Qp4R40F5xDqh9 /g479xljtYa9JiO18sG3WFhVPepSz0KcZopnoV1m7bKLDsSFFWBfhZrkClsaaKE4qNEI5w m4Rv0N21nKFpSmWZtLhCZLjGIky8yY0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-W1_il_x5O0-KQwH5hQ0CVw-1; Mon, 26 Apr 2021 08:44:07 -0400 X-MC-Unique: W1_il_x5O0-KQwH5hQ0CVw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3BB3587A83F; Mon, 26 Apr 2021 12:44:03 +0000 (UTC) Received: from starship (unknown [10.40.192.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F70F6268B; Mon, 26 Apr 2021 12:43:49 +0000 (UTC) Message-ID: <6d7146021f3435330b42f2e1b917d4b5dea00edc.camel@redhat.com> Subject: Re: [PATCH v2 0/9] KVM: my debug patch queue From: Maxim Levitsky To: Paolo Bonzini , kvm@vger.kernel.org Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Ingo Molnar , Andrew Morton , Thomas Gleixner , Sean Christopherson , Marc Zyngier , Catalin Marinas , open list , Julien Thierry , Stefano Garzarella , Borislav Petkov , Suzuki K Poulose , Jonathan Corbet , Jessica Yu , "H. Peter Anvin" , Jan Kiszka , Will Deacon , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , Vitaly Kuznetsov , Vasily Gorbik , Joerg Roedel , Claudio Imbrenda , Jim Mattson , Cornelia Huck , David Hildenbrand , Wanpeng Li , Janosch Frank , Christian Borntraeger , "open list:S390" , Heiko Carstens , Kieran Bingham , "open list:DOCUMENTATION" , "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , James Morse Date: Mon, 26 Apr 2021 15:43:48 +0300 In-Reply-To: References: <20210401135451.1004564-1-mlevitsk@redhat.com> User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_134424_701677_808A6D0A X-CRM114-Status: GOOD ( 34.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-04-02 at 10:38 -0700, Paolo Bonzini wrote: > On 01/04/21 15:54, Maxim Levitsky wrote: > > Hi! > > > > I would like to publish two debug features which were needed for other stuff > > I work on. > > > > One is the reworked lx-symbols script which now actually works on at least > > gdb 9.1 (gdb 9.2 was reported to fail to load the debug symbols from the kernel > > for some reason, not related to this patch) and upstream qemu. > > Queued patches 2-5 for now. 6 is okay but it needs a selftest. (e.g. > using KVM_VCPU_SET_EVENTS) and the correct name for the constant. Do you mean to add a kvm-unit-test or to add a test to kernel's kvm unit tests for this? Best regards, Maxim Levitsky > > Paolo > > > The other feature is the ability to trap all guest exceptions (on SVM for now) > > and see them in kvmtrace prior to potential merge to double/triple fault. > > > > This can be very useful and I already had to manually patch KVM a few > > times for this. > > I will, once time permits, implement this feature on Intel as well. > > > > V2: > > > > * Some more refactoring and workarounds for lx-symbols script > > > > * added KVM_GUESTDBG_BLOCKEVENTS flag to enable 'block interrupts on > > single step' together with KVM_CAP_SET_GUEST_DEBUG2 capability > > to indicate which guest debug flags are supported. > > > > This is a replacement for unconditional block of interrupts on single > > step that was done in previous version of this patch set. > > Patches to qemu to use that feature will be sent soon. > > > > * Reworked the the 'intercept all exceptions for debug' feature according > > to the review feedback: > > > > - renamed the parameter that enables the feature and > > moved it to common kvm module. > > (only SVM part is currently implemented though) > > > > - disable the feature for SEV guests as was suggested during the review > > - made the vmexit table const again, as was suggested in the review as well. > > > > Best regards, > > Maxim Levitsky > > > > Maxim Levitsky (9): > > scripts/gdb: rework lx-symbols gdb script > > KVM: introduce KVM_CAP_SET_GUEST_DEBUG2 > > KVM: x86: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: aarch64: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: s390x: implement KVM_CAP_SET_GUEST_DEBUG2 > > KVM: x86: implement KVM_GUESTDBG_BLOCKEVENTS > > KVM: SVM: split svm_handle_invalid_exit > > KVM: x86: add force_intercept_exceptions_mask > > KVM: SVM: implement force_intercept_exceptions_mask > > > > Documentation/virt/kvm/api.rst | 4 + > > arch/arm64/include/asm/kvm_host.h | 4 + > > arch/arm64/kvm/arm.c | 2 + > > arch/arm64/kvm/guest.c | 5 - > > arch/s390/include/asm/kvm_host.h | 4 + > > arch/s390/kvm/kvm-s390.c | 3 + > > arch/x86/include/asm/kvm_host.h | 12 ++ > > arch/x86/include/uapi/asm/kvm.h | 1 + > > arch/x86/kvm/svm/svm.c | 87 +++++++++++-- > > arch/x86/kvm/svm/svm.h | 6 +- > > arch/x86/kvm/x86.c | 14 ++- > > arch/x86/kvm/x86.h | 2 + > > include/uapi/linux/kvm.h | 1 + > > kernel/module.c | 8 +- > > scripts/gdb/linux/symbols.py | 203 ++++++++++++++++++++---------- > > 15 files changed, 272 insertions(+), 84 deletions(-) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel