From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44225C433B4 for ; Sun, 25 Apr 2021 17:34:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F40E9611CC for ; Sun, 25 Apr 2021 17:34:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F40E9611CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RAK+sphem4BHIEgoKClCcbZqYEGZ/Xyg4Q6N+TeF6No=; b=MU3LmyUiPk4VYKPWNW9RRa5rt m3TU9bsShwC1Q4WGg0GgI7f2uXtyN3MB+OfJYrrfuOntIwNsRY9aLjNDATf4LKoVhC7fZx2ZcNeEH u01nTw1oICYwffVjW8yHM22/DIdqfpmIAgIVrtwSuZhnulD5IqxvzOnFO+Bmu1OS5wC2AklDUWVvj mA5ghm3wuNSw5e6UwQsZciGQR5UhuOwJQVWWVFdQMskh22wL4blJ7Fg7Fcl/si4QU9o9n6Yee5N4I vY5Ebk4JdgQZCBfQ5q5NasAgebuqFb8USc2AyA1QqUdhoDJTz3Gaynm6PZXdw1TFWCbSsmKHPrWGb twZzUhWQw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1laici-0060vG-Fu; Sun, 25 Apr 2021 17:32:48 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1laicf-0060v9-9U for linux-arm-kernel@desiato.infradead.org; Sun, 25 Apr 2021 17:32:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=voFwKrTTjjoyFJE6evMIYyhewsdMjPxL3p2swH7Uqb0=; b=LtSlhuaZiX7L9FFvjwUKDmATvG ghN3hT8T+DxHu3JGJ40h6ULLb4Sx+VQIFytp9Ezy5D3U734hIvaOhCauDnrYMrPW0xPXEevle1jeg U/OWE74IFVUB9+/7PWNPC01Dqzq45C/J03y96I7SGSiXEgVqHowYZixvbAANBSwGDvQ5WfOT+lJ7+ Uec8Mh41l525KKr3msY9vfYMLVdsiQNj49jzq96B/uQJU69WfE+WDRnfZ7C784/jT4+2JIlVJttj1 5sX6RxtDIrZtcXAs/16rlexZry10dzu1yQpIP+FRX864CUtBjAwwsZveGvxNm02EPfmNO/uEkhSum 59USWy3g==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1laibz-004Wfq-GF; Sun, 25 Apr 2021 17:32:07 +0000 Subject: Re: [PATCH] pinctrl: aspeed: Fix minor documentation error To: Souptick Joarder , andrew@aj.id.au, linus.walleij@linaro.org, joel@jms.id.au Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1619353584-8196-1-git-send-email-jrdr.linux@gmail.com> From: Randy Dunlap Message-ID: <6db04e41-3ee6-c569-34b2-83693b620362@infradead.org> Date: Sun, 25 Apr 2021 10:32:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <1619353584-8196-1-git-send-email-jrdr.linux@gmail.com> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/25/21 5:26 AM, Souptick Joarder wrote: > Kernel test robot throws below warning -> > > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c:2705: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:2614: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/pinctrl/aspeed/pinctrl-aspeed.c:111: warning: This comment > starts with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > drivers/pinctrl/aspeed/pinmux-aspeed.c:24: warning: This comment starts > with '/**', but isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst > > Fix minor documentation error. > > Reported-by: kernel test robot > Signed-off-by: Souptick Joarder > Cc: Randy Dunlap Reviewed-by: Randy Dunlap Thanks. > --- > drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 4 ++-- > drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 4 ++-- > drivers/pinctrl/aspeed/pinctrl-aspeed.c | 3 ++- > drivers/pinctrl/aspeed/pinmux-aspeed.c | 3 ++- > 4 files changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > index 996ebcb..4c0d266 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c > @@ -2702,8 +2702,8 @@ static int aspeed_g5_sig_expr_eval(struct aspeed_pinmux_data *ctx, > } > > /** > - * Configure a pin's signal by applying an expression's descriptor state for > - * all descriptors in the expression. > + * aspeed_g5_sig_expr_set() - Configure a pin's signal by applying an > + * expression's descriptor state for all descriptors in the expression. > * > * @ctx: The pinmux context > * @expr: The expression associated with the function whose signal is to be > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > index 5c1a109..eeab093 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c > @@ -2611,8 +2611,8 @@ > }; > > /** > - * Configure a pin's signal by applying an expression's descriptor state for > - * all descriptors in the expression. > + * aspeed_g6_sig_expr_set() - Configure a pin's signal by applying an > + * expression's descriptor state for all descriptors in the expression. > * > * @ctx: The pinmux context > * @expr: The expression associated with the function whose signal is to be > diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c > index 9c65d56..9bbfe5c 100644 > --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c > +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c > @@ -108,7 +108,8 @@ static int aspeed_sig_expr_disable(struct aspeed_pinmux_data *ctx, > } > > /** > - * Disable a signal on a pin by disabling all provided signal expressions. > + * aspeed_disable_sig() - Disable a signal on a pin by disabling all provided > + * signal expressions. > * > * @ctx: The pinmux context > * @exprs: The list of signal expressions (from a priority level on a pin) > diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c b/drivers/pinctrl/aspeed/pinmux-aspeed.c > index 57305ca..894e2ef 100644 > --- a/drivers/pinctrl/aspeed/pinmux-aspeed.c > +++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c > @@ -21,7 +21,8 @@ static inline void aspeed_sig_desc_print_val( > } > > /** > - * Query the enabled or disabled state of a signal descriptor > + * aspeed_sig_desc_eval() - Query the enabled or disabled state of a signal > + * descriptor. > * > * @desc: The signal descriptor of interest > * @enabled: True to query the enabled state, false to query disabled state > -- ~Randy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel