From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8965C433ED for ; Tue, 11 May 2021 20:07:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A1B8611BD for ; Tue, 11 May 2021 20:07:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A1B8611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ixisCMlBI9k0eQri3qtPvL7qA9sdO515gY/Mrh2wjhE=; b=oauyDGc+t1Mw1oQKDLcH9Wj86 bdNuO/y4eDlNkCNAkYH2blItWnayg5w9stpQrcT6hqoZmPr2GvZlaVmfkobyZygM11ciHi6oFlg7j Eh32DXrj9IDHY6DUsSQw6dPvgB9FjTlAnNtvZCzCgMx/uf+q9lX72BzugrmS0tcUoEmLwNGJSGWsR 1R/UYKWdJS2PA+KAA4b8DObe8o+cw3UwWsD6BWcu1oXJfU/Pm5+kbNjvsNrsOgtOmN+9Pr/e/53iW YvE1xKmX34Zyaxyx1BvTXnUqXWfanicBny/tE3KMoVyIjU4SxR6K/m0HMBgD3y90is1ypIPK+94uh kyn/TwtUQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgYch-001Ddm-PR; Tue, 11 May 2021 20:04:55 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgYcd-001DdZ-JL for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 20:04:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=DEEPjQuam6XEsGxutWLZa9wfx0V1gVZCc91bXwAsNWQ=; b=JW2LryE2vTjq7Df0Hj6z7wzJkA Rh263ZVRyUviVc7VCNWnJAEBddbF4JlGIYdTZNfIVeQG/ubEMKgzkCkMY0OfTq+h9ElMIQlavz2ys MQO00G5urOgmbSBGkAF8K9sZaAub0ulRDbSFGooRUJoU3MF7HIvkOU9uyMGQ1YDA//StYCMr6D/5E 7tMuFUa2jNB/ERQzSiNIj4LjVkXWd+2OxZB+1UA6cfzYJn47xoxBn/9xKhyBNtKrafJVTXEuaNbTb xTFakXPdV6IOfi8JL4kLtpOhDlIN0scgUjeL1Ffw1mOtJb8PmxrMbU2AdpJ11eFqsDCokuzFvs/A6 LzT5/QLA==; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgYca-009tIu-3B for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 20:04:50 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 1B3901F41760 Subject: Re: [PATCH] arm64: configs: remove redundant CONFIG_MTK_PMIC_WRAP To: Catalin Marinas , Luo Longjun Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sangyan@huawei.com, ningyu9@huawei.com, luchunhua@huawei.com, Matthias Brugger References: <20210507182410.10515-1-luolongjun@huawei.com> <20210511172020.GB21033@arm.com> From: Enric Balletbo i Serra Message-ID: <6ef5c7a0-3596-a67c-c99d-c8e0def8a96a@collabora.com> Date: Tue, 11 May 2021 22:04:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210511172020.GB21033@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_130448_323766_5C3A2C3E X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, Thanks for cc'ing me. On 11/5/21 19:20, Catalin Marinas wrote: > On Sat, May 08, 2021 at 02:24:10AM +0800, Luo Longjun wrote: >> When I compile kernel in ARM64, it produces the following output: >> >> *** Default configuration is based on 'defconfig' >> arch/arm64/configs/defconfig:1018:warning: override: reassigning to >> symbol MTK_PMIC_WRAP >> >> After checking defcofnig, I found two CONFIG_MTK_PMIC_WRAP options. >> >> Signed-off-by: Luo Longjun >> --- >> arch/arm64/configs/defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index 08c6f769df9a..9907a431db0d 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -491,7 +491,6 @@ CONFIG_SPI_S3C64XX=y >> CONFIG_SPI_SH_MSIOF=m >> CONFIG_SPI_SUN6I=y >> CONFIG_SPI_SPIDEV=m >> -CONFIG_MTK_PMIC_WRAP=m >> CONFIG_SPMI=y >> CONFIG_PINCTRL_SINGLE=y >> CONFIG_PINCTRL_MAX77620=y > > Adding Matthias and Enric. This change looks fine to me but I think it > should go in via the arm-soc tree. Commit 9fd5449e061e introduced the =m > option while commit fbbe38309d56 introduced the =y variant. > > You could add: > > Fixes: fbbe38309d56 ("arm64: defconfig: Allow mt8173-based boards to boot from usb") > I sent the same patch some time ago [1]. I agree, either land this patch or mine. In any case, Reviewed-by: Enric Balletbo i Serra Matthias is this something that should go through your tree? Thanks, Enric [1] https://lore.kernel.org/linux-arm-kernel/20210423075201.2616023-1-enric.balletbo@collabora.com/T/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel