Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@jms.id.au>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Jeffery <andrew@aj.id.au>, Tao Ren <taoren@fb.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org,
	linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 2/5] ARM: dts: aspeed: add I2C buffer mode support
Date: Wed, 9 Oct 2019 15:32:40 +0200
Message-ID: <6f015065-3a45-878d-86b2-0edf10f1f4cb@kaod.org> (raw)
In-Reply-To: <20191007231313.4700-3-jae.hyun.yoo@linux.intel.com>

On 08/10/2019 01:13, Jae Hyun Yoo wrote:
> Byte mode currently this driver uses makes lots of interrupt call
> which isn't good for performance and it makes the driver very
> timing sensitive. To improve performance of the driver, this commit
> adds buffer mode transfer support which uses I2C SRAM buffer
> instead of using a single byte buffer.
> 
> AST2400:
> It has 2 KBytes (256 Bytes x 8 pages) of I2C SRAM buffer pool from
> 0x1e78a800 to 0x1e78afff that can be used for all busses with
> buffer pool manipulation. To simplify implementation for supporting
> both AST2400 and AST2500, it assigns each 128 Bytes per bus without
> using buffer pool manipulation so total 1792 Bytes of I2C SRAM
> buffer will be used.
> 
> AST2500:
> It has 16 Bytes of individual I2C SRAM buffer per each bus and its
> range is from 0x1e78a200 to 0x1e78a2df, so it doesn't have 'buffer
> page selection' bit field in the Function control register, and
> neither 'base address pointer' bit field in the Pool buffer control
> register it has. To simplify implementation for supporting both
> AST2400 and AST2500, it writes zeros on those register bit fields
> but it's okay because it does nothing in AST2500.
> 
> This commit fixes all I2C bus nodes to support buffer mode
> transfer.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 47 +++++++++++++++++++-------------
>  arch/arm/boot/dts/aspeed-g5.dtsi | 47 +++++++++++++++++++-------------
>  2 files changed, 56 insertions(+), 38 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index dffb595d30e4..f51b016aa769 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -420,12 +420,21 @@
>  };
>  
>  &i2c {
> -	i2c_ic: interrupt-controller@0 {
> -		#interrupt-cells = <1>;
> -		compatible = "aspeed,ast2400-i2c-ic";
> +	i2c_gr: i2c-global-regs@0 {
> +		compatible = "aspeed,ast2400-i2c-gr", "syscon";
>  		reg = <0x0 0x40>;
> -		interrupts = <12>;
> -		interrupt-controller;
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x0 0x0 0x40>;
> +
> +		i2c_ic: interrupt-controller@0 {
> +			#interrupt-cells = <1>;
> +			compatible = "aspeed,ast2400-i2c-ic";
> +			reg = <0x0 0x4>;
> +			interrupts = <12>;
> +			interrupt-controller;
> +		};
>  	};
>  
>  	i2c0: i2c-bus@40 {
> @@ -433,7 +442,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x40 0x40>;
> +		reg = <0x40 0x40>, <0x800 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -449,7 +458,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x80 0x40>;
> +		reg = <0x80 0x40>, <0x880 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -465,7 +474,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0xc0 0x40>;
> +		reg = <0xc0 0x40>, <0x900 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -482,7 +491,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x100 0x40>;
> +		reg = <0x100 0x40>, <0x980 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -499,7 +508,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x140 0x40>;
> +		reg = <0x140 0x40>, <0xa00 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -516,7 +525,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x180 0x40>;
> +		reg = <0x180 0x40>, <0xa80 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -533,7 +542,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x1c0 0x40>;
> +		reg = <0x1c0 0x40>, <0xb00 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -550,7 +559,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x300 0x40>;
> +		reg = <0x300 0x40>, <0xb80 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -567,7 +576,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x340 0x40>;
> +		reg = <0x340 0x40>, <0xc00 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -584,7 +593,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x380 0x40>;
> +		reg = <0x380 0x40>, <0xc80 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -601,7 +610,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x3c0 0x40>;
> +		reg = <0x3c0 0x40>, <0xd00 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -618,7 +627,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x400 0x40>;
> +		reg = <0x400 0x40>, <0xd80 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -635,7 +644,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x440 0x40>;
> +		reg = <0x440 0x40>, <0xe00 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -652,7 +661,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x480 0x40>;
> +		reg = <0x480 0x40>, <0xe80 0x80>;
>  		compatible = "aspeed,ast2400-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index e8feb8b66a2f..cbc31ce3fab2 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -513,12 +513,21 @@
>  };
>  
>  &i2c {
> -	i2c_ic: interrupt-controller@0 {
> -		#interrupt-cells = <1>;
> -		compatible = "aspeed,ast2500-i2c-ic";
> +	i2c_gr: i2c-global-regs@0 {
> +		compatible = "aspeed,ast2500-i2c-gr", "syscon";
>  		reg = <0x0 0x40>;
> -		interrupts = <12>;
> -		interrupt-controller;
> +
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x0 0x0 0x40>;
> +
> +		i2c_ic: interrupt-controller@0 {
> +			#interrupt-cells = <1>;
> +			compatible = "aspeed,ast2500-i2c-ic";
> +			reg = <0x0 0x4>;
> +			interrupts = <12>;
> +			interrupt-controller;
> +		};
>  	};
>  
>  	i2c0: i2c-bus@40 {
> @@ -526,7 +535,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x40 0x40>;
> +		reg = <0x40 0x40>, <0x200 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -542,7 +551,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x80 0x40>;
> +		reg = <0x80 0x40>, <0x210 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -558,7 +567,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0xc0 0x40>;
> +		reg = <0xc0 0x40>, <0x220 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -575,7 +584,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x100 0x40>;
> +		reg = <0x100 0x40>, <0x230 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -592,7 +601,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x140 0x40>;
> +		reg = <0x140 0x40>, <0x240 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -609,7 +618,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x180 0x40>;
> +		reg = <0x180 0x40>, <0x250 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -626,7 +635,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x1c0 0x40>;
> +		reg = <0x1c0 0x40>, <0x260 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -643,7 +652,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x300 0x40>;
> +		reg = <0x300 0x40>, <0x270 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -660,7 +669,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x340 0x40>;
> +		reg = <0x340 0x40>, <0x280 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -677,7 +686,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x380 0x40>;
> +		reg = <0x380 0x40>, <0x290 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -694,7 +703,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x3c0 0x40>;
> +		reg = <0x3c0 0x40>, <0x2a0 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -711,7 +720,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x400 0x40>;
> +		reg = <0x400 0x40>, <0x2b0 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -728,7 +737,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x440 0x40>;
> +		reg = <0x440 0x40>, <0x2c0 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> @@ -745,7 +754,7 @@
>  		#size-cells = <0>;
>  		#interrupt-cells = <1>;
>  
> -		reg = <0x480 0x40>;
> +		reg = <0x480 0x40>, <0x2d0 0x10>;
>  		compatible = "aspeed,ast2500-i2c-bus";
>  		clocks = <&syscon ASPEED_CLK_APB>;
>  		resets = <&syscon ASPEED_RESET_I2C>;
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 23:13 [PATCH 0/5] i2c: aspeed: Add buffer and DMA modes support Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 1/5] dt-bindings: i2c: aspeed: add buffer and DMA mode transfer support Jae Hyun Yoo
2019-10-08 18:12   ` Brendan Higgins
2019-10-08 18:47     ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 2/5] ARM: dts: aspeed: add I2C buffer mode support Jae Hyun Yoo
2019-10-09 13:32   ` Cédric Le Goater [this message]
2019-10-07 23:13 ` [PATCH 3/5] i2c: aspeed: fix master pending state handling Jae Hyun Yoo
2019-10-08 20:31   ` Brendan Higgins
2019-10-08 21:13     ` Jae Hyun Yoo
2019-10-08 21:54       ` Brendan Higgins
2019-10-08 22:55         ` Jae Hyun Yoo
2019-10-10  5:28         ` Joel Stanley
2019-10-08 22:00   ` Tao Ren
2019-10-08 22:45     ` Jae Hyun Yoo
2019-10-08 23:15       ` Tao Ren
2019-10-08 23:28         ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 4/5] i2c: aspeed: add buffer mode transfer support Jae Hyun Yoo
2019-10-08 20:12   ` Brendan Higgins
2019-10-08 21:10     ` Jae Hyun Yoo
2019-10-08 23:15       ` Brendan Higgins
2019-10-09  0:08         ` Jae Hyun Yoo
2019-10-07 23:13 ` [PATCH 5/5] i2c: aspeed: add DMA " Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f015065-3a45-878d-86b2-0edf10f1f4cb@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=brendanhiggins@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jae.hyun.yoo@linux.intel.com \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=taoren@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git