From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94AD7C433FF for ; Thu, 8 Aug 2019 13:01:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 671652171F for ; Thu, 8 Aug 2019 13:01:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mkshf82A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 671652171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=+Jy5gB2VyPcs4ir/aRljHwtUkbynWBDlSoGtpwM3Eq4=; b=mkshf82AiA0xZr/3wC4dUmTovg XOcupW8C8f+pASxL9aXwn5YPIwifxg7me5Di2vEq6i5/pN5Yle7kzX/6aHaVkz4kvKL30alzt8+Sk UztX7FnrlrwSyb9g8VmJPjKMtuW9iGxjXLpD8qthb5UkhALGKtKz9HeC/0YdrzQLVcM9pHwIPo2fg mS8TLGmOMpTX2HuVU0xfWWsentmqqOkwxgCjduxVkPGmXi8/zLtekhsT4Xu0ocAYmiUVghdPAEHo5 Rov06gh/0hIOud3I4bqMTR9u5fnGm+DLesr/xZpBnMnG5SO7BDV8YgIzYgoqvLSasutWpGEKudUAK 2tx/qYiQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvi2y-0007fa-Vo; Thu, 08 Aug 2019 13:01:37 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvi2v-0007fC-VU for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 13:01:35 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 06:01:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="182586432" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.122]) ([10.237.72.122]) by FMSMGA003.fm.intel.com with ESMTP; 08 Aug 2019 06:01:30 -0700 Subject: Re: [PATCH 1/2] mmc: sdhci-of-at91: add quirk for broken HS200 To: Eugen.Hristev@microchip.com, Nicolas.Ferre@microchip.com, Ludovic.Desroches@microchip.com, alexandre.belloni@bootlin.com, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: <1565252928-28994-1-git-send-email-eugen.hristev@microchip.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <6f08715f-b0e5-715c-006a-d80c0ecf2cd7@intel.com> Date: Thu, 8 Aug 2019 16:00:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1565252928-28994-1-git-send-email-eugen.hristev@microchip.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_060134_021358_216600F4 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/08/19 11:35 AM, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > HS200 is not implemented in the driver, but the controller claims it > through caps. > Remove it via quirk. > Without this quirk, the mmc core will try to enable hs200, which will fail, > and the eMMC initialization will fail. > > Signed-off-by: Eugen Hristev Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-of-at91.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index 57fe3b2..3a8c6d8 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -370,6 +370,9 @@ static int sdhci_at91_probe(struct platform_device *pdev) > pm_runtime_set_autosuspend_delay(&pdev->dev, 50); > pm_runtime_use_autosuspend(&pdev->dev); > > + /* HS200 is broken at this moment */ > + host->quirks2 = SDHCI_QUIRK2_BROKEN_HS200; > + > ret = sdhci_add_host(host); > if (ret) > goto pm_runtime_disable; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel