From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6408C54EE9 for ; Tue, 27 Sep 2022 13:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d+FjXLyU+BkzEFpkn6yxd6s8bQ2Fjz+2TaKk0ArCJYg=; b=1xnp+8yceIh/fG csJNQqMC3dXtAUpf70DR0Y7UBJvFh1bTG0xMYQm1gfmSCKuVyFQdjcufU/+Hn1kCglZoKP7dzjBlH Tv24xwmrIeBxkCxD8whb7vpUJGMEg4uR+YyiZQyLlihyyUXXur7vwO4FeDhNFpTHy3x9CvAs6dL6y MlpVsg/ikHFbUOiLLl3yD4Eoz6MHYj0daPYDkBd41x+2V+Sf40IcXTvAciW2GqJymE3q1GF2KmVm4 jNt6BkWGZ7BWZ6rrLzMgy6dZvmHpm/bzFKRfrp0rbXm3JDLsCWpKXyHQwXgiOn1f+H1B7XFaYLsZt /3svhcwEkcMszOlhCOQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odApU-00AzMA-Pk; Tue, 27 Sep 2022 13:40:57 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odApL-00AzJR-VA; Tue, 27 Sep 2022 13:40:49 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D23086602265; Tue, 27 Sep 2022 14:40:44 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664286045; bh=l0r0ZaX9YZdqDz2RvEUsZ5NEBzsjJi9GrROUQaXEGsQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PJE93JHEO7cWrmml9ztx3rkOfFWah/FwdZGzTfwUIQ2w7hQSt++Kt8QMso/okg+gJ bU35vtHR0wFh8Lni+XwK8+VKqwEelaZex29NnvukvV3iTYn0XzguZq/v4LTKhyINVv mQhq041uL42occFBaGzGJCm/sVnRhFmudSliD1DF0k0kig/AbPS6+3YZ5VE6iPdFO8 Msy4Fn8M2FAaAFa/lEV/aTzwJAPPwhDqfCDYoCsRE7i9HlDR96yiUSAvIpH4CqqDI4 4/xqVfOI0tHIgLreg0030IY4Em5y5iSM4KrBL19bylYxu4kLPNPGyhgh/shBIvP9YF mT4XwODwKfkZg== Message-ID: <6f1deed3-87e5-6d73-74b7-f5123c7f4362@collabora.com> Date: Tue, 27 Sep 2022 15:40:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 3/5] arm64: dts: mt8186: Add IOMMU and SMI nodes Content-Language: en-US To: Allen-KH Cheng , Lee Jones , Matthias Brugger , Rob Herring , Krzysztof Kozlowski Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org References: <20220923131148.6678-1-allen-kh.cheng@mediatek.com> <20220923131148.6678-4-allen-kh.cheng@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220923131148.6678-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_064048_258191_F2EE3273 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 23/09/22 15:11, Allen-KH Cheng ha scritto: > Add iommu and smi nodes for mt8186 SoC. > > Signed-off-by: Allen-KH Cheng > --- > arch/arm64/boot/dts/mediatek/mt8186.dtsi | 173 +++++++++++++++++++++++ > 1 file changed, 173 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8186.dtsi b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > index 833e7037fe22..68f06bef88f3 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8186.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8186.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -944,24 +945,113 @@ > #reset-cells = <1>; > }; > > + smi_common: smi@14002000 { > + compatible = "mediatek,mt8186-smi-common"; > + reg = <0 0x14002000 0 0x1000>; > + clocks = <&mmsys CLK_MM_SMI_COMMON>, <&mmsys CLK_MM_SMI_COMMON>, > + <&mmsys CLK_MM_SMI_GALS>, <&mmsys CLK_MM_SMI_GALS>; > + clock-names = "apb", "smi", "gals0", "gals1"; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + larb0: smi@14003000 { > + compatible = "mediatek,mt8186-smi-larb"; > + reg = <0 0x14003000 0 0x1000>; > + mediatek,larb-id = <0>; > + mediatek,smi = <&smi_common>; Order by name after reg please... compatible reg clocks clock-names mediatek,larb-id mediatek,smi power-domains > + clocks = <&mmsys CLK_MM_SMI_COMMON>, > + <&mmsys CLK_MM_SMI_COMMON>; > + clock-names = "apb", "smi"; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + larb1: smi@14004000 { > + compatible = "mediatek,mt8186-smi-larb"; > + reg = <0 0x14004000 0 0x1000>; > + mediatek,larb-id = <1>; > + mediatek,smi = <&smi_common>; > + clocks = <&mmsys CLK_MM_SMI_COMMON>, > + <&mmsys CLK_MM_SMI_COMMON>; > + clock-names = "apb", "smi"; > + power-domains = <&spm MT8186_POWER_DOMAIN_DIS>; > + }; > + > + iommu_mm: iommu@14016000 { > + compatible = "mediatek,mt8186-iommu-mm"; > + reg = <0 0x14016000 0 0x1000>; > + mediatek,larbs = <&larb0 &larb1 &larb2 &larb4 > + &larb7 &larb8 &larb9 &larb11 > + &larb13 &larb14 &larb16 &larb17 > + &larb19 &larb20>; > + interrupts = ; > + clocks = <&mmsys CLK_MM_SMI_IOMMU>; > + clock-names = "bclk"; clocks clock-names interrupts mediatek,larbs power-domains ...etc :-) P.S.: Same comment for the other commits, too! Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel