From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C24C4338F for ; Thu, 29 Jul 2021 19:23:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19E1460462 for ; Thu, 29 Jul 2021 19:23:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19E1460462 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:References:To:From:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tmFgI25X3Cl8YCTeYOMRquEIvc9Ghvs7yaH4Iu9zkYY=; b=4c9whgBqqVnkhuDwlrwO6yvm5n 9FY5XRamW8KFHYx3ACL7FXAkjx7+DJsUARYSAehL1/NTubh8cPiNiP0MAcuP42eHU+As7bx4eRdhB 9B3NDkeZFdv1so+7enwBCDLwmJx9ftsdzGgmVRrkCEtH78w1EgAguuMD6v2Qtm5e3Dhj7a5wmItGm uxGq5EaZ30M1noXACIwdv/yLgq6xLgTx/radn4e1l+qEuODq9zqR5GhwIe8k372OJUlU0m+NRaUhA IbtjTwX9oqZED3TrJfktWq5F84Zqp8nfRwsWtCzSV0LJqB/WgcJV7m4kDE3LvBl6fpr/maSIJYP9R gYU/s8YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Bas-005e71-6V; Thu, 29 Jul 2021 19:21:22 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Bao-005e6G-KW for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 19:21:20 +0000 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B9B812237F; Thu, 29 Jul 2021 19:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627586476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRjk3sSKAJ0GgQWrqGFQs/HiARPC+bYALbL6EW5s828=; b=abvpwR45Pw3eB3L9AnfN13GV+kP6qZqF4HcwqVRKTaYMOjq0qhbL+v4SrOl4R0CXOVk3GP V7ktKxC9z3/lAUK3zYWjgFYUEHQGEc5Hgexs0mIPi5wZZ+/JdSTasMtlahwZtO55Oq2T5X Gk4r4Vm/YArb0WT6nYo1s0CoC6tcChA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627586476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FRjk3sSKAJ0GgQWrqGFQs/HiARPC+bYALbL6EW5s828=; b=JqrrnwHS8m+K3Una3aJD38FjuLZZm6/jRuHqtiq5R0tjFkq9z/oWnwFhOQYR/m/tnS0OT9 wucaFv5W32ELPvDw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8488E13756; Thu, 29 Jul 2021 19:21:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Nf6rF6v/AmEHaQAAGKfGzw (envelope-from ); Thu, 29 Jul 2021 19:21:15 +0000 Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces From: Thomas Zimmermann To: Sam Ravnborg , Dan.Sneddon@microchip.com References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> Message-ID: <7067cca1-c8a4-347c-829a-accdce8c6aef@suse.de> Date: Thu, 29 Jul 2021 21:21:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_122119_017141_F3E8C919 X-CRM114-Status: GOOD ( 18.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, liviu.dudau@arm.com, stefan@agner.ch, amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com, patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, daniel@ffwll.ch, edmund.j.dea@intel.com, s.hauer@pengutronix.de, alison.wang@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, sean@poorly.run, linux-arm-kernel@lists.infradead.org, tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi, christian.koenig@amd.com, robdclark@gmail.com, kernel@pengutronix.de, alexander.deucher@amd.com, shawnguo@kernel.org, brian.starkey@arm.com Content-Type: multipart/mixed; boundary="===============8596660822835548295==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8596660822835548295== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0E3gTnkoECLDq8FuUqBM1dW3HzVnSTQZs" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0E3gTnkoECLDq8FuUqBM1dW3HzVnSTQZs Content-Type: multipart/mixed; boundary="oZfHGEJSgs3vHDPPh2hmpB1WlR5eRU4HT"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , Dan.Sneddon@microchip.com Cc: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, bbrezillon@kernel.org, Nicolas.Ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Message-ID: <7067cca1-c8a4-347c-829a-accdce8c6aef@suse.de> Subject: Re: [PATCH 03/14] drm/atmel-hlcdc: Convert to Linux IRQ interfaces References: <20210727182721.17981-4-tzimmermann@suse.de> <3d2f6b84-dd07-d925-a8b8-2bfd5fc736d9@microchip.com> <2f04b986-6b41-62f9-1587-23818b841655@suse.de> <793514f6-0270-771b-fe36-f82edf4e5fd2@microchip.com> <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> In-Reply-To: <1df22406-2e91-c15a-49dc-1cf33522a142@suse.de> --oZfHGEJSgs3vHDPPh2hmpB1WlR5eRU4HT Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 29.07.21 um 21:18 schrieb Thomas Zimmermann: > Hi >=20 > Am 28.07.21 um 22:11 schrieb Sam Ravnborg: >> Hi Dan, >> >>>> >>>> I think I got it - we need to set irq_enabled to true. >>>> The documentation says so: >>>> " >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * @irq_= enabled: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Indic= ates that interrupt handling is enabled,=20 >>>> specifically vblank >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * handl= ing. Drivers which don't use drm_irq_install()=20 >>>> need to set this >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * to tr= ue manually. >>>> " >>>> >>>> Can you try to add the following line: >>>> >>>> >>>> +static int atmel_hlcdc_dc_irq_install(struct drm_device *dev,=20 >>>> unsigned int irq) >>>> +{ >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret; >>>> + >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (irq =3D=3D IRQ_NOTCONNECTE= D) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return -ENOTCONN; >>>> + >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev->irq_enab= led =3D true;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <=3D THIS LINE >>>> >>>> >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 atmel_hlcdc_dc_irq_disable(dev= ); >>>> + >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ret =3D request_irq(irq, atmel= _hlcdc_dc_irq_handler, 0,=20 >>>> dev->driver->name, dev); >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (ret) >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return ret; >>>> >>>> I hope this fixes it. >>> >>> It does!=C2=A0 With the irq_enabled line added everything is looking = good. >=20 > Are you sure, you're testing with the latest drm-misc-next or drm-tip? = > Because using irq_enabled is deprecated and the flag was recently=20 > replaced by commit 1e4cd78ed493 ("drm: Don't test for IRQ support in=20 > VBLANK ioctls"). For reference, the cover letter lists base-commit: 2bda1ca4d4acb4892556fec3a7ea1f02afcd40bb which is a recent drm-tip created on July 25. Best regards Thomas >=20 > Best regards > Thomas >=20 >> >> Great, thanks for testing. >> >> Thomas - I assume you will do a re-spin and there is likely some fixes= >> for the applied IRQ conversions too. >> >> Note - irq_enabled must be cleared if request_irq fails. I did not >> include this in the testing here. >> >> =C2=A0=C2=A0=C2=A0=C2=A0Sam >> >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --oZfHGEJSgs3vHDPPh2hmpB1WlR5eRU4HT-- --0E3gTnkoECLDq8FuUqBM1dW3HzVnSTQZs Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmEC/6oFAwAAAAAACgkQlh/E3EQov+DP WBAAhN1PPONpW2TVKis0ZvNuMhTlUsp7foKn/2COaGdiypjUneDQNoByIvPFGGvBOMxwn02KjtVY pT+YMgH0d6vr0H6g7VZNXZW1683cUhrqNoX+wDISa4/In+2MsDeUf1jgPUPOKD8rKrOaAMsHNVhL CVjPhTLk/2JTHLG1m81AhW2I1UNxaaSmFF/VTs75mEJ3vBc7VIk129VSde0lkt0GrQjNsQFumbRp uX6Gp5h1mFRS6zTAW/lP4KA8KFsJrOzFFmErGbRPsZyWIgAkV4uc/9DIdkax6nMV6C7V1bCpLM2G wMIs4jUR4+2iUmw/AFcuKMEXsIOTlOm7BnjunOpHwjXMREP4lvCDPAPhq2DOmLxhVlUMqjJWBKXF GJD0VVAyAnBoNClL3MQFD7RpG8/vTgcZiyPvmJUhu1blIq/j7bWQQScWeQjuB0ztdliSMjGGK6Zm Lh1mMnWxB0MusFV1uzQcNMcauKJZ72tghNZ6pjbUV3aEA6FUDy6Ug5XifNCNdNPxae+XwQR1t2dK L1gUFsHNuaBP2T3mN+jtS6Jkh5gJEjUhdRMeU+nu6j7jH+G7DJlBUmkIvzRi+PCK6a82xoWJDI0w YsJGVemBE3duYxKpIJ5700mHX9YVXmq88tTUb7wboYQPjVQIhEi68Cwve1coyitFoRWoeECzJARL pIc= =36fU -----END PGP SIGNATURE----- --0E3gTnkoECLDq8FuUqBM1dW3HzVnSTQZs-- --===============8596660822835548295== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8596660822835548295==--