From: Florian Fainelli <f.fainelli@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Mark Brown <broonie@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
kernelci-results@groups.io, bot@kernelci.org,
gtucker@collabora.com, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hw_random: bcm2835: use hwrng_msleep() instead of cpu_relax()
Date: Mon, 10 Oct 2022 15:05:26 -0700 [thread overview]
Message-ID: <70991b49-fb31-d220-44a6-5ab6741c8fea@gmail.com> (raw)
In-Reply-To: <20221010150607.720600-1-Jason@zx2c4.com>
On 10/10/22 08:06, 'Jason A. Donenfeld' via BCM-KERNEL-FEEDBACK-LIST,PDL
wrote:
> Rather than busy looping, yield back to the scheduler and sleep for a
> bit in the event that there's no data. This should hopefully prevent the
> stalls that Mark reported:
>
> <6>[ 3.362859] Freeing initrd memory: 16196K
> <3>[ 23.160131] rcu: INFO: rcu_sched self-detected stall on CPU
> <3>[ 23.166057] rcu: 0-....: (2099 ticks this GP) idle=03b4/1/0x40000002 softirq=28/28 fqs=1050
> <4>[ 23.174895] (t=2101 jiffies g=-1147 q=2353 ncpus=4)
> <4>[ 23.180203] CPU: 0 PID: 49 Comm: hwrng Not tainted 6.0.0 #1
> <4>[ 23.186125] Hardware name: BCM2835
> <4>[ 23.189837] PC is at bcm2835_rng_read+0x30/0x6c
> <4>[ 23.194709] LR is at hwrng_fillfn+0x71/0xf4
> <4>[ 23.199218] pc : [<c07ccdc8>] lr : [<c07cb841>] psr: 40000033
> <4>[ 23.205840] sp : f093df70 ip : 00000000 fp : 00000000
> <4>[ 23.211404] r10: c3c7e800 r9 : 00000000 r8 : c17e6b20
> <4>[ 23.216968] r7 : c17e6b64 r6 : c18b0a74 r5 : c07ccd99 r4 : c3f171c0
> <4>[ 23.223855] r3 : 000fffff r2 : 00000040 r1 : c3c7e800 r0 : c3f171c0
> <4>[ 23.230743] Flags: nZcv IRQs on FIQs on Mode SVC_32 ISA Thumb Segment none
> <4>[ 23.238426] Control: 50c5387d Table: 0020406a DAC: 00000051
> <4>[ 23.244519] CPU: 0 PID: 49 Comm: hwrng Not tainted 6.0.0 #1
>
> Link: https://lore.kernel.org/all/Y0QJLauamRnCDUef@sirena.org.uk/
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-10 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <63426bce.170a0220.b8179.75b2@mx.google.com>
2022-10-10 11:59 ` next/pending-fixes bisection: baseline.login on bcm2836-rpi-2-b Mark Brown
2022-10-10 12:50 ` Jason A. Donenfeld
2022-10-10 13:52 ` Mark Brown
2022-10-10 15:06 ` [PATCH] hw_random: bcm2835: use hwrng_msleep() instead of cpu_relax() Jason A. Donenfeld
2022-10-10 15:37 ` Jason A. Donenfeld
2022-10-10 22:05 ` Florian Fainelli [this message]
2022-10-14 11:06 ` Herbert Xu
2022-10-17 20:31 ` next/pending-fixes bisection: baseline.login on bcm2836-rpi-2-b Jason A. Donenfeld
2022-10-18 11:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70991b49-fb31-d220-44a6-5ab6741c8fea@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Jason@zx2c4.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bot@kernelci.org \
--cc=broonie@kernel.org \
--cc=gtucker@collabora.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernelci-results@groups.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).