From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1A6C433E0 for ; Wed, 24 Feb 2021 01:58:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7529601FA for ; Wed, 24 Feb 2021 01:58:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7529601FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9/5Y0xcAsNG1z5dgbAySlMxBOy9obrpu8vH72bi4qU0=; b=haHpHTVqKtuwVSBAmCYyQyhK/ TRLFupOohpE3vD0aVe33rU9jCcbFm1gJ+RC3w1DmPMyMXwYtyo4kcwYDk8zqOhsim8GCHRIH9SEcX 6mzND9IbPvnpbkPTRdFQQUzf1d+trJzkrea4tVJ/m2eqztna1uDYCzfPVBuZconVkuITMHmxuXpOC TY2zwxxeFjGAOL79A76W1sUQJ6up4qB8P0EyOHrMhu7vhQKEoyFjgg12rbyCVjOUrqdT3j9LybM3z GBljCpTwbsUYyjllEBOPhcGfu7KGe3+3LPCDnAJ8rzGbiXbWzA7f7QHXKC5kmOJZzDwNAnaMbWr99 Zu22ZgPmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEjQy-0005wr-OZ; Wed, 24 Feb 2021 01:57:48 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEjQv-0005wO-Jr for linux-arm-kernel@lists.infradead.org; Wed, 24 Feb 2021 01:57:46 +0000 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 892BA20B6C40; Tue, 23 Feb 2021 17:57:37 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 892BA20B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1614131858; bh=CNeMw241KcxyH0UAcQxqFz1OLixiG1YC+76tEinbl/E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=GJ+7PxBqW3sVo/IP9/j2K6+Xlq1vNtLWiZTaXGNjvlEw/JDbWhxxdBRa7tLwVsH7S P1x/Uwz2bpke2Y4C8kjt3GCPxe2WUDxAId6KLgJQYQGdy7Rt2uBhlqiikaJcDCTf+J H9ExNZnRI4mIzR/eWi2w4C27Hb3AnKL6f+0qvOm0= Subject: Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function To: Thiago Jung Bauermann References: <20210221174930.27324-1-nramas@linux.microsoft.com> <20210221174930.27324-6-nramas@linux.microsoft.com> <874ki2w9ak.fsf@manicouagan.localdomain> From: Lakshmi Ramasubramanian Message-ID: <70ee14f5-12ee-f33d-a6ea-b890d390d67c@linux.microsoft.com> Date: Tue, 23 Feb 2021 17:57:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874ki2w9ak.fsf@manicouagan.localdomain> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210223_205745_864715_AE249EAE X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, benh@kernel.crashing.org, tao.li@vivo.com, zohar@linux.ibm.com, paulus@samba.org, vincenzo.frascino@arm.com, frowand.list@gmail.com, sashal@kernel.org, robh@kernel.org, mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org, takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, serge@hallyn.com, devicetree@vger.kernel.org, pasha.tatashin@soleen.com, will@kernel.org, sfr@canb.auug.org.au, prsriva@linux.microsoft.com, hsinyi@chromium.org, allison@lohutok.net, christophe.leroy@c-s.fr, mbrugger@suse.com, balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com, linux-kernel@vger.kernel.org, james.morse@arm.com, gregkh@linuxfoundation.org, joe@perches.com, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/23/21 5:20 PM, Thiago Jung Bauermann wrote: > > Lakshmi Ramasubramanian writes: > >> From: Rob Herring >> >> Both arm64 and powerpc do essentially the same FDT /chosen setup for >> kexec. The differences are either omissions that arm64 should have >> or additional properties that will be ignored. The setup code can be >> combined and shared by both powerpc and arm64. >> >> The differences relative to the arm64 version: >> - If /chosen doesn't exist, it will be created (should never happen). >> - Any old dtb and initrd reserved memory will be released. >> - The new initrd and elfcorehdr are marked reserved. >> - "linux,booted-from-kexec" is set. >> >> The differences relative to the powerpc version: >> - "kaslr-seed" and "rng-seed" may be set. >> - "linux,elfcorehdr" is set. >> - Any existing "linux,usable-memory-range" is removed. >> >> Combine the code for setting up the /chosen node in the FDT and updating >> the memory reservation for kexec, for powerpc and arm64, in >> of_kexec_alloc_and_setup_fdt() and move it to "drivers/of/kexec.c". >> >> Signed-off-by: Rob Herring >> Signed-off-by: Lakshmi Ramasubramanian >> Fixes: 33488dc4d61f ("of: Add a common kexec FDT setup function") > > A patch cannot fix itself. The world would be a much better place if it > could. :-) :) > >> Reported-by: kernel test robot >> --- >> drivers/of/Makefile | 6 + >> drivers/of/kexec.c | 265 ++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/of.h | 5 + >> 3 files changed, 276 insertions(+) >> create mode 100644 drivers/of/kexec.c > > With that fixed: > > Reviewed-by: Thiago Jung Bauermann Thanks for reviewing the patches Thiago. -lakshmi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel