linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
	"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller
Date: Wed, 9 Jan 2019 14:19:08 +0000	[thread overview]
Message-ID: <7188c406-3dd2-88a6-b6ed-d5e8bf678df8@kontron.de> (raw)
In-Reply-To: <1546939346-20181-1-git-send-email-yogeshnarayan.gaur@nxp.com>

On 08.01.19 10:24, Yogesh Narayan Gaur wrote:
> - Add driver for NXP FlexSPI host controller
> 
>   FlexSPI is a flexsible SPI host controller [1], Chapter 30 page 1475,
>   which supports two SPI channels and up to 4 external devices.
>   Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines)
>   i.e. FlexSPI acts as an interface to external devices, maximum 4, each with up to 8
>   bidirectional data lines.
> 
> - Tested this driver with mtd_debug(Erase/Write/Read) utility and JFFS2
>   filesystem mounting and booting on NXP LX2160ARDB[2] and LX2160AQDS targets.
>   LX2160ARDB is having two NOR slave device connected on single bus A
>   i.e. A0 and A1 (CS0 and CS1).
>   LX2160AQDS is having two NOR slave device connected on separate buses
>   one flash on A0 and second on B1 i.e. (CS0 and CS3).
>   Verified this driver on following SPI NOR flashes:
>     Micron, mt35xu512aba, [Read - 1 bit mode]
>     Cypress, s25fl512s, [Read - 1/2/4 bit mode]
> 
> [1] https://www.nxp.com/docs/en/reference-manual/IMXRT1050RM.pdf
> [2] https://patchwork.kernel.org/project/linux-arm-kernel/list/?submitter=182097
> 
> Yogesh Narayan Gaur (5):
>    spi: spi-mem: Add driver for NXP FlexSPI controller
>    dt-bindings: spi: add binding file for NXP FlexSPI controller
>    arm64: dts: lx2160a: add FlexSPI node property
>    arm64: defconfig: enable NXP FlexSPI driver
>    MAINTAINERS: add maintainers for the NXP FlexSPI driver
> 
> Changes for v6:
> - Rebase on top of v5.0-rc1.

Your patches don't apply to v5.0-rc1. It seems like you have instead 
rebased onto the for-5.1 or for-next branch of the SPI tree. I guess 
this is okay, but you should have pointed that out correctly here.

> - Incorporated review comments for
>    patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> - Updated s-b tag in all patches.
> Changes for v5:
> - Rebase on top of v4.20-rc2
> - Incorporated review comments for
>    patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> Changes for v4:
> - Incorporated review comments for
>    patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> - Incorporated binding file review comments.
> Changes for v3:
> - Incorporated review comments for
>    patch 'spi: spi-mem: Add driver for NXP FlexSPI controller'.
> Changes for v2:
> - Incorporated Boris review comments and drop below patches as per the comments.
>   - Patch 'spi: add slave device size in spi_device struct'
>   - Patch 'spi: add flags for octal I/O data transfer'
> - Incorporated DTS and Binding file review comments of Shawn Guo and Rob Herring.
> 
>   .../devicetree/bindings/spi/spi-nxp-fspi.txt  |   39 +
>   MAINTAINERS                                   |    7 +
>   .../boot/dts/freescale/fsl-lx2160a-rdb.dts    |   22 +
>   .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi |   13 +
>   arch/arm64/configs/defconfig                  |    1 +
>   drivers/spi/Kconfig                           |   10 +
>   drivers/spi/Makefile                          |    1 +
>   drivers/spi/spi-nxp-fspi.c                    | 1095 +++++++++++++++++
>   8 files changed, 1188 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>   create mode 100644 drivers/spi/spi-nxp-fspi.c
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-01-09 14:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  9:24 [PATCH v6 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller Yogesh Narayan Gaur
2019-01-08  9:24 ` [PATCH v6 1/5] " Yogesh Narayan Gaur
2019-01-10 17:28   ` Schrempf Frieder
2019-01-14  8:38     ` Boris Brezillon
2019-01-15  9:54       ` Yogesh Narayan Gaur
2019-01-08  9:24 ` [PATCH v6 2/5] dt-bindings: spi: add binding file " Yogesh Narayan Gaur
2019-01-08  9:24 ` [PATCH v6 3/5] arm64: dts: lx2160a: add FlexSPI node property Yogesh Narayan Gaur
2019-01-08  9:25 ` [PATCH v6 4/5] arm64: defconfig: enable NXP FlexSPI driver Yogesh Narayan Gaur
2019-01-08  9:25 ` [PATCH v6 5/5] MAINTAINERS: add maintainers for the " Yogesh Narayan Gaur
2019-01-09 14:19 ` Schrempf Frieder [this message]
2019-01-09 14:56   ` [PATCH v6 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller Lukasz Majewski
2019-01-09 15:26     ` Schrempf Frieder
2019-01-09 21:34       ` Lukasz Majewski
2019-01-10  5:12   ` Yogesh Narayan Gaur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7188c406-3dd2-88a6-b6ed-d5e8bf678df8@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=boris.brezillon@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).