From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Anand Moon <linux.amoon@gmail.com>
Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+
Date: Wed, 19 Oct 2022 12:45:10 +0200 [thread overview]
Message-ID: <7193025.LvFx2qVVIh@steina-w> (raw)
In-Reply-To: <20221018195122.8877-1-linux.amoon@gmail.com>
Am Dienstag, 18. Oktober 2022, 21:51:19 CEST schrieb Anand Moon:
> Odroid N2/N2+ support active cooling via gpio-fan controller.
> Add fan controls and tip point for cpu and ddr thermal sensor
> on this boards.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> .../dts/amlogic/meson-g12b-odroid-n2.dtsi | 42 +++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi index
> fd3fa82e4c33..e61a4285a910 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -39,6 +39,14 @@ emmc_pwrseq: emmc-pwrseq {
> reset-gpios = <&gpio BOOT_12 GPIO_ACTIVE_LOW>;
> };
>
> + fan: gpio-fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio_ao GPIOAO_10 GPIO_ACTIVE_HIGH>;
> + /* Using Dummy Speed */
> + gpio-fan,speed-map = <0 0>, <1 1>;
> + #cooling-cells = <2>;
> + };
> +
> leds {
> compatible = "gpio-leds";
>
> @@ -410,6 +418,40 @@ &cpu103 {
> clock-latency = <50000>;
> };
>
> +&cpu_thermal {
> + trips {
> + cpu_active: cpu-active {
> + temperature = <60000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&cpu_active>;
> + cooling-device = <&fan THERMAL_NO_LIMIT
THERMAL_NO_LIMIT>;
> + };
> + };
> +};
> +
> +&ddr_thermal {
> + trips {
> + ddr_active: cpu-active {
I suspect this node name shall be 'ddr-active', not 'cpu-active'.
Best regards,
Alexander
> + temperature = <60000>; /* millicelsius */
> + hysteresis = <2000>; /* millicelsius */
> + type = "active";
> + };
> + };
> +
> + cooling-maps {
> + map {
> + trip = <&ddr_active>;
> + cooling-device = <&fan THERMAL_NO_LIMIT
THERMAL_NO_LIMIT>;
> + };
> + };
> +};
> +
> &ext_mdio {
> external_phy: ethernet-phy@0 {
> /* Realtek RTL8211F (0x001cc916) */
>
> base-commit: aae703b02f92bde9264366c545e87cec451de471
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-19 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:51 [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ Anand Moon
2022-10-18 21:16 ` Martin Blumenstingl
2022-10-18 21:23 ` Dan Johansen
2022-10-19 3:06 ` Anand Moon
2022-10-19 9:48 ` Anand Moon
2022-10-19 11:08 ` Neil Armstrong
2022-10-19 17:16 ` Anand Moon
2022-10-19 20:40 ` Martin Blumenstingl
2022-10-20 8:15 ` neil.armstrong
2022-10-21 5:07 ` Anand Moon
2022-10-21 8:38 ` neil.armstrong
2022-10-19 7:24 ` Neil Armstrong
2022-10-19 10:45 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7193025.LvFx2qVVIh@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).