From: Ray Jui <ray.jui@broadcom.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 6/8] dt-bindings: i2c: iproc: add "brcm, iproc-nic-i2c" compatible string
Date: Thu, 14 Feb 2019 09:36:06 -0800 [thread overview]
Message-ID: <723faefb-d13d-caf0-3bbd-9e3e698436a4@broadcom.com> (raw)
In-Reply-To: <CAL_Jsq+aH=SGD+NJWNaWKnZm3Y396ro7E_Px_Ud3NnzOYB+eGQ@mail.gmail.com>
On 2/14/2019 6:02 AM, Rob Herring wrote:
> On Wed, Feb 13, 2019 at 4:09 PM Ray Jui <ray.jui@broadcom.com> wrote:
>>
>>
>>
>> On 2/13/2019 1:18 PM, Rob Herring wrote:
>>> On Mon, Feb 04, 2019 at 03:15:52PM -0800, Ray Jui wrote:
>>>> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>>>>
>>>> Update iProc I2C binding document to add new compatible string
>>>> "brcm,iproc-nic-i2c". Optional property "brcm,ape-hsls-addr-mask" is
>>>> also added that allows configuration of the host view into the APE's
>>>> address for "brcm,iproc-nic-i2c"
>>>>
>>>> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>>>> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
>>>> ---
>>>> Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt | 5 ++++-
>>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>>>> index d3a3620b1f06..02e82d20239e 100644
>>>> --- a/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>>>> +++ b/Documentation/devicetree/bindings/i2c/brcm,iproc-i2c.txt
>>>> @@ -3,7 +3,7 @@ Broadcom iProc I2C controller
>>>> Required properties:
>>>>
>>>> - compatible:
>>>> - Must be "brcm,iproc-i2c"
>>>> + Must be "brcm,iproc-i2c" or "brcm,iproc-nic-i2c"
>>>>
>>>> - reg:
>>>> Define the base and range of the I/O address space that contain the iProc
>>>> @@ -24,6 +24,9 @@ Optional properties:
>>>> Should contain the I2C interrupt. If unspecified, driver will fall back to
>>>> polling mode
>>>>
>>>> +- brcm,ape-hsls-addr-mask:
>>>> + Required for "brcm,iproc-nic-i2c". Host view of address mask into the
>>>> + 'APE' co-processor
>>>
>>> What's the data type and size? What are valid values?
>>
>> It's an unsigned u32 mask value. An example of a valid value is for
>> example 0x03400000. Do you want any of these added to the paragraph above?
>
> Yes. Bindings should define constraints.
Okay will do! Thanks.
>
> Rob
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-14 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 23:15 [PATCH v4 0/8] iProc I2C slave mode and NIC mode Ray Jui
2019-02-04 23:15 ` [PATCH v4 1/8] i2c: iproc: Extend I2C read up to 255 bytes Ray Jui
2019-02-04 23:15 ` [PATCH v4 2/8] i2c: iproc: Add slave mode support Ray Jui
2019-02-04 23:15 ` [PATCH v4 3/8] dt-bindings: i2c: iproc: make 'interrupts' optional Ray Jui
2019-02-13 21:16 ` Rob Herring
2019-02-13 22:06 ` Ray Jui
2019-02-14 14:16 ` Rob Herring
2019-02-14 17:36 ` Ray Jui
2019-02-04 23:15 ` [PATCH v4 4/8] i2c: iproc: add polling support Ray Jui
2019-02-04 23:15 ` [PATCH v4 5/8] i2c: iproc: use wrapper for read/write access Ray Jui
2019-02-04 23:15 ` [PATCH v4 6/8] dt-bindings: i2c: iproc: add "brcm, iproc-nic-i2c" compatible string Ray Jui
2019-02-13 21:18 ` Rob Herring
2019-02-13 22:09 ` Ray Jui
2019-02-14 14:02 ` Rob Herring
2019-02-14 17:36 ` Ray Jui [this message]
2019-02-04 23:15 ` [PATCH v4 7/8] i2c: iproc: add NIC I2C support Ray Jui
2019-02-04 23:15 ` [PATCH v4 8/8] arm64: dts: Stingray: Add NIC i2c device node Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=723faefb-d13d-caf0-3bbd-9e3e698436a4@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=robh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).