From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82638C352A1 for ; Tue, 6 Dec 2022 19:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DqlOV278WDFZvmG+jOEcaZeVj8Ve5Oy5FEO+qAw77vQ=; b=RRY181GVOPMkqL 2dulKz8VED0jPIylE7f9b1e0Ktkmk/1iRmIayPg5IgE3nGMlKeoobzpqK9+Jx2dVYlyErFdYJqSG8 x7mzu0pPQ0H22ToUsQrAmbWc/3EI6anzU17dmzk61N0u9etOVxDwBuePy+wPsf9dNenDk+OWxHpj8 anFyU1swjoQChgukMfTHmvpbRWfFU+FKceEuhMBN+hflc9WVudWp1b9simfDLwMhhMfs0jDcgT5Dv q9uHp1KGDk5GOWdgQeLTfjJwp1KF/qeSYa4/uF5S1FKF+xDDKz2yHjuBz5x6cXK4/HizENeEXKF3U dPqTN6hb2L6N+6OrZ+Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2dDS-000DG9-DP; Tue, 06 Dec 2022 19:02:54 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2dDO-000DFN-My; Tue, 06 Dec 2022 19:02:52 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D58DE84494; Tue, 6 Dec 2022 20:02:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1670353366; bh=qFsFrDF4S9vHBWurtsKa8StwT7cxQ0FXPVtnqJMfQ+Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Td/VLngOI6zCjCelD905cqKnH91oxZHaR35osfLQfJhIQC/xGNXqcu6I5IgG6yWXW Y1RttbSfg3sPH1dnOw7ey4nt1FrSKoCeEn9uj/yNqO1XMZwoXWoc72khQmIrqBFc7s XmBp6meJWb5r/67by1/B4YJJm7NLw2hFfSHQxl2cD9Mo98Dc/dFDYwDCaaFvtiUDPL GC+hZcNbmLMGipgInK90f664UCGDedHkcg9n39CPNT2l1wm2yFfa4hFBPFBY4AzCE6 3SXsctkOaGgkuVWQ0X0f7vQTQJrEQtDvaPQiI2rl012f13pYnEaS+SmHoQcQ/owk3f k/CzrZpwZeMfQ== Message-ID: <738f260d-225b-7ecf-20b2-a7541c368d36@denx.de> Date: Tue, 6 Dec 2022 20:02:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v1] Revert "ARM: dts: imx7: Fix NAND controller size-cells" Content-Language: en-US To: Miquel Raynal , Francesco Dolcini Cc: Shawn Guo , linux-arm-kernel@lists.infradead.org, Francesco Dolcini , Rob Herring , Krzysztof Kozlowski , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, stable@vger.kernel.org References: <20221205152327.26881-1-francesco@dolcini.it> <0aa2d48b-35a0-1781-f265-0387d213bdd6@denx.de> <20221205185859.433d6cbf@xps-13> <20221205191828.3072d872@xps-13> <29260d63-3240-6660-b002-cd00dc051574@denx.de> <20221206111643.1af08a9b@xps-13> From: Marek Vasut In-Reply-To: <20221206111643.1af08a9b@xps-13> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_110251_182003_560F7F8C X-CRM114-Status: GOOD ( 23.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/6/22 11:16, Miquel Raynal wrote: > Hi Francesco, Hello everyone, > francesco@dolcini.it wrote on Mon, 5 Dec 2022 20:07:18 +0100: > >> On Mon, Dec 05, 2022 at 07:52:08PM +0100, Marek Vasut wrote: >>> On 12/5/22 19:18, Miquel Raynal wrote: >>>> marex@denx.de wrote on Mon, 5 Dec 2022 19:07:14 +0100: >>>>> On 12/5/22 18:58, Miquel Raynal wrote: >>>>>> , it's not >>>>>> complex to do, there are plenty of examples. This would be IMHO a >>>>>> better step ahead rather than just a cell change. Anyway, I don't mind >>>>>> reverting this once we've sorted this mess out and fixed U-Boot. >>>>> >>>>> Won't we still have issues with older bootloader versions which >>>>> paste partitions directly into this &gpmi {} node, and which needs >>>>> to be fixed up in the parser in the end ? >>>> >>>> I believe fdt_fixup_mtdparts() should be killed, so we should no longer >>>> have this problem. >>> >>> The fdt_fixup_mtdparts is U-Boot code. If contemporary Linux kernel is >>> booted with ancient U-Boot, then you would still get defective DT passed to >>> Linux, and that should be fixed up by Linux. Removing fdt_fixup_mtdparts() >>> from current mainline U-Boot won't solve this problem. >>> >>> I think this is also what Francesco is trying to convey (please correct me >>> if I'm wrong). > > If we can get rid of fdt_fixup_mtdparts(), it means someone has to > create the partitions. I guess the easy way would be to just provide > mtdparts to Linux like all the other boards and let Linux deal with it. This is based on an assumption that the platform kernel command line can be updated to insert such a workaround. If Francesco cannot update the bootloader, the kernel command line may be immutable all the same. > Then we can just assume in Linux that perhaps if the partitions are > invalid (#size-cell is wrong?) then we should just stop their creation > and fallback to another mechanism instead of failing entirely. This way > no need for hackish changes in the parsers and compatibility is still > valid with old U-Boot (if mtdparts was provided on the cmdline, to be > checked). Otherwise we'll have to deal with it in Linux, that's a pity. I am very much banking toward -- fix it up in the parser, just like any other firmware issue. Esp. since the fix up is printing a warning, and it is like a 2-liner patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel