From: <Nicolas.Ferre@microchip.com>
To: <Tudor.Ambarus@microchip.com>, <kamel.bouhara@bootlin.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>,
<linux-arm-kernel@lists.infradead.org>
Cc: thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2] soc: at91: Add Atmel SFR SN (Serial Number) support
Date: Thu, 3 Oct 2019 12:06:23 +0000 [thread overview]
Message-ID: <741eeae3-666c-300f-23ba-6c646ad1252e@microchip.com> (raw)
In-Reply-To: <b3e10d4c-4cdc-4401-a488-0b3d101d9ad0@microchip.com>
On 03/10/2019 at 11:50, Tudor Ambarus - M18064 wrote:
>
>
> On 10/03/2019 12:40 PM, Tudor.Ambarus@microchip.com wrote:
> cut
>
>>
>> how about renaming this to struct atmel_sfr_priv?
>>
>>> + struct device *dev;
>>
>> this is not used, maybe you can drop it?
>>
>>> + struct regmap *regmap;
>>> + struct nvmem_config *config;
>
> where is priv->config used?
>
>>> + struct atmel_sfr_drvdata *drvdata;
>>
>> this is not used, maybe you can drop it?
>>
>>> +};
>
> cut
>
>>> +static struct atmel_sfr_drvdata sama5d2_sama5d4_drvdata = {
>
> struct should be const. And I'm not sure about the sama5d2_sama5d4 naming. Maybe
> choose "5d4_drvdata" and use it for 5d2 too? Maybe Nicolas has a preference here.
I'm not a big fan of "5d3/5d2/5d4" type of naming. If it appeared first
in sama5d4, then this name ca be taken to describe sama5d2 reality as
well => sama5d4_drvdata.
Now it's dropped in v3: so we're good...
>>> + .nregs = 2 * 4,
>>> +};
--
Nicolas Ferre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-03 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:16 [PATCH v2] soc: at91: Add Atmel SFR SN (Serial Number) support Kamel Bouhara
2019-10-03 9:40 ` Tudor.Ambarus
2019-10-03 9:50 ` Tudor.Ambarus
2019-10-03 12:06 ` Nicolas.Ferre [this message]
2019-10-03 12:10 ` Kamel Bouhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741eeae3-666c-300f-23ba-6c646ad1252e@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).