From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFEB8C433E0 for ; Thu, 4 Mar 2021 09:41:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BF1164E6B for ; Thu, 4 Mar 2021 09:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BF1164E6B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pUUDo9I6pbTj5wo2De3r0ZXqU9iyNRs51STBhdHca7g=; b=PXKHTE+luiSJxv23cHDcRfZFp 7bOnJTrcNSGfECASi36Zz7IDSLg5G4+y3SjVEFeAzka7+o+kv0NcpZiViouneLfCHP+FBNZjxwObJ 1ZshSaCHvHSXzwOBOwAS407NDobTxyZAaUXg9tJcZyXbGKdqW8jqrbh9npLH4R8UN4HZLsc9Qz2FF Z9QZoB6JzWqlGMu7WWSxQLNWQzmdKj9GPjWNe4yAJ2HCmmZpK6UKRwpZQIIO+6scxRQh9Q+odXZWW Jgpz6gWKxog89DbPUa5ixNo6Z2okCk99Wn58yiWGZOdC1A2eRk1R9bqFA6YRw+8ehZXI0ZTa6Pw3N CqWpZ8KQA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHkQC-008I1S-AW; Thu, 04 Mar 2021 09:37:28 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHkQ8-008I0R-8F for linux-arm-kernel@desiato.infradead.org; Thu, 04 Mar 2021 09:37:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=+9tOMO9fTOtIBnoTgXvN0p9KlFYYom635iLXdGt2iYY=; b=sk9zeXi0NdGxi45gC9RU6/wZZ8 +/makwM45jFVTK52J6VPQmFXxc9FXzrOeqxJNLSZBCq4svGwQuPk16XJ9BJnmCJc/H7R+KfiDS0RP HONIUxW+uFlj+tjfnaI+xzCUzk2j4/jeW/N6hQWA+VEhmS8gAh3UxJ5Ajpu40IByeqJyE8LCsWlVT xyOWPeogwwSZJIrTrUSUg6cJJfm5feT+kuqV8SSHW0N9+5H1/b3EJCNGhiuoYN2WCqCOkxXfpN01/ BKWqlVT02Cbc8yZL2dIHy3glFHM9OL4hvH8MGaEhe4hKZjaC5z8NZGddvj+IMKcWhuQYzckf5AA20 ZN49p4jQ==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHkPs-006SHl-6Q for linux-arm-kernel@lists.infradead.org; Thu, 04 Mar 2021 09:37:14 +0000 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Drlwd2XNSz67vMY; Thu, 4 Mar 2021 17:30:57 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Thu, 4 Mar 2021 10:36:41 +0100 Received: from [10.210.170.213] (10.210.170.213) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Thu, 4 Mar 2021 09:36:40 +0000 Subject: Re: [PATCH v7 2/4] perf tools: Add lexical definition of event name To: Shunsuke Nakamura , , , , , , , , , , CC: , References: <20210304032610.3112996-1-nakamura.shun@fujitsu.com> <20210304032610.3112996-3-nakamura.shun@fujitsu.com> From: John Garry Message-ID: <74955041-45ab-10df-e044-5d64898c81d9@huawei.com> Date: Thu, 4 Mar 2021 09:34:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210304032610.3112996-3-nakamura.shun@fujitsu.com> Content-Language: en-US X-Originating-IP: [10.210.170.213] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210304_093714_276886_07D6EE6D X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/03/2021 03:26, Shunsuke Nakamura wrote: > From: Shunsuke Nakamura > > Add the lexical definition of event name so that the numbers are recognizable. > Sorry for the hassle, but it's not clear that we got a definitive conclusion on this patch from v6 series: https://lore.kernel.org/lkml/YCuo01Wxxe%2FMCrC5@krava/ Would it be so much worse for you to change format of these event names to not start with a numberic? Thanks > A64FX defines an event name that starts with a number. > - 0inst_commit > - 1inst_commit > - 2inst_commit > - 3inst_commit > - 4inst_commit > > Signed-off-by: Shunsuke Nakamura > Acked-by: John Garry > --- > tools/perf/util/parse-events.l | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 0b36285a9435..33f627187415 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -205,7 +205,7 @@ bpf_source [^,{}]+\.c[a-zA-Z0-9._]* > num_dec [0-9]+ > num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > -name [a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]* > +name [a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]* > name_tag [\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\'] > name_minus [a-zA-Z_*?][a-zA-Z0-9\-_*?.:]* > drv_cfg_term [a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)? > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel